Browse Source

style(toxcall): Copy constructor return non-const reference

pull/3487/head
Diadlo 9 years ago
parent
commit
ed04b2debf
No known key found for this signature in database
GPG Key ID: 5AF9F2E29107C727
  1. 6
      src/core/toxcall.cpp
  2. 8
      src/core/toxcall.h

6
src/core/toxcall.cpp

@ -40,7 +40,7 @@ ToxCall::~ToxCall() @@ -40,7 +40,7 @@ ToxCall::~ToxCall()
audio.unsubscribeOutput(alSource);
}
const ToxCall& ToxCall::operator=(ToxCall&& other) noexcept
ToxCall& ToxCall::operator=(ToxCall&& other) noexcept
{
audioInConn = other.audioInConn;
other.audioInConn = QMetaObject::Connection();
@ -140,7 +140,7 @@ ToxFriendCall::~ToxFriendCall() @@ -140,7 +140,7 @@ ToxFriendCall::~ToxFriendCall()
}
}
const ToxFriendCall& ToxFriendCall::operator=(ToxFriendCall&& other) noexcept
ToxFriendCall& ToxFriendCall::operator=(ToxFriendCall&& other) noexcept
{
ToxCall::operator =(move(other));
videoEnabled = other.videoEnabled;
@ -174,7 +174,7 @@ ToxGroupCall::ToxGroupCall(ToxGroupCall&& other) noexcept @@ -174,7 +174,7 @@ ToxGroupCall::ToxGroupCall(ToxGroupCall&& other) noexcept
{
}
const ToxGroupCall &ToxGroupCall::operator=(ToxGroupCall &&other) noexcept
ToxGroupCall &ToxGroupCall::operator=(ToxGroupCall &&other) noexcept
{
ToxCall::operator =(move(other));

8
src/core/toxcall.h

@ -25,8 +25,8 @@ public: @@ -25,8 +25,8 @@ public:
ToxCall(ToxCall&& other) noexcept;
inline operator int() {return callId;}
const ToxCall& operator=(const ToxCall& other) = delete;
const ToxCall& operator=(ToxCall&& other) noexcept;
ToxCall& operator=(const ToxCall& other) = delete;
ToxCall& operator=(ToxCall&& other) noexcept;
protected:
QMetaObject::Connection audioInConn;
@ -46,7 +46,7 @@ struct ToxFriendCall : public ToxCall @@ -46,7 +46,7 @@ struct ToxFriendCall : public ToxCall
ToxFriendCall(ToxFriendCall&& other) noexcept;
~ToxFriendCall();
const ToxFriendCall& operator=(ToxFriendCall&& other) noexcept;
ToxFriendCall& operator=(ToxFriendCall&& other) noexcept;
bool videoEnabled; ///< True if our user asked for a video call, sending and recving
bool nullVideoBitrate; ///< True if our video bitrate is zero, i.e. if the device is closed
@ -70,7 +70,7 @@ struct ToxGroupCall : public ToxCall @@ -70,7 +70,7 @@ struct ToxGroupCall : public ToxCall
ToxGroupCall(int GroupNum, CoreAV& av);
ToxGroupCall(ToxGroupCall&& other) noexcept;
const ToxGroupCall& operator=(ToxGroupCall&& other) noexcept;
ToxGroupCall& operator=(ToxGroupCall&& other) noexcept;
// If you add something here, don't forget to override the ctors and move operators!
};

Loading…
Cancel
Save