Browse Source

[CodeIssues] Update some strings to be more inline with the rest of the issues (and more informative too).

newNRvisualizers
Simon Lindgren 14 years ago
parent
commit
eea162a9c9
  1. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/CallToVirtualFunctionFromConstructorIssue.cs
  2. 10
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/IncorrectExceptionParameterOrderingIssue.cs
  3. 2
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/SetterDoesNotUseValueParameterIssue.cs

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/CallToVirtualFunctionFromConstructorIssue.cs

@ -29,8 +29,8 @@ using ICSharpCode.NRefactory.Semantics;
namespace ICSharpCode.NRefactory.CSharp.Refactoring namespace ICSharpCode.NRefactory.CSharp.Refactoring
{ {
[IssueDescription("Virtual functions should not be called from constructors", [IssueDescription("Constructors should not call virtual members",
Description = "Warns about calls to virtual member functions occuring int the constructor.", Description = "Warns about calls to virtual member functions occuring in the constructor.",
Category = IssueCategories.CodeQualityIssues, Category = IssueCategories.CodeQualityIssues,
Severity = Severity.Warning)] Severity = Severity.Warning)]
public class CallToVirtualFunctionFromConstructorIssue : ICodeIssueProvider public class CallToVirtualFunctionFromConstructorIssue : ICodeIssueProvider
@ -76,7 +76,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
return; return;
if (targetMethod.IsVirtualCall) if (targetMethod.IsVirtualCall)
AddIssue(invocationExpression, AddIssue(invocationExpression,
context.TranslateString("Calling virtual functions in constructors is bad practice.")); context.TranslateString("Calling virtual functions in constructors is bad practice"));
} }
} }
} }

10
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/IncorrectExceptionParameterOrderingIssue.cs

@ -77,8 +77,14 @@ namespace ICSharpCode.NRefactory.CSharp
return; return;
if (!func(leftLength, rightLength)) if (!func(leftLength, rightLength))
AddIssue(objectCreateExpression, AddIssue(objectCreateExpression,
context.TranslateString("Swap parameters"), context.TranslateString("The parameters are in the wrong order"),
script => { GetActions(objectCreateExpression, firstParam, secondParam));
}
IEnumerable<CodeAction> GetActions(ObjectCreateExpression objectCreateExpression,
PrimitiveExpression firstParam, PrimitiveExpression secondParam)
{
yield return new CodeAction(context.TranslateString("Swap parameters"), script => {
var newOCE = objectCreateExpression.Clone() as ObjectCreateExpression; var newOCE = objectCreateExpression.Clone() as ObjectCreateExpression;
newOCE.Arguments.Clear(); newOCE.Arguments.Clear();
newOCE.Arguments.Add(secondParam.Clone()); newOCE.Arguments.Add(secondParam.Clone());

2
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/SetterDoesNotUseValueParameterIssue.cs

@ -86,7 +86,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
}, CancellationToken.None); }, CancellationToken.None);
if(!referenceFound) if(!referenceFound)
AddIssue(node, context.TranslateString("The setter does not use the 'value' parameter.")); AddIssue(node, context.TranslateString("The setter does not use the 'value' parameter"));
} }
} }
} }

Loading…
Cancel
Save