fix SD-1269 - Ask to close debugger (or not) while it's running - http://bugtracker.sharpdevelop.net/issue/ViewIssue.aspx?id=1269&PROJID=4

data/resources/StringResources.resx

@@ -5862,6 +5862,9 @@ Microsoft.Tools.WindowsInstallerXml.Extensions.NetFxCompiler, WixNetFxExtension<
   <data name="MainWindow.Windows.Debug.Watch.RemoveWatch" xml:space="preserve">
     <value>Remove watch</value>
   </data>
+  <data name="MainWindow.Windows.Debug.StopDebugging.Message" xml:space="preserve">
+    <value>Do you want to stop debugging?</value>
+  </data>
   <data name="MainWindow.Windows.DefinitionViewLabel" xml:space="preserve">
     <value>Definition View</value>
   </data>

src/Main/Base/Project/Src/Commands/FileMenuCommands.cs

@@ -39,10 +39,12 @@ namespace ICSharpCode.SharpDevelop.Project.Commands
 	{
 		public override void Run()
 		{
+			if (!ProjectService.IsClosingCanceled()) {
 				ProjectService.SaveSolutionPreferences();
 				if (WorkbenchSingleton.Workbench.CloseAllSolutionViews()) {
 					ProjectService.CloseSolution();
 				}
 			}
 		}
+	}
 }

src/Main/Base/Project/Src/Gui/Workbench/WpfWorkbench.cs

@@ -573,6 +573,8 @@ namespace ICSharpCode.SharpDevelop.Gui
 					return;
 				}
 				
+				if (!Project.ProjectService.IsClosingCanceled()) {
+					// save preferences
 					Project.ProjectService.SaveSolutionPreferences();
 					
 					while (WorkbenchSingleton.Workbench.WorkbenchWindowCollection.Count > 0) {
@@ -593,6 +595,9 @@ namespace ICSharpCode.SharpDevelop.Gui
 					foreach (PadDescriptor padDescriptor in this.PadContentCollection) {
 						padDescriptor.Dispose();
 					}
+				} else {
+					e.Cancel = true;
+				}
 			}
 		}
 		

src/Main/Base/Project/Src/Gui/WorkbenchSingleton.cs

@@ -114,6 +114,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 		/// </summary>
 		public static void OnWorkbenchUnloaded()
 		{
+			if (!Project.ProjectService.IsClosingCanceled()) {
 				Project.ProjectService.CloseSolution();
 				NavigationService.Unload();
 				
@@ -123,6 +124,7 @@ namespace ICSharpCode.SharpDevelop.Gui
 				
 				FileService.Unload();
 			}
+		}
 		
 		#region Safe Thread Caller
 		public static bool InvokeRequired {

src/Main/Base/Project/Src/Services/Debugger/DebuggerService.cs

@@ -28,6 +28,8 @@ namespace ICSharpCode.SharpDevelop.Debugging
 				ClearDebugMessages();
 			};
 			
+			ProjectService.BeforeSolutionClosing += OnBeforeSolutionClosing;
+			
 			BookmarkManager.Added   += BookmarkAdded;
 			BookmarkManager.Removed += BookmarkRemoved;
 		}
@@ -222,6 +224,29 @@ namespace ICSharpCode.SharpDevelop.Debugging
 			}
 		}
 		
+		static void OnBeforeSolutionClosing(object sender, SolutionCancelEventArgs e)
+		{
+			if (currentDebugger == null)
+				return;
+			
+			if (currentDebugger.IsDebugging) {
+				string caption = StringParser.Parse("${res:XML.MainMenu.DebugMenu.Stop}");
+				string message = StringParser.Parse("${res:MainWindow.Windows.Debug.StopDebugging.Message}");
+				string[] buttonLabels = new string[] { StringParser.Parse("${res:Global.Yes}"), StringParser.Parse("${res:Global.No}") };
+				int result = MessageService.ShowCustomDialog(caption,
+				                                             message,
+				                                             0, // yes
+				                                             1, // no
+				                                             buttonLabels);
+				
+				if (result == 0) {
+					currentDebugger.Stop();
+				} else {
+					e.Cancel = true;
+				}
+			}
+		}
+		
 		public static void ToggleBreakpointAt(ITextEditor editor, int lineNumber)
 		{
 			BookmarkManager.ToggleBookmark(

src/Main/Base/Project/Src/Services/ProjectService/ProjectService.cs

@@ -242,7 +242,7 @@ namespace ICSharpCode.SharpDevelop.Project
 		
 		static void BeforeLoadSolution()
 		{
-			if (openSolution != null) {
+			if (openSolution != null && !IsClosingCanceled()) {
 				SaveSolutionPreferences();
 				WorkbenchSingleton.Workbench.CloseAllViews();
 				CloseSolution();
@@ -258,6 +258,10 @@ namespace ICSharpCode.SharpDevelop.Project
 		{
 			if (!Path.IsPathRooted(fileName))
 				throw new ArgumentException("Path must be rooted!");
+			
+			if (IsClosingCanceled())
+				return;
+			
 			BeforeLoadSolution();
 			OnSolutionLoading(fileName);
 			try {
@@ -500,7 +504,28 @@ namespace ICSharpCode.SharpDevelop.Project
 			}
 		}
 		
-		public static void CloseSolution()
+		/// <summary>
+		/// Executes the OnBeforeSolutionClosing event.
+		/// </summary>
+		/// <remarks>This method must be used after CloseSolution is called.</remarks>
+		/// <returns><c>true</c>, if closing solution was canceled; <c>false</c>, otherwise.</returns>
+		internal static bool IsClosingCanceled()
+		{
+			// run onbefore closing
+			var beforeClosingArgs = new SolutionCancelEventArgs(openSolution);
+			OnBeforeSolutionClosing(beforeClosingArgs);
+			
+			return beforeClosingArgs.Cancel;
+		}
+		
+		/// <summary>
+		/// Closes the solution: cancels build, clears solution data, fires the SolutionClosing and SolutionClosed events.
+		/// <remarks>
+		/// 	Before invoking this method, one should check if the closing was canceled (<see cref="IsClosingCanceled"/>),
+		/// 	save solution and project data (e.g. files, bookmarks), then invoke CloseSolution().
+		/// </remarks>
+		/// </summary>
+		internal static void CloseSolution()
 		{
 			// If a build is running, cancel it.
 			// If we would let a build run but unload the MSBuild projects, the next project.StartBuild call
@@ -541,6 +566,13 @@ namespace ICSharpCode.SharpDevelop.Project
 			}
 		}
 		
+		static void OnBeforeSolutionClosing(SolutionCancelEventArgs e)
+		{
+			if (BeforeSolutionClosing != null) {
+				BeforeSolutionClosing(null, e);
+			}
+		}
+		
 		static void OnSolutionLoading(string fileName)
 		{
 			if (SolutionLoading != null) {
@@ -714,6 +746,15 @@ namespace ICSharpCode.SharpDevelop.Project
 		public static event EventHandler<SolutionEventArgs> SolutionClosing;
 		public static event EventHandler                    SolutionClosed;
 		
+		/// <summary>
+		/// Raised before SolutionClosing.
+		/// <remarks>
+		/// When one modifies the e.Cancel property, should have in mind that other consumers might want to cancel the closing.<br/>
+		/// Setting e.Cancel = false might override other consumers (if they exist) e.Cancel = true, and might break other functionalities.
+		/// </remarks>
+		/// </summary>
+		public static event EventHandler<SolutionCancelEventArgs> BeforeSolutionClosing;
+		
 		/// <summary>
 		/// Raised before the solution preferences are being saved. Allows you to save
 		/// your additional properties in the solution preferences.