Daniel Grunwald
13 years ago
54 changed files with 937 additions and 447 deletions
@ -0,0 +1,106 @@ |
|||||||
|
//
|
||||||
|
// MissingStringComparisonIssue.cs
|
||||||
|
//
|
||||||
|
// Author:
|
||||||
|
// Daniel Grunwald <daniel@danielgrunwald.de>
|
||||||
|
//
|
||||||
|
// Copyright (c) 2012 Daniel Grunwald
|
||||||
|
//
|
||||||
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||||
|
// of this software and associated documentation files (the "Software"), to deal
|
||||||
|
// in the Software without restriction, including without limitation the rights
|
||||||
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||||
|
// copies of the Software, and to permit persons to whom the Software is
|
||||||
|
// furnished to do so, subject to the following conditions:
|
||||||
|
//
|
||||||
|
// The above copyright notice and this permission notice shall be included in
|
||||||
|
// all copies or substantial portions of the Software.
|
||||||
|
//
|
||||||
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||||
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||||
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||||
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||||
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||||
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||||
|
// THE SOFTWARE.
|
||||||
|
|
||||||
|
using System; |
||||||
|
using System.Collections.Generic; |
||||||
|
using System.Linq; |
||||||
|
using ICSharpCode.NRefactory.Semantics; |
||||||
|
using ICSharpCode.NRefactory.TypeSystem; |
||||||
|
using ICSharpCode.NRefactory.TypeSystem.Implementation; |
||||||
|
|
||||||
|
namespace ICSharpCode.NRefactory.CSharp.Refactoring |
||||||
|
{ |
||||||
|
[IssueDescription("Missing StringComparison argument", |
||||||
|
Description = "Warns when a culture-aware comparison is used by default.", |
||||||
|
Category = IssueCategories.CodeQualityIssues, |
||||||
|
Severity = Severity.Warning)] |
||||||
|
public class MissingStringComparisonIssue : ICodeIssueProvider |
||||||
|
{ |
||||||
|
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context) |
||||||
|
{ |
||||||
|
return new GatherVisitor(context).GetIssues(); |
||||||
|
} |
||||||
|
|
||||||
|
class GatherVisitor : GatherVisitorBase |
||||||
|
{ |
||||||
|
public GatherVisitor(BaseRefactoringContext ctx) : base(ctx) |
||||||
|
{ |
||||||
|
} |
||||||
|
|
||||||
|
public override void VisitInvocationExpression(InvocationExpression invocationExpression) |
||||||
|
{ |
||||||
|
base.VisitInvocationExpression(invocationExpression); |
||||||
|
|
||||||
|
MemberReferenceExpression mre = invocationExpression.Target as MemberReferenceExpression; |
||||||
|
if (mre == null) |
||||||
|
return; |
||||||
|
switch (mre.MemberName) { |
||||||
|
case "StartsWith": |
||||||
|
case "EndsWith": |
||||||
|
if (invocationExpression.Arguments.Count != 1) |
||||||
|
return; |
||||||
|
break; |
||||||
|
case "IndexOf": |
||||||
|
case "LastIndexOf": |
||||||
|
break; |
||||||
|
default: |
||||||
|
return; |
||||||
|
} |
||||||
|
|
||||||
|
var rr = ctx.Resolve(invocationExpression) as InvocationResolveResult; |
||||||
|
if (rr == null || rr.IsError) { |
||||||
|
// Not an invocation resolve result - e.g. could be a UnknownMemberResolveResult instead
|
||||||
|
return; |
||||||
|
} |
||||||
|
if (!(rr.Member.DeclaringTypeDefinition != null && rr.Member.DeclaringTypeDefinition.KnownTypeCode == KnownTypeCode.String)) { |
||||||
|
// Not a string operation
|
||||||
|
return; |
||||||
|
} |
||||||
|
IParameter firstParameter = rr.Member.Parameters.FirstOrDefault(); |
||||||
|
if (firstParameter == null || !firstParameter.Type.IsKnownType(KnownTypeCode.String)) |
||||||
|
return; // First parameter not a string
|
||||||
|
IParameter lastParameter = rr.Member.Parameters.Last(); |
||||||
|
if (lastParameter.Type.Name == "StringComparison") |
||||||
|
return; // already specifying a string comparison
|
||||||
|
AddIssue(invocationExpression.LParToken.StartLocation, invocationExpression.RParToken.EndLocation, |
||||||
|
mre.MemberName + "() call is missing StringComparison argument", |
||||||
|
new [] { |
||||||
|
new CodeAction("Use ordinal comparison", script => AddArgument(script, invocationExpression, "Ordinal")), |
||||||
|
new CodeAction("Use culture-aware comparison", script => AddArgument(script, invocationExpression, "CurrentCulture")), |
||||||
|
}); |
||||||
|
} |
||||||
|
|
||||||
|
void AddArgument(Script script, InvocationExpression invocationExpression, string stringComparison) |
||||||
|
{ |
||||||
|
var astBuilder = ctx.CreateTypeSytemAstBuilder(invocationExpression); |
||||||
|
var newArgument = astBuilder.ConvertType(new TopLevelTypeName("System", "StringComparison")).Member(stringComparison); |
||||||
|
var copy = (InvocationExpression)invocationExpression.Clone(); |
||||||
|
copy.Arguments.Add(newArgument); |
||||||
|
script.Replace(invocationExpression, copy); |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
@ -0,0 +1,58 @@ |
|||||||
|
// Copyright (c) AlphaSierraPapa for the SharpDevelop Team
|
||||||
|
//
|
||||||
|
// Permission is hereby granted, free of charge, to any person obtaining a copy of this
|
||||||
|
// software and associated documentation files (the "Software"), to deal in the Software
|
||||||
|
// without restriction, including without limitation the rights to use, copy, modify, merge,
|
||||||
|
// publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons
|
||||||
|
// to whom the Software is furnished to do so, subject to the following conditions:
|
||||||
|
//
|
||||||
|
// The above copyright notice and this permission notice shall be included in all copies or
|
||||||
|
// substantial portions of the Software.
|
||||||
|
//
|
||||||
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
|
||||||
|
// INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR
|
||||||
|
// PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE
|
||||||
|
// FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
||||||
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
||||||
|
// DEALINGS IN THE SOFTWARE.
|
||||||
|
|
||||||
|
using System; |
||||||
|
using System.Collections.Generic; |
||||||
|
using ICSharpCode.NRefactory.Semantics; |
||||||
|
using ICSharpCode.NRefactory.TypeSystem; |
||||||
|
|
||||||
|
namespace ICSharpCode.NRefactory.CSharp.Refactoring |
||||||
|
{ |
||||||
|
[IssueDescription("Result of async call is ignored", |
||||||
|
Description = "Warns when the task returned by an async call is ignored, which causes exceptions" + |
||||||
|
" thrown by the call to be silently ignored.", |
||||||
|
Category = IssueCategories.CodeQualityIssues, |
||||||
|
Severity = Severity.Warning)] |
||||||
|
public class ResultOfAsyncCallShouldNotBeIgnoredIssue : ICodeIssueProvider |
||||||
|
{ |
||||||
|
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context) |
||||||
|
{ |
||||||
|
return new GatherVisitor(context).GetIssues(); |
||||||
|
} |
||||||
|
|
||||||
|
sealed class GatherVisitor : GatherVisitorBase |
||||||
|
{ |
||||||
|
public GatherVisitor(BaseRefactoringContext ctx) |
||||||
|
: base(ctx) |
||||||
|
{ |
||||||
|
} |
||||||
|
|
||||||
|
public override void VisitExpressionStatement(ExpressionStatement expressionStatement) |
||||||
|
{ |
||||||
|
base.VisitExpressionStatement(expressionStatement); |
||||||
|
var invocation = expressionStatement.Expression as InvocationExpression; |
||||||
|
if (invocation == null) |
||||||
|
return; |
||||||
|
var rr = ctx.Resolve(invocation) as InvocationResolveResult; |
||||||
|
if (rr != null && (rr.Type.IsKnownType(KnownTypeCode.Task) || rr.Type.IsKnownType(KnownTypeCode.TaskOfT))) { |
||||||
|
AddIssue(invocation, "Exceptions in async call will be silently ignored because the returned task is unused"); |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
@ -1,69 +0,0 @@ |
|||||||
//
|
|
||||||
// LocalVariableOnlyAssignedIssue.cs
|
|
||||||
//
|
|
||||||
// Author:
|
|
||||||
// Mansheng Yang <lightyang0@gmail.com>
|
|
||||||
//
|
|
||||||
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
|
|
||||||
//
|
|
||||||
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
||||||
// of this software and associated documentation files (the "Software"), to deal
|
|
||||||
// in the Software without restriction, including without limitation the rights
|
|
||||||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
||||||
// copies of the Software, and to permit persons to whom the Software is
|
|
||||||
// furnished to do so, subject to the following conditions:
|
|
||||||
//
|
|
||||||
// The above copyright notice and this permission notice shall be included in
|
|
||||||
// all copies or substantial portions of the Software.
|
|
||||||
//
|
|
||||||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
||||||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
||||||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
||||||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
||||||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
||||||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
||||||
// THE SOFTWARE.
|
|
||||||
|
|
||||||
using ICSharpCode.NRefactory.Semantics; |
|
||||||
|
|
||||||
namespace ICSharpCode.NRefactory.CSharp.Refactoring |
|
||||||
{ |
|
||||||
|
|
||||||
[IssueDescription ("Local variable is only assigned", |
|
||||||
Description = "Local variable is assigned by its value is never used", |
|
||||||
Category = IssueCategories.CodeQualityIssues, |
|
||||||
Severity = Severity.Warning, |
|
||||||
IssueMarker = IssueMarker.Underline)] |
|
||||||
public class LocalVariableOnlyAssignedIssue : VariableOnlyAssignedIssue |
|
||||||
{ |
|
||||||
internal override GatherVisitorBase GetGatherVisitor (BaseRefactoringContext ctx) |
|
||||||
{ |
|
||||||
return new GatherVisitor (ctx); |
|
||||||
} |
|
||||||
|
|
||||||
class GatherVisitor : GatherVisitorBase |
|
||||||
{ |
|
||||||
public GatherVisitor (BaseRefactoringContext ctx) |
|
||||||
: base (ctx) |
|
||||||
{ |
|
||||||
} |
|
||||||
|
|
||||||
public override void VisitVariableInitializer (VariableInitializer variableInitializer) |
|
||||||
{ |
|
||||||
base.VisitVariableInitializer (variableInitializer); |
|
||||||
|
|
||||||
var decl = variableInitializer.Parent as VariableDeclarationStatement; |
|
||||||
if (decl == null) |
|
||||||
return; |
|
||||||
|
|
||||||
var resolveResult = ctx.Resolve (variableInitializer) as LocalResolveResult; |
|
||||||
if (resolveResult == null) |
|
||||||
return; |
|
||||||
if (!TestOnlyAssigned (ctx, decl.Parent, resolveResult.Variable)) |
|
||||||
return; |
|
||||||
AddIssue (variableInitializer.NameToken, |
|
||||||
ctx.TranslateString ("Local variable is assigned by its value is never used")); |
|
||||||
} |
|
||||||
} |
|
||||||
} |
|
||||||
} |
|
||||||
@ -1,128 +0,0 @@ |
|||||||
//
|
|
||||||
// TypeCompatibilityHelper.cs
|
|
||||||
//
|
|
||||||
// Author:
|
|
||||||
// Mansheng Yang <lightyang0@gmail.com>
|
|
||||||
//
|
|
||||||
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
|
|
||||||
//
|
|
||||||
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
||||||
// of this software and associated documentation files (the "Software"), to deal
|
|
||||||
// in the Software without restriction, including without limitation the rights
|
|
||||||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
||||||
// copies of the Software, and to permit persons to whom the Software is
|
|
||||||
// furnished to do so, subject to the following conditions:
|
|
||||||
//
|
|
||||||
// The above copyright notice and this permission notice shall be included in
|
|
||||||
// all copies or substantial portions of the Software.
|
|
||||||
//
|
|
||||||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
||||||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
||||||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
||||||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
||||||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
||||||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
||||||
// THE SOFTWARE.
|
|
||||||
|
|
||||||
using System.Collections.Generic; |
|
||||||
using System.Linq; |
|
||||||
using ICSharpCode.NRefactory.TypeSystem; |
|
||||||
|
|
||||||
namespace ICSharpCode.NRefactory.CSharp.Refactoring |
|
||||||
{ |
|
||||||
class TypeCompatibilityHelper |
|
||||||
{ |
|
||||||
public enum TypeCompatiblity |
|
||||||
{ |
|
||||||
MayOfProvidedType, |
|
||||||
AlwaysOfProvidedType, |
|
||||||
NeverOfProvidedType |
|
||||||
} |
|
||||||
|
|
||||||
static bool CheckTypeParameterConstraints (IType type, IEnumerable<IType> baseTypes, |
|
||||||
ITypeParameter typeParameter) |
|
||||||
{ |
|
||||||
if (!typeParameter.DirectBaseTypes.All (t => baseTypes.Any (t2 => t2.Equals (t)))) |
|
||||||
return false; |
|
||||||
if (typeParameter.HasDefaultConstructorConstraint && |
|
||||||
!type.GetConstructors (c => c.IsPublic && c.Parameters.Count == 0).Any ()) |
|
||||||
return false; |
|
||||||
return true; |
|
||||||
} |
|
||||||
|
|
||||||
public static TypeCompatiblity CheckTypeCompatibility(IType exprType, IType providedType) |
|
||||||
{ |
|
||||||
var exprBaseTypes = exprType.GetAllBaseTypes ().ToArray (); |
|
||||||
|
|
||||||
// providedType is a base type of exprType
|
|
||||||
if (exprBaseTypes.Any (t => t.Equals (providedType))) |
|
||||||
return TypeCompatiblity.AlwaysOfProvidedType; |
|
||||||
|
|
||||||
if ((exprType.IsReferenceType == true && providedType.IsReferenceType == false) || |
|
||||||
(exprType.IsReferenceType == false && providedType.IsReferenceType == true)) |
|
||||||
return TypeCompatiblity.NeverOfProvidedType; |
|
||||||
|
|
||||||
var typeParameter = exprType as ITypeParameter; |
|
||||||
var providedTypeParameter = providedType as ITypeParameter; |
|
||||||
|
|
||||||
if (typeParameter != null) { |
|
||||||
// check if providedType can be a derived type
|
|
||||||
var providedBaseTypes = providedType.GetAllBaseTypes ().ToArray (); |
|
||||||
var providedTypeDef = providedType.GetDefinition (); |
|
||||||
// if providedType is sealed, check if it fullfills all the type parameter constraints,
|
|
||||||
// otherwise, only check if it is derived from EffectiveBaseClass
|
|
||||||
if (providedTypeParameter == null && (providedTypeDef == null || providedTypeDef.IsSealed)) { |
|
||||||
if (CheckTypeParameterConstraints (providedType, providedBaseTypes, typeParameter)) |
|
||||||
return TypeCompatiblity.MayOfProvidedType; |
|
||||||
} else if (providedBaseTypes.Any (t => t.Equals (typeParameter.EffectiveBaseClass))) { |
|
||||||
return TypeCompatiblity.MayOfProvidedType; |
|
||||||
} |
|
||||||
|
|
||||||
// if providedType is also a type parameter, check if base classes are compatible
|
|
||||||
if (providedTypeParameter != null && |
|
||||||
exprBaseTypes.Any (t => t.Equals (providedTypeParameter.EffectiveBaseClass))) |
|
||||||
return TypeCompatiblity.MayOfProvidedType; |
|
||||||
|
|
||||||
return TypeCompatiblity.NeverOfProvidedType; |
|
||||||
} |
|
||||||
// check if exprType fullfills all the type parameter constraints
|
|
||||||
if (providedTypeParameter != null && |
|
||||||
CheckTypeParameterConstraints (exprType, exprBaseTypes, providedTypeParameter)) |
|
||||||
return TypeCompatiblity.MayOfProvidedType; |
|
||||||
|
|
||||||
switch (exprType.Kind) { |
|
||||||
case TypeKind.Class: |
|
||||||
var exprTypeDef = exprType.GetDefinition (); |
|
||||||
if (exprTypeDef == null) |
|
||||||
return TypeCompatiblity.MayOfProvidedType; |
|
||||||
// exprType is sealed, but providedType is not a base type of it or it does not
|
|
||||||
// fullfill all the type parameter constraints
|
|
||||||
if (exprTypeDef.IsSealed) |
|
||||||
break; |
|
||||||
|
|
||||||
// check if providedType can be a derived type
|
|
||||||
if (providedType.Kind == TypeKind.Interface || |
|
||||||
providedType.GetAllBaseTypes ().Any (t => t.Equals (exprType))) |
|
||||||
return TypeCompatiblity.MayOfProvidedType; |
|
||||||
|
|
||||||
if (providedTypeParameter != null && |
|
||||||
exprBaseTypes.Any (t => t.Equals (providedTypeParameter.EffectiveBaseClass))) |
|
||||||
return TypeCompatiblity.MayOfProvidedType; |
|
||||||
|
|
||||||
break; |
|
||||||
|
|
||||||
case TypeKind.Struct: |
|
||||||
case TypeKind.Delegate: |
|
||||||
case TypeKind.Enum: |
|
||||||
case TypeKind.Array: |
|
||||||
case TypeKind.Anonymous: |
|
||||||
case TypeKind.Null: |
|
||||||
break; |
|
||||||
|
|
||||||
default: |
|
||||||
return TypeCompatiblity.MayOfProvidedType; |
|
||||||
} |
|
||||||
return TypeCompatiblity.NeverOfProvidedType; |
|
||||||
} |
|
||||||
} |
|
||||||
} |
|
||||||
@ -1,97 +0,0 @@ |
|||||||
//
|
|
||||||
// LocalVariableOnlyAssignedIssueTests.cs
|
|
||||||
//
|
|
||||||
// Author:
|
|
||||||
// Mansheng Yang <lightyang0@gmail.com>
|
|
||||||
//
|
|
||||||
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
|
|
||||||
//
|
|
||||||
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
||||||
// of this software and associated documentation files (the "Software"), to deal
|
|
||||||
// in the Software without restriction, including without limitation the rights
|
|
||||||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
||||||
// copies of the Software, and to permit persons to whom the Software is
|
|
||||||
// furnished to do so, subject to the following conditions:
|
|
||||||
//
|
|
||||||
// The above copyright notice and this permission notice shall be included in
|
|
||||||
// all copies or substantial portions of the Software.
|
|
||||||
//
|
|
||||||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
||||||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
||||||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
||||||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
||||||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
||||||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
||||||
// THE SOFTWARE.
|
|
||||||
|
|
||||||
using ICSharpCode.NRefactory.CSharp.Refactoring; |
|
||||||
using NUnit.Framework; |
|
||||||
|
|
||||||
namespace ICSharpCode.NRefactory.CSharp.CodeIssues |
|
||||||
{ |
|
||||||
[TestFixture] |
|
||||||
public class LocalVariableOnlyAssignedIssueTests : InspectionActionTestBase |
|
||||||
{ |
|
||||||
[Test] |
|
||||||
public void TestUnusedValue () |
|
||||||
{ |
|
||||||
var input1 = @"
|
|
||||||
class TestClass |
|
||||||
{ |
|
||||||
void TestMethod() |
|
||||||
{ |
|
||||||
int i = 1; |
|
||||||
i++; |
|
||||||
} |
|
||||||
}";
|
|
||||||
Test<LocalVariableOnlyAssignedIssue> (input1, 1); |
|
||||||
|
|
||||||
var input2 = @"
|
|
||||||
class TestClass |
|
||||||
{ |
|
||||||
void TestMethod() |
|
||||||
{ |
|
||||||
int i; |
|
||||||
i = 1; |
|
||||||
} |
|
||||||
}";
|
|
||||||
Test<LocalVariableOnlyAssignedIssue> (input2, 1); |
|
||||||
} |
|
||||||
|
|
||||||
[Test] |
|
||||||
public void TestUsedValue () |
|
||||||
{ |
|
||||||
var input = @"
|
|
||||||
class TestClass |
|
||||||
{ |
|
||||||
int TestMethod() |
|
||||||
{ |
|
||||||
int i; |
|
||||||
i = 1; |
|
||||||
int j = i + 1; |
|
||||||
return j; |
|
||||||
} |
|
||||||
}";
|
|
||||||
Test<LocalVariableOnlyAssignedIssue> (input, 0); |
|
||||||
} |
|
||||||
|
|
||||||
[Test] |
|
||||||
public void TestOutArgument () |
|
||||||
{ |
|
||||||
var input1 = @"
|
|
||||||
class TestClass |
|
||||||
{ |
|
||||||
void Test (out int i) |
|
||||||
{ |
|
||||||
i = 1; |
|
||||||
} |
|
||||||
void TestMethod() |
|
||||||
{ |
|
||||||
int i = 1; |
|
||||||
Test (out i); |
|
||||||
} |
|
||||||
}";
|
|
||||||
Test<LocalVariableOnlyAssignedIssue> (input1, 1); |
|
||||||
} |
|
||||||
} |
|
||||||
} |
|
||||||
@ -0,0 +1,93 @@ |
|||||||
|
//
|
||||||
|
// Author:
|
||||||
|
// Daniel Grunwald <daniel@danielgrunwald.de>
|
||||||
|
//
|
||||||
|
// Copyright (c) 2012 Daniel Grunwald
|
||||||
|
//
|
||||||
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||||
|
// of this software and associated documentation files (the "Software"), to deal
|
||||||
|
// in the Software without restriction, including without limitation the rights
|
||||||
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||||
|
// copies of the Software, and to permit persons to whom the Software is
|
||||||
|
// furnished to do so, subject to the following conditions:
|
||||||
|
//
|
||||||
|
// The above copyright notice and this permission notice shall be included in
|
||||||
|
// all copies or substantial portions of the Software.
|
||||||
|
//
|
||||||
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||||
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||||
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||||
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||||
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||||
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||||
|
// THE SOFTWARE.
|
||||||
|
|
||||||
|
using System; |
||||||
|
using ICSharpCode.NRefactory.CSharp.Refactoring; |
||||||
|
using NUnit.Framework; |
||||||
|
|
||||||
|
namespace ICSharpCode.NRefactory.CSharp.CodeIssues |
||||||
|
{ |
||||||
|
[TestFixture] |
||||||
|
public class MissingStringComparisonIssueTests : InspectionActionTestBase |
||||||
|
{ |
||||||
|
const string stringIndexOfStringCalls = @"using System;
|
||||||
|
using System.Collections.Generic; |
||||||
|
class Test { |
||||||
|
public void StringIndexOfStringCalls(List<string> list) |
||||||
|
{ |
||||||
|
list[0].IndexOf("".com""); |
||||||
|
list[0].IndexOf("".com"", 0); |
||||||
|
list[0].IndexOf("".com"", 0, 5); |
||||||
|
list[0].IndexOf(list[1], 0, 10); |
||||||
|
} |
||||||
|
}";
|
||||||
|
const string stringIndexOfStringCallsWithComparison = @"using System;
|
||||||
|
using System.Collections.Generic; |
||||||
|
class Test { |
||||||
|
public void StringIndexOfStringCalls(List<string> list) |
||||||
|
{ |
||||||
|
list [0].IndexOf ("".com"", StringComparison.Ordinal); |
||||||
|
list [0].IndexOf ("".com"", 0, StringComparison.Ordinal); |
||||||
|
list [0].IndexOf ("".com"", 0, 5, StringComparison.Ordinal); |
||||||
|
list [0].IndexOf (list [1], 0, 10, StringComparison.Ordinal); |
||||||
|
} |
||||||
|
}";
|
||||||
|
|
||||||
|
[Test] |
||||||
|
public void IndexOfStringCalls() |
||||||
|
{ |
||||||
|
Test<MissingStringComparisonIssue>(stringIndexOfStringCalls, 4, stringIndexOfStringCallsWithComparison); |
||||||
|
} |
||||||
|
|
||||||
|
[Test] |
||||||
|
public void IndexOfStringCallsAlreadyWithComparison() |
||||||
|
{ |
||||||
|
Test<MissingStringComparisonIssue>(stringIndexOfStringCallsWithComparison, 0); |
||||||
|
} |
||||||
|
|
||||||
|
[Test] |
||||||
|
public void StringIndexOfChar() |
||||||
|
{ |
||||||
|
string program = @"using System;
|
||||||
|
class Test { |
||||||
|
void M(string text) { |
||||||
|
text.IndexOf('.'); |
||||||
|
} |
||||||
|
}";
|
||||||
|
Test<MissingStringComparisonIssue>(program, 0); |
||||||
|
} |
||||||
|
|
||||||
|
[Test] |
||||||
|
public void ListIndexOf() |
||||||
|
{ |
||||||
|
string program = @"using System.Collections.Generic;
|
||||||
|
class Test { |
||||||
|
void M(List<string> list) { |
||||||
|
list.IndexOf("".com""); |
||||||
|
} |
||||||
|
}";
|
||||||
|
Test<MissingStringComparisonIssue>(program, 0); |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
Loading…
Reference in new issue