Browse Source

ResultOfAsyncCallShouldNotBeIgnoredIssue no longer underlines a large

portion of the text.
pull/45/merge
Mike Krüger 12 years ago
parent
commit
742f67753d
  1. 11
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ResultOfAsyncCallShouldNotBeIgnoredIssue.cs

11
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ResultOfAsyncCallShouldNotBeIgnoredIssue.cs

@ -43,6 +43,15 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -43,6 +43,15 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
}
AstNode GetNodeToUnderline(Expression target)
{
if (target is IdentifierExpression)
return target;
if (target is MemberReferenceExpression)
return ((MemberReferenceExpression)target).MemberNameToken;
return target;
}
public override void VisitExpressionStatement(ExpressionStatement expressionStatement)
{
base.VisitExpressionStatement(expressionStatement);
@ -51,7 +60,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -51,7 +60,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
return;
var rr = ctx.Resolve(invocation) as InvocationResolveResult;
if (rr != null && (rr.Type.IsKnownType(KnownTypeCode.Task) || rr.Type.IsKnownType(KnownTypeCode.TaskOfT))) {
AddIssue(invocation, ctx.TranslateString("Exceptions in async call will be silently ignored because the returned task is unused"));
AddIssue(GetNodeToUnderline (invocation.Target), ctx.TranslateString("Exceptions in async call will be silently ignored because the returned task is unused"));
}
}
}

Loading…
Cancel
Save