Fixed forum-7496: Crash when starting the debugger after deleting a line containing a breakpoint.

git-svn-id: svn://svn.sharpdevelop.net/sharpdevelop/trunk@3021 1ccf3a8d-04fe-1044-b7c0-cef0b8235c61

src/AddIns/Misc/Debugger/Debugger.AddIn/Project/Debugger.AddIn.csproj

@@ -1,4 +1,4 @@
-<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="3.5">
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
@@ -19,6 +19,7 @@
     <FileAlignment>4096</FileAlignment>
     <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
     <RunPostBuildEvent>Always</RunPostBuildEvent>
+    <TargetFrameworkVersion>v2.0</TargetFrameworkVersion>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>

src/AddIns/Misc/Debugger/Debugger.AddIn/Project/Src/Service/WindowsDebugger.cs

@@ -140,8 +140,8 @@ namespace ICSharpCode.SharpDevelop.Services
 			string version = debugger.GetProgramVersion(processStartInfo.FileName);
 			if (version.StartsWith("v1.0")) {
 				MessageService.ShowMessage("${res:XML.MainMenu.DebugMenu.Error.Net10NotSupported}");
-			//} else if (string.IsNullOrEmpty(version)) {
-			//	MessageService.ShowMessage("${res:XML.MainMenu.DebugMenu.Error.BadAssembly}");
+				//} else if (string.IsNullOrEmpty(version)) {
+				//	MessageService.ShowMessage("${res:XML.MainMenu.DebugMenu.Error.BadAssembly}");
 			} else {
 				if (DebugStarting != null)
 					DebugStarting(this, EventArgs.Empty);
@@ -364,25 +364,40 @@ namespace ICSharpCode.SharpDevelop.Services
 			SourcecodeSegment seg = new SourcecodeSegment(bookmark.FileName, bookmark.LineNumber + 1);
 			Breakpoint breakpoint = debugger.AddBreakpoint(seg, bookmark.IsEnabled);
 			MethodInvoker setBookmarkColor = delegate {
-				bookmark.WillBeHit  = breakpoint.HadBeenSet || debugger.Processes.Count == 0;
+				bookmark.WillBeHit = breakpoint.HadBeenSet || debugger.Processes.Count == 0;
+			};
+			
+			// event handlers on bookmark and breakpoint don't need deregistration
+			bookmark.IsEnabledChanged += delegate {
+				breakpoint.Enabled = bookmark.IsEnabled;
 			};
 			breakpoint.Changed += delegate { setBookmarkColor(); };
-			debugger.ProcessStarted += delegate {
+			
+			setBookmarkColor();
+			
+			EventHandler<ProcessEventArgs> bp_debugger_ProcessStarted = (sender, e) => {
 				setBookmarkColor();
 				// User can change line number by inserting or deleting lines
 				breakpoint.SourcecodeSegment.StartLine = bookmark.LineNumber + 1;
 			};
-			debugger.ProcessExited  += delegate { setBookmarkColor(); };
-			setBookmarkColor();
-			
-			BM.BookmarkManager.Removed += delegate (object sender, BM.BookmarkEventArgs e) {
+			EventHandler<ProcessEventArgs> bp_debugger_ProcessExited = (sender, e) => {
+				setBookmarkColor();
+			};
+			BM.BookmarkEventHandler bp_bookmarkManager_Removed = null;
+			bp_bookmarkManager_Removed = (sender, e) => {
 				if (bookmark == e.Bookmark) {
 					debugger.RemoveBreakpoint(breakpoint);
+					
+					// unregister the events
+					debugger.ProcessStarted -= bp_debugger_ProcessStarted;
+					debugger.ProcessExited -= bp_debugger_ProcessExited;
+					BM.BookmarkManager.Removed -= bp_bookmarkManager_Removed;
 				}
 			};
-			bookmark.IsEnabledChanged += delegate {
-				breakpoint.Enabled = bookmark.IsEnabled;
-			};
+			// register the events
+			debugger.ProcessStarted += bp_debugger_ProcessStarted;
+			debugger.ProcessExited += bp_debugger_ProcessExited;
+			BM.BookmarkManager.Removed += bp_bookmarkManager_Removed;
 		}
 		
 		void LogMessage(object sender, MessageEventArgs e)