Browse Source

Debugger visualizers - removed unused IVisualizerCommand.CanExecute.

pull/16/merge
mkonicek 14 years ago
parent
commit
5156aaa37e
  1. 2
      src/AddIns/Debugger/Debugger.AddIn/Visualizers/Commands/ExpressionVisualizerCommand.cs
  2. 12
      src/AddIns/Debugger/Debugger.AddIn/Visualizers/Commands/GridVisualizerCommand.cs
  3. 12
      src/AddIns/Debugger/Debugger.AddIn/Visualizers/Commands/ObjectGraphVisualizerCommand.cs
  4. 19
      src/AddIns/Debugger/Debugger.AddIn/Visualizers/Commands/TextVisualizerCommand.cs
  5. 19
      src/AddIns/Debugger/Debugger.AddIn/Visualizers/Commands/XmlVisualizerCommand.cs
  6. 1
      src/AddIns/Debugger/Debugger.AddIn/Visualizers/Graph/ObjectGraph/PropertiesFirstComparer.cs
  7. 5
      src/Main/Base/Project/Src/Services/Debugger/Tooltips/IVisualizerCommand.cs

2
src/AddIns/Debugger/Debugger.AddIn/Visualizers/Commands/ExpressionVisualizerCommand.cs

@ -23,8 +23,6 @@ namespace Debugger.AddIn.Visualizers
this.Expression = expression; this.Expression = expression;
} }
public abstract bool CanExecute { get; }
public abstract void Execute(); public abstract void Execute();
} }
} }

12
src/AddIns/Debugger/Debugger.AddIn/Visualizers/Commands/GridVisualizerCommand.cs

@ -41,10 +41,6 @@ namespace Debugger.AddIn.Visualizers
{ {
} }
public override bool CanExecute {
get { return true; }
}
public override string ToString() public override string ToString()
{ {
return "Collection visualizer"; return "Collection visualizer";
@ -52,10 +48,10 @@ namespace Debugger.AddIn.Visualizers
public override void Execute() public override void Execute()
{ {
if (this.Expression != null) { if (this.Expression == null)
var gridVisualizerWindow = GridVisualizerWindow.EnsureShown(); return;
gridVisualizerWindow.ShownExpression = this.Expression; var gridVisualizerWindow = GridVisualizerWindow.EnsureShown();
} gridVisualizerWindow.ShownExpression = this.Expression;
} }
} }
} }

12
src/AddIns/Debugger/Debugger.AddIn/Visualizers/Commands/ObjectGraphVisualizerCommand.cs

@ -36,10 +36,6 @@ namespace Debugger.AddIn.Visualizers
{ {
} }
public override bool CanExecute {
get { return true; }
}
public override string ToString() public override string ToString()
{ {
return "Object graph visualizer"; return "Object graph visualizer";
@ -47,10 +43,10 @@ namespace Debugger.AddIn.Visualizers
public override void Execute() public override void Execute()
{ {
if (this.Expression != null) { if (this.Expression == null)
var objectGraphWindow = ObjectGraphWindow.EnsureShown(); return;
objectGraphWindow.ShownExpression = this.Expression; var objectGraphWindow = ObjectGraphWindow.EnsureShown();
} objectGraphWindow.ShownExpression = this.Expression;
} }
} }
} }

19
src/AddIns/Debugger/Debugger.AddIn/Visualizers/Commands/TextVisualizerCommand.cs

@ -26,9 +26,6 @@ namespace Debugger.AddIn.Visualizers
} }
} }
/// <summary>
/// Description of TextVisualizerCommand.
/// </summary>
public class TextVisualizerCommand : ExpressionVisualizerCommand public class TextVisualizerCommand : ExpressionVisualizerCommand
{ {
public TextVisualizerCommand(Expression expression) public TextVisualizerCommand(Expression expression)
@ -36,10 +33,6 @@ namespace Debugger.AddIn.Visualizers
{ {
} }
public override bool CanExecute {
get { return true; }
}
public override string ToString() public override string ToString()
{ {
return "Text visualizer"; return "Text visualizer";
@ -47,13 +40,11 @@ namespace Debugger.AddIn.Visualizers
public override void Execute() public override void Execute()
{ {
if (this.Expression != null) if (this.Expression == null)
{ return;
var textVisualizerWindow = new TextVisualizerWindow( string expressionValue = this.Expression.Evaluate(WindowsDebugger.CurrentProcess).AsString();
this.Expression.PrettyPrint(), this.Expression.Evaluate(WindowsDebugger.CurrentProcess).InvokeToString()); var textVisualizerWindow = new TextVisualizerWindow(this.Expression.PrettyPrint(), expressionValue);
textVisualizerWindow.Mode = TextVisualizerMode.PlainText; textVisualizerWindow.ShowDialog();
textVisualizerWindow.ShowDialog();
}
} }
} }
} }

19
src/AddIns/Debugger/Debugger.AddIn/Visualizers/Commands/XmlVisualizerCommand.cs

@ -36,24 +36,19 @@ namespace Debugger.AddIn.Visualizers
{ {
} }
public override bool CanExecute {
get { return true; }
}
public override string ToString() public override string ToString()
{ {
return "Xml visualizer"; return "XML visualizer";
} }
public override void Execute() public override void Execute()
{ {
if (this.Expression != null) if (this.Expression == null)
{ return;
var textVisualizerWindow = new TextVisualizerWindow( var textVisualizerWindow = new TextVisualizerWindow(
this.Expression.PrettyPrint(), this.Expression.Evaluate(WindowsDebugger.CurrentProcess).InvokeToString()); this.Expression.PrettyPrint(), this.Expression.Evaluate(WindowsDebugger.CurrentProcess).AsString());
textVisualizerWindow.Mode = TextVisualizerMode.Xml; textVisualizerWindow.Mode = TextVisualizerMode.Xml;
textVisualizerWindow.ShowDialog(); textVisualizerWindow.ShowDialog();
}
} }
} }
} }

1
src/AddIns/Debugger/Debugger.AddIn/Visualizers/Graph/ObjectGraph/PropertiesFirstComparer.cs

@ -4,7 +4,6 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using System;
using System.Reflection; using System.Reflection;
namespace Debugger.AddIn.Visualizers.Graph namespace Debugger.AddIn.Visualizers.Graph

5
src/Main/Base/Project/Src/Services/Debugger/Tooltips/IVisualizerCommand.cs

@ -12,11 +12,6 @@ namespace ICSharpCode.SharpDevelop.Debugging
/// </summary> /// </summary>
public interface IVisualizerCommand public interface IVisualizerCommand
{ {
/// <summary>
/// Can this command execute?
/// </summary>
bool CanExecute { get; }
/// <summary> /// <summary>
/// Executes this visualizer command. /// Executes this visualizer command.
/// </summary> /// </summary>

Loading…
Cancel
Save