Context actions - Fix: "Check for (not) null" is only offered for expressions where it makes sense (method call, property access, variable access, "as" typecast).

src/AddIns/Misc/SharpRefactoring/Project/Src/ContextActions/CheckAssignmentCache.cs

@@ -72,8 +72,8 @@ namespace SharpRefactoring.ContextActions
 			var identifier = assignment.Left as IdentifierExpression;
 			if (identifier == null)
 				return null;
-			if (assignment.Right is ObjectCreateExpression)
+			if (!ExpressionCanBeNull(assignment.Right))
-				// // don't offer action for "a = new Foo()"
+				// don't offer action where it makes no sense
 				return null;
 			return identifier.Identifier;
 		}
@@ -85,11 +85,22 @@ namespace SharpRefactoring.ContextActions
 			if (declaration.Variables.Count != 1)
 				return null;
 			VariableDeclaration varDecl = declaration.Variables[0];
-			if (!varDecl.Initializer.IsNull &&
+			if (!ExpressionCanBeNull(varDecl.Initializer))
-			    // don't offer action for "var a = new Foo()"
+				// don't offer action where it makes no sense
-			    !(varDecl.Initializer is ObjectCreateExpression))
-				return varDecl.Name;
 				return null;
+			return varDecl.Name;
+		}
+		
+		bool ExpressionCanBeNull(Expression expr)
+		{
+			if (expr == null) return false;
+			if (expr.IsNull) return false;
+			if (expr is PrimitiveExpression) return false;
+			if (expr is IdentifierExpression) return true;
+			if (expr is MemberReferenceExpression) return true;
+			if (expr is InvocationExpression) return true;
+			if (expr is CastExpression && ((CastExpression)expr).CastType == CastType.TryCast) return true;
+			return false;
 		}
 		
 		CodeGenerator GetCodeGenerator(EditorContext context)