Browse Source

[CodeIssue] Renamed DoubleNegationExpressionIssue to NegativeRelationalExpressionIssue

newNRvisualizers
Mansheng Yang 14 years ago
parent
commit
0cf2d3940a
  1. 2
      ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj
  2. 10
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/NegativeRelationalExpressionIssue.cs
  3. 6
      ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/NegativeRelationalExpressionIssueTests.cs
  4. 2
      ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj

2
ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj

@ -267,7 +267,7 @@ @@ -267,7 +267,7 @@
<Compile Include="Refactoring\CodeIssues\BitwiseOperationOnNonFlagsEnumIssue.cs" />
<Compile Include="Refactoring\CodeIssues\CompareFloatWithEqualityOperatorIssue.cs" />
<Compile Include="Refactoring\CodeIssues\ConstantConditionIssue.cs" />
<Compile Include="Refactoring\CodeIssues\DoubleNegationExpressionIssue.cs" />
<Compile Include="Refactoring\CodeIssues\NegativeRelationalExpressionIssue.cs" />
<Compile Include="Refactoring\CodeIssues\ExplicitConversionInForEachIssue.cs" />
<Compile Include="Refactoring\CodeIssues\ForControlVariableNotModifiedIssue.cs" />
<Compile Include="Refactoring\CodeIssues\IdenticalConditionalBranchIssue.cs" />

10
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/DoubleNegationExpressionIssue.cs → ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/NegativeRelationalExpressionIssue.cs

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
//
// DoubleNegationExpressionIssue.cs
// NegativeRelationalExpressionIssue.cs
//
// Author:
// Mansheng Yang <lightyang0@gmail.com>
@ -28,12 +28,12 @@ using System.Collections.Generic; @@ -28,12 +28,12 @@ using System.Collections.Generic;
namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
[IssueDescription ("Simplify double negation expression",
Description = "Simplify double negation expression",
[IssueDescription ("Simplify negative relational expression",
Description = "Simplify negative relational expression",
Category = IssueCategories.Improvements,
Severity = Severity.Suggestion,
IssueMarker = IssueMarker.Underline)]
public class DoubleNegationExpressionIssue : ICodeIssueProvider
public class NegativeRelationalExpressionIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
{
@ -66,7 +66,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -66,7 +66,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
if (negatedOp == BinaryOperatorType.Any)
return;
AddIssue (unaryOperatorExpression, ctx.TranslateString ("Simplify negative equality expression"),
AddIssue (unaryOperatorExpression, ctx.TranslateString ("Simplify negative relational expression"),
script => script.Replace (unaryOperatorExpression,
new BinaryOperatorExpression (binaryOperatorExpr.Left.Clone (), negatedOp,
binaryOperatorExpr.Right.Clone ())));

6
ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/DoubleNegationExpressionIssueTests.cs → ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/NegativeRelationalExpressionIssueTests.cs

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
//
// NegativeEqualityExpressionIssueTests.cs
// NegativeRelationalExpressionIssueTests.cs
//
// Author:
// Mansheng Yang <lightyang0@gmail.com>
@ -30,7 +30,7 @@ using NUnit.Framework; @@ -30,7 +30,7 @@ using NUnit.Framework;
namespace ICSharpCode.NRefactory.CSharp.CodeIssues
{
[TestFixture]
public class DoubleNegationExpressionIssueTests : InspectionActionTestBase
public class NegativeRelationalExpressionIssueTests : InspectionActionTestBase
{
public void Test (string op, string negatedOp)
@ -51,7 +51,7 @@ class TestClass @@ -51,7 +51,7 @@ class TestClass
var x = 1 " + negatedOp + @" 2;
}
}";
Test<DoubleNegationExpressionIssue> (input, 1, output);
Test<NegativeRelationalExpressionIssue> (input, 1, output);
}
[Test]

2
ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj

@ -113,7 +113,7 @@ @@ -113,7 +113,7 @@
<Compile Include="CSharp\CodeIssues\LocalVariableNotUsedIssueTests.cs" />
<Compile Include="CSharp\CodeIssues\LocalVariableOnlyAssignedIssueTests.cs" />
<Compile Include="CSharp\CodeIssues\MultipleEnumerationIssueTests.cs" />
<Compile Include="CSharp\CodeIssues\DoubleNegationExpressionIssueTests.cs" />
<Compile Include="CSharp\CodeIssues\NegativeRelationalExpressionIssueTests.cs" />
<Compile Include="CSharp\CodeIssues\ParameterHidesMemberIssueTests.cs" />
<Compile Include="CSharp\CodeIssues\ParameterNotUsedIssueTests.cs" />
<Compile Include="CSharp\CodeIssues\ParameterOnlyAssignedIssueTests.cs" />

Loading…
Cancel
Save