From 0cf2d3940a1362a70ae9504ff6caf176b6d1227e Mon Sep 17 00:00:00 2001 From: Mansheng Yang Date: Mon, 23 Jul 2012 20:14:21 +0800 Subject: [PATCH] [CodeIssue] Renamed DoubleNegationExpressionIssue to NegativeRelationalExpressionIssue --- .../ICSharpCode.NRefactory.CSharp.csproj | 2 +- ...onIssue.cs => NegativeRelationalExpressionIssue.cs} | 10 +++++----- ...ts.cs => NegativeRelationalExpressionIssueTests.cs} | 6 +++--- .../ICSharpCode.NRefactory.Tests.csproj | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) rename ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/{DoubleNegationExpressionIssue.cs => NegativeRelationalExpressionIssue.cs} (90%) rename ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/{DoubleNegationExpressionIssueTests.cs => NegativeRelationalExpressionIssueTests.cs} (91%) diff --git a/ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj b/ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj index 8ca1c542e0..ea8f82b816 100644 --- a/ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj +++ b/ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj @@ -267,7 +267,7 @@ - + diff --git a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/DoubleNegationExpressionIssue.cs b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/NegativeRelationalExpressionIssue.cs similarity index 90% rename from ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/DoubleNegationExpressionIssue.cs rename to ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/NegativeRelationalExpressionIssue.cs index ae97afe65f..54c09d9404 100644 --- a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/DoubleNegationExpressionIssue.cs +++ b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/NegativeRelationalExpressionIssue.cs @@ -1,5 +1,5 @@ // -// DoubleNegationExpressionIssue.cs +// NegativeRelationalExpressionIssue.cs // // Author: // Mansheng Yang @@ -28,12 +28,12 @@ using System.Collections.Generic; namespace ICSharpCode.NRefactory.CSharp.Refactoring { - [IssueDescription ("Simplify double negation expression", - Description = "Simplify double negation expression", + [IssueDescription ("Simplify negative relational expression", + Description = "Simplify negative relational expression", Category = IssueCategories.Improvements, Severity = Severity.Suggestion, IssueMarker = IssueMarker.Underline)] - public class DoubleNegationExpressionIssue : ICodeIssueProvider + public class NegativeRelationalExpressionIssue : ICodeIssueProvider { public IEnumerable GetIssues (BaseRefactoringContext context) { @@ -66,7 +66,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring if (negatedOp == BinaryOperatorType.Any) return; - AddIssue (unaryOperatorExpression, ctx.TranslateString ("Simplify negative equality expression"), + AddIssue (unaryOperatorExpression, ctx.TranslateString ("Simplify negative relational expression"), script => script.Replace (unaryOperatorExpression, new BinaryOperatorExpression (binaryOperatorExpr.Left.Clone (), negatedOp, binaryOperatorExpr.Right.Clone ()))); diff --git a/ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/DoubleNegationExpressionIssueTests.cs b/ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/NegativeRelationalExpressionIssueTests.cs similarity index 91% rename from ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/DoubleNegationExpressionIssueTests.cs rename to ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/NegativeRelationalExpressionIssueTests.cs index 305f4ede16..a21c08865b 100644 --- a/ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/DoubleNegationExpressionIssueTests.cs +++ b/ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/NegativeRelationalExpressionIssueTests.cs @@ -1,5 +1,5 @@ // -// NegativeEqualityExpressionIssueTests.cs +// NegativeRelationalExpressionIssueTests.cs // // Author: // Mansheng Yang @@ -30,7 +30,7 @@ using NUnit.Framework; namespace ICSharpCode.NRefactory.CSharp.CodeIssues { [TestFixture] - public class DoubleNegationExpressionIssueTests : InspectionActionTestBase + public class NegativeRelationalExpressionIssueTests : InspectionActionTestBase { public void Test (string op, string negatedOp) @@ -51,7 +51,7 @@ class TestClass var x = 1 " + negatedOp + @" 2; } }"; - Test (input, 1, output); + Test (input, 1, output); } [Test] diff --git a/ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj b/ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj index 708d780f5d..227618983d 100644 --- a/ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj +++ b/ICSharpCode.NRefactory.Tests/ICSharpCode.NRefactory.Tests.csproj @@ -113,7 +113,7 @@ - +