mirror of https://github.com/icsharpcode/ILSpy.git
Browse Source
Selecting a list in the dialog only set SessionSettings.ActiveAssemblyList directly, which merely persists the choice for the next launch — it never reloaded the tree, so the active list appeared unchanged. Route selection through AssemblyTreeModel.ActiveListName instead, whose setter reloads the list (OnActiveListNameChanged -> ShowAssemblyList) and persists the choice. Also make double-clicking an entry a shortcut for the Select button (both go through the same activation path). Assisted-by: Claude:claude-opus-4-8:Claude Codepull/3755/head
2 changed files with 97 additions and 2 deletions
@ -0,0 +1,65 @@
@@ -0,0 +1,65 @@
|
||||
// Copyright (c) 2026 AlphaSierraPapa for the SharpDevelop Team
|
||||
//
|
||||
// Permission is hereby granted, free of charge, to any person obtaining a copy of this
|
||||
// software and associated documentation files (the "Software"), to deal in the Software
|
||||
// without restriction, including without limitation the rights to use, copy, modify, merge,
|
||||
// publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons
|
||||
// to whom the Software is furnished to do so, subject to the following conditions:
|
||||
//
|
||||
// The above copyright notice and this permission notice shall be included in all copies or
|
||||
// substantial portions of the Software.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
|
||||
// INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR
|
||||
// PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE
|
||||
// FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
||||
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
||||
// DEALINGS IN THE SOFTWARE.
|
||||
|
||||
using System.Linq; |
||||
using System.Threading.Tasks; |
||||
|
||||
using Avalonia.Headless.NUnit; |
||||
|
||||
using AwesomeAssertions; |
||||
|
||||
using ILSpy; |
||||
using ILSpy.AppEnv; |
||||
using ILSpy.Views; |
||||
|
||||
using NUnit.Framework; |
||||
|
||||
namespace ICSharpCode.ILSpy.Tests; |
||||
|
||||
/// <summary>
|
||||
/// Selecting a list in Manage Assembly Lists (the Select button and the double-click shortcut both
|
||||
/// call the same activation path) must switch the LIVE active list, not merely persist it for the
|
||||
/// next launch — i.e. it must drive AssemblyTreeModel.ActiveListName, which reloads the tree.
|
||||
/// </summary>
|
||||
[TestFixture] |
||||
public class ManageAssemblyListsSelectTests |
||||
{ |
||||
[AvaloniaTest] |
||||
public async Task Selecting_A_List_Switches_The_Live_Active_List() |
||||
{ |
||||
var (_, vm) = await TestHarness.BootAsync(); |
||||
var settingsService = AppComposition.Current.GetExport<SettingsService>(); |
||||
var manager = settingsService.AssemblyListManager; |
||||
|
||||
var current = vm.AssemblyTreeModel.ActiveListName; |
||||
|
||||
// Ensure there is a second, empty list to switch to (the headless fixture seeds one).
|
||||
var other = "Switch Target " + System.Guid.NewGuid().ToString("N"); |
||||
manager.AddListIfNotExists(manager.CreateList(other)); |
||||
other.Should().NotBe(current); |
||||
|
||||
var dialog = new ManageAssemblyListsDialog(settingsService); |
||||
dialog.ListsControl.SelectedItem = other; |
||||
dialog.ActivateSelectedList(); |
||||
|
||||
vm.AssemblyTreeModel.ActiveListName.Should().Be(other, |
||||
"selecting a list must switch the live active list (via AssemblyTreeModel.ActiveListName), not just the persisted setting"); |
||||
settingsService.SessionSettings.ActiveAssemblyList.Should().Be(other, |
||||
"and the choice is persisted as a side effect of the model switch"); |
||||
} |
||||
} |
||||
Loading…
Reference in new issue