mirror of https://github.com/icsharpcode/ILSpy.git
Browse Source
* Support batch PDB generation. * Use `FileMode.Create` for output PDB files to ensure existing files are fully overwritten/truncated. * Localize the string `Generating portable PDB...`. * Refine `GeneratePdbForAssemblies` implementation. * Replace direct calls to `explorer.exe` with the Shell API to prevent spawning an `explorer.exe` process that doesn't exit automatically on every call. * Batch calls to `ShellHelper.OpenFolderAndSelectItems` instead of looping `OpenFolderAndSelectItem`. * Localize the string `Open Explorer`. * Fix `OpenCmdHere` malfunction when ILSpy is running from a different drive than the OS. * Refine `GeneratePdbForAssemblies` implementation. * Replace WinForms `FolderBrowserDialog` with WPF `OpenFolderDialog`. * Add license header * Exclude duplicate entries entered by the user within `OpenFolderAndSelectItems`. * Explicitly declare that `ShellHelper.cs` is a module that allows Pinvoke. * Use `FileMode.Create` for output PDB files to ensure existing files are fully overwritten/truncated. * Show original filenames when generating PDBs to improve UX during batch processing.pull/3620/head
sonyps5201314
1 month ago
committed by
GitHub
13 changed files with 458 additions and 30 deletions
@ -0,0 +1,174 @@ |
|||||||
|
// Copyright (c) 2025 sonyps5201314
|
||||||
|
//
|
||||||
|
// Permission is hereby granted, free of charge, to any person obtaining a copy of this
|
||||||
|
// software and associated documentation files (the "Software"), to deal in the Software
|
||||||
|
// without restriction, including without limitation the rights to use, copy, modify, merge,
|
||||||
|
// publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons
|
||||||
|
// to whom the Software is furnished to do so, subject to the following conditions:
|
||||||
|
//
|
||||||
|
// The above copyright notice and this permission notice shall be included in all copies or
|
||||||
|
// substantial portions of the Software.
|
||||||
|
//
|
||||||
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
|
||||||
|
// INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR
|
||||||
|
// PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE
|
||||||
|
// FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
||||||
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
||||||
|
// DEALINGS IN THE SOFTWARE.
|
||||||
|
|
||||||
|
using System; |
||||||
|
using System.Collections.Generic; |
||||||
|
using System.ComponentModel; |
||||||
|
using System.Diagnostics; |
||||||
|
using System.IO; |
||||||
|
using System.Linq; |
||||||
|
using System.Runtime.InteropServices; |
||||||
|
|
||||||
|
#pragma warning disable CA1060 // Move pinvokes to native methods class
|
||||||
|
|
||||||
|
namespace ICSharpCode.ILSpy.Util |
||||||
|
{ |
||||||
|
static class ShellHelper |
||||||
|
{ |
||||||
|
[DllImport("shell32.dll", CharSet = CharSet.Unicode)] |
||||||
|
static extern int SHParseDisplayName([MarshalAs(UnmanagedType.LPWStr)] string pszName, IntPtr pbc, out IntPtr ppidl, uint sfgaoIn, out uint psfgaoOut); |
||||||
|
|
||||||
|
[DllImport("shell32.dll")] |
||||||
|
static extern int SHOpenFolderAndSelectItems(IntPtr pidlFolder, uint cidl, [MarshalAs(UnmanagedType.LPArray)] IntPtr[] apidl, uint dwFlags); |
||||||
|
|
||||||
|
[DllImport("shell32.dll")] |
||||||
|
static extern IntPtr ILFindLastID(IntPtr pidl); |
||||||
|
|
||||||
|
[DllImport("ole32.dll")] |
||||||
|
static extern void CoTaskMemFree(IntPtr pv); |
||||||
|
|
||||||
|
public static void OpenFolder(string folderPath) |
||||||
|
{ |
||||||
|
nint folderPidl = IntPtr.Zero; |
||||||
|
try |
||||||
|
{ |
||||||
|
if (string.IsNullOrEmpty(folderPath)) |
||||||
|
return; |
||||||
|
if (!Directory.Exists(folderPath)) |
||||||
|
return; |
||||||
|
|
||||||
|
int hr = SHParseDisplayName(folderPath, IntPtr.Zero, out folderPidl, 0, out var attrs); |
||||||
|
Marshal.ThrowExceptionForHR(hr); |
||||||
|
|
||||||
|
hr = SHOpenFolderAndSelectItems(folderPidl, 0, null, 0); |
||||||
|
Marshal.ThrowExceptionForHR(hr); |
||||||
|
} |
||||||
|
catch (Exception ex) when (ex is COMException or Win32Exception) |
||||||
|
{ |
||||||
|
// fall back to Process.Start
|
||||||
|
OpenFolderFallback(folderPath); |
||||||
|
} |
||||||
|
finally |
||||||
|
{ |
||||||
|
if (folderPidl != IntPtr.Zero) |
||||||
|
CoTaskMemFree(folderPidl); |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
static void OpenFolderFallback(string path) |
||||||
|
{ |
||||||
|
try |
||||||
|
{ |
||||||
|
Process.Start(new ProcessStartInfo { FileName = path, UseShellExecute = true }); |
||||||
|
} |
||||||
|
catch (Exception) |
||||||
|
{ |
||||||
|
// Process.Start can throw several errors (not all of them documented),
|
||||||
|
// just ignore all of them.
|
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
public static void OpenFolderAndSelectItem(string path) |
||||||
|
{ |
||||||
|
// Reuse the multi-item implementation for single item selection to avoid duplication.
|
||||||
|
if (string.IsNullOrEmpty(path)) |
||||||
|
return; |
||||||
|
if (Directory.Exists(path)) |
||||||
|
{ |
||||||
|
OpenFolder(path); |
||||||
|
return; |
||||||
|
} |
||||||
|
|
||||||
|
if (!File.Exists(path)) |
||||||
|
return; |
||||||
|
|
||||||
|
OpenFolderAndSelectItems(path); |
||||||
|
} |
||||||
|
|
||||||
|
public static void OpenFolderAndSelectItems(params IEnumerable<string> paths) |
||||||
|
{ |
||||||
|
if (paths == null) |
||||||
|
return; |
||||||
|
// Group by containing folder
|
||||||
|
var files = paths.Distinct(StringComparer.OrdinalIgnoreCase).Where(p => !string.IsNullOrEmpty(p) && File.Exists(p)).ToList(); |
||||||
|
if (files.Count == 0) |
||||||
|
return; |
||||||
|
|
||||||
|
var itemPidlAllocs = new List<IntPtr>(); |
||||||
|
var relativePidls = new List<IntPtr>(); |
||||||
|
|
||||||
|
foreach (var group in files.GroupBy(Path.GetDirectoryName)) |
||||||
|
{ |
||||||
|
string folder = group.Key; |
||||||
|
if (string.IsNullOrEmpty(folder) || !Directory.Exists(folder)) |
||||||
|
continue; |
||||||
|
|
||||||
|
IntPtr folderPidl = IntPtr.Zero; |
||||||
|
|
||||||
|
try |
||||||
|
{ |
||||||
|
int hrFolder = SHParseDisplayName(folder, IntPtr.Zero, out folderPidl, 0, out uint attrs); |
||||||
|
Marshal.ThrowExceptionForHR(hrFolder); |
||||||
|
|
||||||
|
foreach (var file in group) |
||||||
|
{ |
||||||
|
int hrItem = SHParseDisplayName(file, IntPtr.Zero, out var itemPidl, 0, out attrs); |
||||||
|
if (hrItem == 0 && itemPidl != IntPtr.Zero) |
||||||
|
{ |
||||||
|
IntPtr relative = ILFindLastID(itemPidl); |
||||||
|
if (relative != IntPtr.Zero) |
||||||
|
{ |
||||||
|
relativePidls.Add(relative); |
||||||
|
itemPidlAllocs.Add(itemPidl); |
||||||
|
continue; |
||||||
|
} |
||||||
|
} |
||||||
|
if (itemPidl != IntPtr.Zero) |
||||||
|
CoTaskMemFree(itemPidl); |
||||||
|
} |
||||||
|
|
||||||
|
if (relativePidls.Count > 0) |
||||||
|
{ |
||||||
|
int hr = SHOpenFolderAndSelectItems(folderPidl, (uint)relativePidls.Count, relativePidls.ToArray(), 0); |
||||||
|
Marshal.ThrowExceptionForHR(hr); |
||||||
|
} |
||||||
|
else |
||||||
|
{ |
||||||
|
// nothing to select - open folder
|
||||||
|
OpenFolder(folder); |
||||||
|
} |
||||||
|
} |
||||||
|
catch (Exception ex) when (ex is COMException or Win32Exception) |
||||||
|
{ |
||||||
|
// fall back to Process.Start
|
||||||
|
OpenFolderFallback(folder); |
||||||
|
} |
||||||
|
finally |
||||||
|
{ |
||||||
|
foreach (var p in itemPidlAllocs) |
||||||
|
CoTaskMemFree(p); |
||||||
|
if (folderPidl != IntPtr.Zero) |
||||||
|
CoTaskMemFree(folderPidl); |
||||||
|
|
||||||
|
itemPidlAllocs.Clear(); |
||||||
|
relativePidls.Clear(); |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
Loading…
Reference in new issue