Browse Source

remove some todos

pull/31/head
Jason Dove 6 years ago
parent
commit
560f1796be
  1. 27
      ErsatzTV.Core/Metadata/FallbackMetadataProvider.cs
  2. 3
      ErsatzTV.Core/Metadata/TelevisionFolderScanner.cs
  3. 1
      ErsatzTV.Infrastructure/Data/Repositories/MovieRepository.cs

27
ErsatzTV.Core/Metadata/FallbackMetadataProvider.cs

@ -21,19 +21,7 @@ namespace ErsatzTV.Core.Metadata @@ -21,19 +21,7 @@ namespace ErsatzTV.Core.Metadata
string fileName = Path.GetFileName(episode.Path);
var metadata = new EpisodeMetadata
{ MetadataKind = MetadataKind.Fallback, Title = fileName ?? episode.Path };
if (fileName != null)
{
// TODO: ensure local?
// if (!(mediaItem.LibraryPath is LocalMediaSource))
// {
// return metadata;
// }
return GetEpisodeMetadata(fileName, metadata);
}
return metadata;
return fileName != null ? GetEpisodeMetadata(fileName, metadata) : metadata;
}
public static MovieMetadata GetFallbackMetadata(Movie movie)
@ -41,18 +29,7 @@ namespace ErsatzTV.Core.Metadata @@ -41,18 +29,7 @@ namespace ErsatzTV.Core.Metadata
string fileName = Path.GetFileName(movie.Path);
var metadata = new MovieMetadata { MetadataKind = MetadataKind.Fallback, Title = fileName ?? movie.Path };
if (fileName != null)
{
// TODO: ensure local?
// if (!(mediaItem.Source is LocalMediaSource))
// {
// return metadata;
// }
return GetMovieMetadata(fileName, metadata);
}
return metadata;
return fileName != null ? GetMovieMetadata(fileName, metadata) : metadata;
}
private static EpisodeMetadata GetEpisodeMetadata(string fileName, EpisodeMetadata metadata)

3
ErsatzTV.Core/Metadata/TelevisionFolderScanner.cs

@ -53,7 +53,6 @@ namespace ErsatzTV.Core.Metadata @@ -53,7 +53,6 @@ namespace ErsatzTV.Core.Metadata
foreach (string showFolder in allShowFolders)
{
// TODO: check all sources for latest metadata?
Either<BaseError, Show> maybeShow =
await FindOrCreateShow(libraryPath.Id, showFolder)
.BindT(show => UpdateMetadataForShow(show, showFolder))
@ -64,8 +63,6 @@ namespace ErsatzTV.Core.Metadata @@ -64,8 +63,6 @@ namespace ErsatzTV.Core.Metadata
_ => Task.FromResult(Unit.Default));
}
// TODO: remove this?
// await _televisionRepository.DeleteMissingSources(libraryPath.Id, allShowFolders);
await _televisionRepository.DeleteEmptyShows();
return Unit.Default;

1
ErsatzTV.Infrastructure/Data/Repositories/MovieRepository.cs

@ -112,7 +112,6 @@ namespace ErsatzTV.Infrastructure.Data.Repositories @@ -112,7 +112,6 @@ namespace ErsatzTV.Infrastructure.Data.Repositories
{
try
{
// TODO: this should be library path id
item.LibraryPathId = library.Paths.Head().Id;
await _dbContext.PlexMovieMediaItems.AddAsync(item);

Loading…
Cancel
Save