From 560f1796be36965fb33d3f24dbd9673c0f8fb8af Mon Sep 17 00:00:00 2001
From: Jason Dove <jason@jasondove.me>
Date: Sat, 27 Feb 2021 15:26:17 -0600
Subject: [PATCH] remove some todos

---
 .../Metadata/FallbackMetadataProvider.cs      | 27 ++-----------------
 .../Metadata/TelevisionFolderScanner.cs       |  3 ---
 .../Data/Repositories/MovieRepository.cs      |  1 -
 3 files changed, 2 insertions(+), 29 deletions(-)

diff --git a/ErsatzTV.Core/Metadata/FallbackMetadataProvider.cs b/ErsatzTV.Core/Metadata/FallbackMetadataProvider.cs
index ca1946deb..7e76905a2 100644
--- a/ErsatzTV.Core/Metadata/FallbackMetadataProvider.cs
+++ b/ErsatzTV.Core/Metadata/FallbackMetadataProvider.cs
@@ -21,19 +21,7 @@ namespace ErsatzTV.Core.Metadata
             string fileName = Path.GetFileName(episode.Path);
             var metadata = new EpisodeMetadata
                 { MetadataKind = MetadataKind.Fallback, Title = fileName ?? episode.Path };
-
-            if (fileName != null)
-            {
-                // TODO: ensure local?
-                // if (!(mediaItem.LibraryPath is LocalMediaSource))
-                // {
-                //     return metadata;
-                // }
-
-                return GetEpisodeMetadata(fileName, metadata);
-            }
-
-            return metadata;
+            return fileName != null ? GetEpisodeMetadata(fileName, metadata) : metadata;
         }
 
         public static MovieMetadata GetFallbackMetadata(Movie movie)
@@ -41,18 +29,7 @@ namespace ErsatzTV.Core.Metadata
             string fileName = Path.GetFileName(movie.Path);
             var metadata = new MovieMetadata { MetadataKind = MetadataKind.Fallback, Title = fileName ?? movie.Path };
 
-            if (fileName != null)
-            {
-                // TODO: ensure local?
-                // if (!(mediaItem.Source is LocalMediaSource))
-                // {
-                //     return metadata;
-                // }
-
-                return GetMovieMetadata(fileName, metadata);
-            }
-
-            return metadata;
+            return fileName != null ? GetMovieMetadata(fileName, metadata) : metadata;
         }
 
         private static EpisodeMetadata GetEpisodeMetadata(string fileName, EpisodeMetadata metadata)
diff --git a/ErsatzTV.Core/Metadata/TelevisionFolderScanner.cs b/ErsatzTV.Core/Metadata/TelevisionFolderScanner.cs
index c80c6312e..5296c6c32 100644
--- a/ErsatzTV.Core/Metadata/TelevisionFolderScanner.cs
+++ b/ErsatzTV.Core/Metadata/TelevisionFolderScanner.cs
@@ -53,7 +53,6 @@ namespace ErsatzTV.Core.Metadata
 
             foreach (string showFolder in allShowFolders)
             {
-                // TODO: check all sources for latest metadata?
                 Either<BaseError, Show> maybeShow =
                     await FindOrCreateShow(libraryPath.Id, showFolder)
                         .BindT(show => UpdateMetadataForShow(show, showFolder))
@@ -64,8 +63,6 @@ namespace ErsatzTV.Core.Metadata
                     _ => Task.FromResult(Unit.Default));
             }
 
-            // TODO: remove this?
-            // await _televisionRepository.DeleteMissingSources(libraryPath.Id, allShowFolders);
             await _televisionRepository.DeleteEmptyShows();
 
             return Unit.Default;
diff --git a/ErsatzTV.Infrastructure/Data/Repositories/MovieRepository.cs b/ErsatzTV.Infrastructure/Data/Repositories/MovieRepository.cs
index 9f3016ea2..93db72a16 100644
--- a/ErsatzTV.Infrastructure/Data/Repositories/MovieRepository.cs
+++ b/ErsatzTV.Infrastructure/Data/Repositories/MovieRepository.cs
@@ -112,7 +112,6 @@ namespace ErsatzTV.Infrastructure.Data.Repositories
         {
             try
             {
-                // TODO: this should be library path id
                 item.LibraryPathId = library.Paths.Head().Id;
 
                 await _dbContext.PlexMovieMediaItems.AddAsync(item);