don't pass vaapi_device when display is not drm

ErsatzTV.Core/FFmpeg/FFmpegLibraryProcessService.cs

@@ -382,6 +382,7 @@ public class FFmpegLibraryProcessService : IFFmpegProcessService
             saveReports,
             hwAccel,
             hwAccel,
+            VaapiDisplayName(hwAccel, vaapiDisplay),
             VaapiDriverName(hwAccel, vaapiDriver),
             VaapiDeviceName(hwAccel, vaapiDevice),
             playbackSettings.StreamSeek,
@@ -536,6 +537,7 @@ public class FFmpegLibraryProcessService : IFFmpegProcessService
             false,
             HardwareAccelerationMode.None, // no hw accel decode since errors loop
             hwAccel,
+            VaapiDisplayName(hwAccel, vaapiDisplay),
             VaapiDriverName(hwAccel, vaapiDriver),
             VaapiDeviceName(hwAccel, vaapiDevice),
             playbackSettings.StreamSeek,
@@ -730,6 +732,7 @@ public class FFmpegLibraryProcessService : IFFmpegProcessService
             saveReports,
             HardwareAccelerationMode.None,
             hwAccel,
+            vaapiDisplay,
             vaapiDriver,
             vaapiDevice,
             playbackSettings.StreamSeek,

ErsatzTV.FFmpeg.Tests/PipelineBuilderBaseTests.cs

@@ -79,6 +79,7 @@ public class PipelineBuilderBaseTests
             HardwareAccelerationMode.None,
             Option<string>.None,
             Option<string>.None,
+            Option<string>.None,
             TimeSpan.FromSeconds(1),
             Option<TimeSpan>.None,
             false,
@@ -173,6 +174,7 @@ public class PipelineBuilderBaseTests
             HardwareAccelerationMode.None,
             Option<string>.None,
             Option<string>.None,
+            Option<string>.None,
             TimeSpan.FromSeconds(1),
             Option<TimeSpan>.None,
             false,
@@ -323,6 +325,7 @@ public class PipelineBuilderBaseTests
             HardwareAccelerationMode.None,
             Option<string>.None,
             Option<string>.None,
+            Option<string>.None,
             Option<TimeSpan>.None,
             Option<TimeSpan>.None,
             false,
@@ -411,6 +414,7 @@ public class PipelineBuilderBaseTests
             HardwareAccelerationMode.None,
             Option<string>.None,
             Option<string>.None,
+            Option<string>.None,
             Option<TimeSpan>.None,
             Option<TimeSpan>.None,
             false,

ErsatzTV.FFmpeg/FFmpegState.cs

@@ -6,6 +6,7 @@ public record FFmpegState(
     bool SaveReport,
     HardwareAccelerationMode DecoderHardwareAccelerationMode,
     HardwareAccelerationMode EncoderHardwareAccelerationMode,
+    Option<string> VaapiDisplay,
     Option<string> VaapiDriver,
     Option<string> VaapiDevice,
     Option<TimeSpan> Start,
@@ -33,6 +34,7 @@ public record FFmpegState(
             HardwareAccelerationMode.None,
             Option<string>.None,
             Option<string>.None,
+            Option<string>.None,
             Option<TimeSpan>.None,
             Option<TimeSpan>.None,
             true, // do not map metadata

ErsatzTV.FFmpeg/Pipeline/VaapiPipelineBuilder.cs

@@ -75,14 +75,17 @@ public class VaapiPipelineBuilder : SoftwarePipelineBuilder
             encodeCapability = FFmpegCapability.Software;
         }
 
-        foreach (string vaapiDevice in ffmpegState.VaapiDevice)
-        {
-            pipelineSteps.Add(new VaapiHardwareAccelerationOption(vaapiDevice, decodeCapability));
-
         foreach (string driverName in ffmpegState.VaapiDriver)
         {
             pipelineSteps.Add(new LibvaDriverNameVariable(driverName));
         }
+
+        if (ffmpegState.VaapiDisplay.IfNone("drm") == "drm")
+        {
+            foreach (string vaapiDevice in ffmpegState.VaapiDevice)
+            {
+                pipelineSteps.Add(new VaapiHardwareAccelerationOption(vaapiDevice, decodeCapability));
+            }
         }
 
         // use software decoding with an extensive pipeline