Made the REST API consistent.

doc/REST-API.txt

@@ -6,6 +6,11 @@
 The server provides a REST api end point to provide functionality outside the
 the channeling API or without a established web socket connection.
 
+The REST API does always return valid JSON data. This includes the non 200
+status responses. If non JSON is received this is an error not generated by the
+API or there was a problem while JSON encoding.
+
+
 Available end points with request methods and content-type:
 
 
@@ -34,12 +39,7 @@ Available end points with request methods and content-type:
           "success": true,
           "token": "validated-auth-token"
         }
-      Response 200:
-        {
-          "success": false,
-          "token": ""
-        }
-      Response 413:
+      Response 403, 413:
         {
           "success": false,
           "code": "error-code",

src/app/spreed-speakfreely-server/sessions.go

@@ -87,7 +87,7 @@ func (sessions *Sessions) Patch(request *http.Request) (int, interface{}, http.H
 	}
 
 	if error {
-		return 403, NewApiError("session_patch_failed", "Failed to patch session"), nil
+		return 403, NewApiError("session_patch_failed", "Failed to patch session"), http.Header{"Content-Type": {"application/json"}}
 	}
 
 	return 200, &SessionNonce{Nonce: nonce, Success: true}, http.Header{"Content-Type": {"application/json"}}

src/app/spreed-speakfreely-server/tokens.go

@@ -41,19 +41,17 @@ func (tokens Tokens) Post(request *http.Request) (int, interface{}, http.Header)
 	auth := request.Form.Get("a")
 
 	if len(auth) > 100 {
-		return 413, NewApiError("auth_too_large", "Auth too large"), nil
+		return 413, NewApiError("auth_too_large", "Auth too large"), http.Header{"Content-Type": {"application/json"}}
 	}
 
 	valid := tokens.provider(strings.ToLower(auth))
-	response := &Token{Token: valid}
 
 	if valid != "" {
 		log.Printf("Good incoming token request: %s\n", auth)
-		response.Success = true
+		return 200, &Token{Token: valid, Success: true}, http.Header{"Content-Type": {"application/json"}}
 	} else {
 		log.Printf("Wrong incoming token request: %s\n", auth)
+		return 403, NewApiError("invalid_token", "Invalid token"), http.Header{"Content-Type": {"application/json"}}
 	}
 
-	return 200, response, http.Header{"Content-Type": {"application/json"}}
-
 }

static/js/services/mediastream.js

@@ -98,7 +98,7 @@ define([
                     return
                 }
 
-                api.requestAuthentication(lastUserid, lastNonce);                
+                api.requestAuthentication(lastUserid, lastNonce);
 
             };
 
@@ -252,10 +252,16 @@ define([
                                     });
                                 }
                             }).
-                            error(function() {
-                                alertify.dialog.error(translation._("Error"), translation._("Failed to verify access code. Check your Internet connection and try again."), function() {
-                                    prompt();
-                                });
+                            error(function(data, status) {
+                                if ((status == 403 || status == 413) && data.success == false) {
+                                    alertify.dialog.error(translation._("Access denied"), translation._("Please provide a valid access code."), function() {
+                                        prompt();
+                                    });
+                                } else {
+                                    alertify.dialog.error(translation._("Error"), translation._("Failed to verify access code. Check your Internet connection and try again."), function() {
+                                        prompt();
+                                    });
+                                }
                             });
                         };
                         if (storedCode) {