Browse Source

Unify feauture names to clientSideTurn.

pull/242/head
Evan Theurer 10 years ago
parent
commit
3b2e96d518
  1. 2
      server.conf.in
  2. 4
      src/app/spreed-webrtc-server/config.go
  3. 2
      static/js/directives/settings.js
  4. 8
      static/js/services/turnsettings.js
  5. 2
      static/partials/settings.html

2
server.conf.in

@ -58,7 +58,7 @@ listen = 127.0.0.1:8080
; A supported TURN server is https://code.google.com/p/rfc5766-turn-server/. ; A supported TURN server is https://code.google.com/p/rfc5766-turn-server/.
;turnSecret = the-default-turn-shared-secret-do-not-keep ;turnSecret = the-default-turn-shared-secret-do-not-keep
; Enable adding TURN servers inside of the client side webui under settings ; Enable adding TURN servers inside of the client side webui under settings
;turnClientSideSetable = false ;clientSideTurn = false
; Enable renegotiation support. Set to true to tell clients that they can ; Enable renegotiation support. Set to true to tell clients that they can
; renegotiate peer connections when required. Firefox support is not complete, ; renegotiate peer connections when required. Firefox support is not complete,
; so do not enable if you want compatibility with Firefox clients. ; so do not enable if you want compatibility with Firefox clients.

4
src/app/spreed-webrtc-server/config.go

@ -39,7 +39,7 @@ type Config struct {
Renegotiation bool // Renegotiation flag Renegotiation bool // Renegotiation flag
StunURIs []string // STUN server URIs StunURIs []string // STUN server URIs
TurnURIs []string // TURN server URIs TurnURIs []string // TURN server URIs
TurnClientSideSetable bool // Enable TURN server customization under settings in web ui ClientSideTurn bool // Enable TURN server customization under settings in web ui
Tokens bool // True when we got a tokens file Tokens bool // True when we got a tokens file
Version string // Server version number Version string // Server version number
UsersEnabled bool // Flag if users are enabled UsersEnabled bool // Flag if users are enabled
@ -117,7 +117,7 @@ func NewConfig(container phoenix.Container, tokens bool) *Config {
Renegotiation: container.GetBoolDefault("app", "renegotiation", false), Renegotiation: container.GetBoolDefault("app", "renegotiation", false),
StunURIs: stunURIs, StunURIs: stunURIs,
TurnURIs: turnURIs, TurnURIs: turnURIs,
TurnClientSideSetable: container.GetBoolDefault("app", "turnClientSideSetable", false), ClientSideTurn: container.GetBoolDefault("app", "clientSideTurn", false),
Tokens: tokens, Tokens: tokens,
Version: version, Version: version,
UsersEnabled: container.GetBoolDefault("users", "enabled", false), UsersEnabled: container.GetBoolDefault("users", "enabled", false),

2
static/js/directives/settings.js

@ -70,7 +70,7 @@ define(['jquery', 'underscore', 'text!partials/settings.html'], function($, _, t
$scope.withUsers = mediaStream.config.UsersEnabled; $scope.withUsers = mediaStream.config.UsersEnabled;
$scope.withUsersRegistration = mediaStream.config.UsersAllowRegistration; $scope.withUsersRegistration = mediaStream.config.UsersAllowRegistration;
$scope.withUsersMode = mediaStream.config.UsersMode; $scope.withUsersMode = mediaStream.config.UsersMode;
$scope.withTurnCustomizable = turnSettings.showClientSideTurnOptions(); $scope.clientSideTurn = turnSettings.showClientSideTurnOptions();
_.each(availableLanguages, function(name, code) { _.each(availableLanguages, function(name, code) {
$scope.availableLanguages.push({ $scope.availableLanguages.push({

8
static/js/services/turnsettings.js

@ -27,7 +27,7 @@ define([], function() {
// See contraints.js for actual TURN configuration in use for a connection // See contraints.js for actual TURN configuration in use for a connection
return ['mediaStream', 'appData', 'constraints', function(mediaStream, appData, constraints) { return ['mediaStream', 'appData', 'constraints', function(mediaStream, appData, constraints) {
var preferClientSideTurnSettings = mediaStream.config.TurnClientSideSetable; var clientSideTurn = mediaStream.config.ClientSideTurn;
var turnConfigServer = null; var turnConfigServer = null;
// @param Object config Turn configuration object // @param Object config Turn configuration object
@ -35,7 +35,7 @@ define([], function() {
// @param String config.username // @param String config.username
// @param String config.password // @param String config.password
var updateTurnSettings = function(config) { var updateTurnSettings = function(config) {
if (!preferClientSideTurnSettings) { if (!clientSideTurn) {
return; return;
} }
if (config.urls.length) { if (config.urls.length) {
@ -46,7 +46,7 @@ define([], function() {
} }
}; };
if (preferClientSideTurnSettings) { if (clientSideTurn) {
// Overwrite server Turn settings with user settings when loading app // Overwrite server Turn settings with user settings when loading app
appData.e.one("userSettingsLoaded", function(event, loadedUser, user) { appData.e.one("userSettingsLoaded", function(event, loadedUser, user) {
if (user) { if (user) {
@ -63,7 +63,7 @@ define([], function() {
return { return {
showClientSideTurnOptions: function() { showClientSideTurnOptions: function() {
return preferClientSideTurnSettings; return clientSideTurn;
}, },
update: updateTurnSettings update: updateTurnSettings
}; };

2
static/partials/settings.html

@ -283,7 +283,7 @@
</div> </div>
</div> </div>
<div ng-show="withTurnCustomizable"> <div ng-show="clientSideTurn">
<legend>{{_('Turn')}}</legend> <legend>{{_('Turn')}}</legend>
<div> <div>
<div class="form-group"> <div class="form-group">

Loading…
Cancel
Save