pimhwang/qTox - qTox - git.quantfans.net

8039 Commits

3 Branches

42 Tags

55 MiB

Tree: ca4d4b8a98

Commit Graph

Author	SHA1	Message	Date
Brandon Mosher	1438f8f766	refactor: Provide a Virtual Method Anchor for Classes in Headers Define at least one virtual method in polymorphic class cpp files to improve link efficiency. Do so by defining a defaulted destructor or another overridden virtual method in the class cpp file. Also add explicitly defaulted copy/move constructors and assignment operators to follow the rule of five and to avoid compiler suppression of these functions due to the addition of a user-provided destructor. Where neccessary, create new cpp files and add them to CMakeLists and Testing.cmake. Set the -Wweak-vtables by default when compiling with clang to issue warnings for new classes that do not comply with this pattern. See http://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers. Fixes #6036.	4 years ago
sudden6	0335f20362	fix: Qt ressource system usage Make use of the `AUTORCC` feature of cmake to simplify adding resource files to qTox. Fixes #6144	6 years ago
sudden6	a90f0762d9	refactor(cmake): change folder structure The new folder structure will be like this: /<module>/CMakeLists.txt /<module>/src/file.cpp /<module>/include/<module>/file.h /<module>/<subdir>/<...>	6 years ago

Author

SHA1

Message

Date

Brandon Mosher

1438f8f766

refactor: Provide a Virtual Method Anchor for Classes in Headers

Define at least one virtual method in polymorphic class cpp files to
improve link efficiency. Do so by defining a defaulted destructor or
another overridden virtual method in the class cpp file.
Also add explicitly defaulted copy/move constructors and assignment
operators to follow the rule of five and to avoid compiler suppression
of these functions due to the addition of a user-provided destructor.
Where neccessary, create new cpp files and add them to CMakeLists and
Testing.cmake. Set the -Wweak-vtables by default when compiling with
clang to issue warnings for new classes that do not comply with this
pattern.

See http://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers.

Fixes #6036.

4 years ago

sudden6

0335f20362

fix: Qt ressource system usage

Make use of the `AUTORCC` feature of cmake to simplify adding resource
files to qTox.

Fixes #6144

6 years ago

sudden6

a90f0762d9

refactor(cmake): change folder structure

The new folder structure will be like this:

/<module>/CMakeLists.txt
/<module>/src/file.cpp
/<module>/include/<module>/file.h
/<module>/<subdir>/<...>

6 years ago

3 Commits (ca4d4b8a9846f58d291b005474dde402835e7b78)