pimhwang/qTox - qTox - git.quantfans.net

Commit Graph

Author	SHA1	Message	Date
initramfs	8bfbae1b47	refactor(video): use a new ToxAVFrame structure instead of vpx_image Instead of misusing an existing structure from another library, defines a new simpler structure that reflects the capabilities of the ToxAV transport mechanism.	9 years ago
initramfs	277ddc3d2f	fix(video): fix CoreAV and VideoSurface to conform to new VideoFrame	9 years ago
Nils Fenner	31c154293b	refactor(coreav): fix static analysis warnings and code style	9 years ago
Diadlo	2696a9265a	docs(core): Change comment style	9 years ago
Diadlo	f8eda7eb57	style(core): Style fixes	9 years ago
Diadlo	1ddc1371a0	fix(videoframe): Added correct image copy	9 years ago
Nils Fenner	792103f8b0	refactor(filter_audio): completely remove filter_audio dependency The filter_audio API is not working for qTox/Tox and thus disabled by default via compiler switch. In current qTox UI, it is not configurable, even when this switch is enabled. According to issue #3194 the library is no longer maintained as well. I don't see any reason to keep it in qTox.	9 years ago
sudden6	5339ad978b	fix(groupaudio): don't play audio while call is inactive This also avoids logspam, because toxcore keeps recieving audio data even if the call is inactive.	9 years ago
sudden6	afcd146a5b	fix(groupaudio): avoid deadlock when ending groupcall The offending statement caused a deadlock, because the audioLock was locked twice by the audio thread.	9 years ago
Nils Fenner	356543ca3b	feat(audio): add (repair) support for group audio calls	9 years ago
tux3	ce2f8fd1d5	Cleanup and improve audio input We now subscribe to an event and wait for frames when capturing audio input, the big avdantage is that we only have to fetch the frames from the hardware once, and we don't need to cache anything. The frames are simply dispatched to the client's callbacks immediately. Also removes some outdated ifdefs that did not apply anymore.	10 years ago
Nils Fenner	0615c7c3c6	reimplement audio in/out subscription concept	10 years ago
Nils Fenner	08c43d0b83	cleanup OpenAL compatibility code in audio class	10 years ago
Nils Fenner	a1b87194b8	fix #2504 We need to filter samples * channels; also cleaned up data types	10 years ago
Nils Fenner	bb7d2a72b7	privatized audio interface	10 years ago
tux3	a6bbd31b12	Retry sending audio frames on sync/lock error	10 years ago
tux3	333d10e6d5	Log type of audio send error	10 years ago
tux3	7f5f807bde	Fix filter audio Fixes #2504 Fixes #2517 Fixes #1565	10 years ago
tux3	37075dbfb5	Improve video quality Double the allowed bitrate, this is especially noticeable on desktop streaming. Desktop streaming is still completely broken, with what looks like iframes silently getting dropped on a regular basis. Retry 5 times to send a frame when there's an internal toxav lock sync error, this allows us to drop way less frames.	10 years ago
tux3	db52ef6e6a	Disable buggy automatic bitrate adjustements For some users on poor connections, toxav would suggest lower and lower bitratres until reaching zero and disabling audio/video entirely, toxav would then not raise the bitrate back and the only way to re-enable audio/video would have been to change A/V sources or restart the call We now log toxav's recommendation, but ignore it	10 years ago
tux3	523e419adf	Fix theoritical A/V deadlock Could only be hit by pausing at a key point in a debugger until the call timed-out. Having one thread going up the call stack and acquiring locks (toxcore callbacks), while another thread goes down taking locks in the other order (CoreAV calling toxav functions) creates some pretty freezy situations. The deadlock was caused by the GUI thread calling the CoreAV thread, acquiring the CoreAV callback, then right before calling a toxav function, not schedule the thread until the call times out. At this point the toxcore thread fires its state callback to tell us the call is over, locking internal toxcore/toxav mutexes, it reaches our callback function which tries to switch to the CoreAV thread to clean up the call data structures, but has to wait since the CoreAV thread holds its own lock. At this point if we resume the CoreAV thread, it'll be busy calling into a toxav function, which tries to acquire internal toxav locks, those locks are held by the toxcore callback so we deadlock. Our solution is that when getting a toxcore callback, we immediately switch to a temporary thread, allowing toxcore to release the locks it held, and that temporary thread tries to switch to do work on call data structures. Meanwhile if the CoreAV thread needs internal toxcore locks, it can get them.	10 years ago
tux3	7dc608818c	Automatic AV bitrate management Makes progress on #2134	10 years ago
tux3	d41a578735	Fix crash on audio -> video call promotion We just ignore it and not show the received video for now. Fixes #2505	10 years ago
tux3	f107858252	Properly exit CoreAV thread	10 years ago
tux3	c902543ae4	Fix call race leading to deadlock and memory leak A call cancel/accepted race was locking up both UI and AV threads, while the stream thread was shoveling more and more video frames on the AV thread's event queue	10 years ago
tux3	a776579732	Don't assert if a call dies while we answer it This error condition only happens when a peer cancels its outgoing call in the middle of us answering it. We can simply ignore the error and things should nicely fall back into place. Since this race should be pretty rare in normal usage, it's nice to leave a log message, as it might mean we're being fuzzed. We can prograssively replace more of those asserts by fallbacks and log messages now that everything has been shown to work fine, and the race conditions are harmless. I feel like writing a novel today. Good thing nobody looks at these!	10 years ago
tux3	37e2d2e75f	CoreAV: Fix BlockingQueued connections deadlock Having a deadlock problem? The solution is more locks!	10 years ago
tux3	c0d8703368	Properly signal when we stop sending video And properly handle toxav happily delivering things out of order, like firing a video frame callback right after a callback setting the bitrate to 0, when the peer sent these commands in the right order	10 years ago
tux3	1dc7e4cca5	Add 45s call ringing timeout	10 years ago
tux3	ae243b2089	Delete CoreAV's timer from the CoreAV thread	10 years ago
tux3	4d9aeeec39	Fix bitrate callback to match toxav update	10 years ago
tux3	6dc91b156a	Use actual mutexes for CameraSource That homemade spinlock thing was insane, VTune says we were spending 1.5s spinning for no reason when openning a device for example	10 years ago
tux3	477554ffba	Clean up callback hell between AV UI and CoreAV	10 years ago
tux3	a505e06f83	Multithread CoreAV This is a little less insane, gives an overall 2x speedup on debug builds video calls	10 years ago
tux3	41e0212f77	Cleanup UI/CoreAV interface	10 years ago
tux3	73a4f40744	Fix call start/call invite race condition Would result in an assert failure	10 years ago
tux3	f45256baf1	Implement group calls	10 years ago
tux3	6cbd507ca8	Clean up dead code in CoreAV	10 years ago
tux3	69b8a90277	Implement video calls	10 years ago
tux3	e0aa8dd4a2	Implement audio calls	10 years ago
tux3	2b888ddc05	Better data structure for tox calls	10 years ago
tux3	512dc8de2d	Implement basic call logic We can now make New AV calls, but without any audio/video. Just opening a link.	10 years ago
tux3	dbbc702c60	Strip out old AV code	10 years ago
Nils Fenner	b7cf4df13f	Get rid of static methods and bugs	10 years ago
TheSpiritXIII	dc2c6532a5	Audio: Fix unclosed audio when hanging up	10 years ago
agilob	7c6ac40d21	add debugging messages to camerasource, code reformatting to make it more readable and ogranized better	10 years ago
tux3	2ab55568f2	Make the video code a singleton, fix multithreading bugs There can now only be one CameraSource running. Video frames are decoded in their own thread, and then converted by users in the user's threads. The CameraSource API is entirely thread-safe and controls the video decoding thread. The video device only stays open as long as there are users subscribed to the CameraSource. We use a dangerous combination of spinlocks and memory fences to keep things synchronized.	10 years ago
tux3	7513725a3d	Fix wrong assert	10 years ago
tux3	89e9b18cf3	Better checks before cleanupCall	10 years ago
tux3	d76fb459cf	Fix #1817	10 years ago

1 2 3

117 Commits (a8546fe8cb5b432df89ce66c623b224d90884bd4)