pimhwang/qTox - qTox - git.quantfans.net

7959 Commits

3 Branches

42 Tags

54 MiB

Tree: 83fcc76e43

Commit Graph

Author	SHA1	Message	Date
Brandon Mosher	1438f8f766	refactor: Provide a Virtual Method Anchor for Classes in Headers Define at least one virtual method in polymorphic class cpp files to improve link efficiency. Do so by defining a defaulted destructor or another overridden virtual method in the class cpp file. Also add explicitly defaulted copy/move constructors and assignment operators to follow the rule of five and to avoid compiler suppression of these functions due to the addition of a user-provided destructor. Where neccessary, create new cpp files and add them to CMakeLists and Testing.cmake. Set the -Wweak-vtables by default when compiling with clang to issue warnings for new classes that do not comply with this pattern. See http://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers. Fixes #6036.	4 years ago
Mick Sayson	6e163ca5ed	feat(notification): Notifications now always replace the previous one This is a feature/fix to improve notification behavior when we receive over 3 messages. SnoreNotify prevents over 3 notifications from being displayed before a user clears the notification. This is presumably to avoid infinite notification spam. Unfortunately this results in the notifications just coming in _after_ the user clears them. This means if there are 100s of messages built up the user has to clear their notifications N messages / 3 times. This feature/fix folds all notifications into a single notification representing the current qTox notification state. See notificationgenerator_test.cpp for what the new messages look like.	5 years ago
Mick Sayson	a9f6543e43	feat(notification): Notification string generator for multiple messages	5 years ago

Author

SHA1

Message

Date

Brandon Mosher

1438f8f766

refactor: Provide a Virtual Method Anchor for Classes in Headers

Define at least one virtual method in polymorphic class cpp files to
improve link efficiency. Do so by defining a defaulted destructor or
another overridden virtual method in the class cpp file.
Also add explicitly defaulted copy/move constructors and assignment
operators to follow the rule of five and to avoid compiler suppression
of these functions due to the addition of a user-provided destructor.
Where neccessary, create new cpp files and add them to CMakeLists and
Testing.cmake. Set the -Wweak-vtables by default when compiling with
clang to issue warnings for new classes that do not comply with this
pattern.

See http://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers.

Fixes #6036.

4 years ago

Mick Sayson

6e163ca5ed

feat(notification): Notifications now always replace the previous one

This is a feature/fix to improve notification behavior when we receive
over 3 messages.

SnoreNotify prevents over 3 notifications from being displayed before a
user clears the notification. This is presumably to avoid infinite
notification spam.

Unfortunately this results in the notifications just coming in _after_
the user clears them. This means if there are 100s of messages built up
the user has to clear their notifications N messages / 3 times.

This feature/fix folds all notifications into a single notification
representing the current qTox notification state. See
notificationgenerator_test.cpp for what the new messages look like.

5 years ago

Mick Sayson

a9f6543e43

feat(notification): Notification string generator for multiple messages

5 years ago

3 Commits (83fcc76e437482480cb6d4dd6161662fb4634dff)