pimhwang/qTox - qTox - git.quantfans.net

Commit Graph

Author	SHA1	Message	Date
sudden6	723a8e5dc7	fix(coreav): avoid deadlock between CoreAV, main and Audio thread This actually fixes two problems: 1) CoreAV and Audio thread both locked the callsLock and audioLock in different orders, resulting in a deadlock of both threads. This fixed by using a ReadWriteLock in the CoreAV thread. 2) Multiple functions were emitting signals while holding a lock. This is unsafe, because the connected slot may acquire any other lock. This is fixed by releasing the locks before emitting signals. (cherry picked from commit `4b9e4a571d`)	5 years ago
sudden6	a4ac6d67c7	fix(coreav): cleanup assertions It doesn't really make sense to assert that the callbacks are coming from any other thread than CoreAV, when we actually want to ensure the callback is coming from Core thread. Remove over agressive assert from sendGroupCallAudio(...), this function should be callable from any thread. (cherry picked from commit `9499925fb2`)	5 years ago
sudden6	89400c91f7	refactor: properly lock against Core thread We we're calling toxav_* functions without synchronizing to any of the Tox threads. Additionally remove the call timeout, it creates timers from different threads, which causes errors. (cherry picked from commit `98cfe9838f`)	5 years ago
sudden6	8e54805e7d	feat(coreav): add assertions to check for threading errors	5 years ago
sudden6	cf402bd11c	refactor(coreav): simplify start sequence (cherry picked from commit `c332cc0cca`)	5 years ago
sudden6	f72b3397a5	refactor(coreav): move threading of CoreAV to single mutex Use a standard mutex instead of trying to build proper locking ourselfes. (cherry picked from commit `2bc0057bbd`)	5 years ago
Mick Sayson	87eed97ab3	fix(calls): Fix SIGSEGV on quit while in call On application close we used to access invalid memory associated with the audio subsystem. This was because on destruction of static variables we tried to access state associated with an already destructed item. These variables seem to have no good reason to be static. They should be tied to a single CoreAV instance and are only accessed through an existing CoreAV instance.	6 years ago
sudden6	909deb0feb	fix: remove reconnect button The button didn't work that well and caused all kinds of issues inside the code, so I replaced it by a notice that changes to the Advanced settings only apply after a restart of qTox. In the process I also removed all code that was exclusively used for that feature. We may add it back later when qTox's internal architecture makes it less cumbersome.	6 years ago
jenli669	04a9bc46f4	docs(copyright): update and add copyright info zealously updates and adds qTox copyright information. Fixes #5713	6 years ago
sudden6	22362d2940	refactor(audio): Remove Audio singleton This commit finally removes the Audio singleton and allocates the audio backend in main.cpp.	6 years ago
sudden6	a8546fe8cb	refactor: use smart pointer instead of raw pointer	6 years ago
sudden6	5b908184fc	refactor(audio): move audio output to new IAudioSink interface	6 years ago
sudden6	b7b9b58d42	refactor: make ToxCall non-moveable We don't need move functionality and the code for it is complex and error prone.	6 years ago
Anthony Bilinski	13afbf7ec6	fix(groups): avoid having to lookup peer pk Caused race where peer plays audio, then is removed from group, then we process audio played signal and lookup their peerId in core where it doesn't exist. Now Group will effectively contain the peer until the peer list changed slot is processed. Partial fix for #5511	7 years ago
Anthony Bilinski	8422c09f6a	fix(groups): don't invalidate all audio sources when peer list changes Fix #5508	7 years ago
Anthony Bilinski	ec07fd7291	feat(groups): show who is in a group call before joining Fix #5507	7 years ago
sudden6	7fa2dfead5	refactor(coreav): move CoreAV to the factory pattern too - clean up error handling during construction of the Core - prevent leaks by using unique_ptr	7 years ago
sudden6	2ab081b4a9	refactor: remove support for c-toxcore < 0.2.0 This code is only a maintainance burden and not used anymore.	7 years ago
sudden6	26206a35eb	fix(core): ensure QTimers are moved with the objects they belong to We use the Qt parent/child model instead of unique_ptr to achieve this.	7 years ago
sudden6	a139a9933b	refactor(core): cleanup thread and timer destruction in Core and CoreAV	7 years ago
Anthony Bilinski	cc6df2c294	chore(core): use new toxcore enum typenames Fix #5287	7 years ago
sudden6	24e7c4efd4	refactor(core): format code	7 years ago
sudden6	7f7b29e55e	refactor(core): use smart pointers instead of raw pointers	7 years ago
sudden6	40d30153ae	fix(audio): fix error introduced in `67f2605971`	7 years ago
sudden6	67f2605971	refactor(toxcall): move peer handling to ToxGroupCall	7 years ago
tox-user	2fae2a30f7	feat(chat): add UI option to mute group peers Implements #4596, #4626, #1007 Adds a context menu to every peer label in group chat with an option to mute chosen peers, which adds them to the blacklist. Mutes audio of blacklisted group peers.	7 years ago
Anthony Bilinski	5dc4e6de81	chore(legal): update copyright date to 2018 for all source files	7 years ago
Anthony Bilinski	9216549d6e	refactor(call): Refactor toxcall and disconnect lambda on destruction Fixes #3840 Move audio and video state into ToxCall which both ToxFriendCall and ToxGroupCall inherit from	7 years ago
sudden6	d3d81bbdf3	feat: update to the new c-toxcore 0.2.0 conferences api The old functions are disabled at compile time and should be removed later.	8 years ago
Diadlo	d2deec7c55	fix(core): Use new callback API for bitrate set	8 years ago
Diadlo	2c8f03dada	fix(core): Use new API for bitrate set Fix #4935	8 years ago
anthony.bilinski	1394dd1b7f	fix(call): fix bugs introduced from ToxCall refactor -inverted call active booleans -audio subscription leak on move assignment -NullVideoBitrate check -return peers list by reference so that adding audio source in GroupCallCallback is persisted -fix output muting for friend calls	8 years ago
sudden6	967dab8700	style: run format-code.sh on the files	8 years ago
sudden6	90bf0a7e2c	refactor(toxcall): make toxcall a class with getters and setters	8 years ago
sudden6	b07ea763cd	refactor(toxcall): remove callId from ToxCall members	8 years ago
sudden6	ed4b063994	refactor(coreav): replace IndexedList with std::map	8 years ago
anthony.bilinski	1613044c68	fix(video): Set toxav video bitrate to 0 if answering audio-only call Before we would set the video bitrate to 0 if sending an audio-only call, but we would still set the video bitrate to default when receiving an audio only call. In bad network conditions, this caused tox to ask us to decrease video bitrate in audio-only calls.	8 years ago
tox-user	7ed2d97aad	feat(settings): make audio quality setting persistent	8 years ago
tox-user	61eddc1f6b	feat(settings): Add audio quality setting Fixes #4693	8 years ago
Diadlo	99ebb73562	refactor: Remove deprecated methods to get id	8 years ago
Diadlo	017653470d	refactor: Move friend and group in model directory	8 years ago
tWido	ac75f7b594	feat(video): Error message on call fail notifies user if call ended unexpectedly	8 years ago
Zetok Zalbavar	80f5de31b3	style: reformat current C++ codebase using clang-format	9 years ago
agrecascino	62ac480171	fix(audio): alternate audio fix implementation from #4139	9 years ago
Diadlo	320099faf8	fix(chatform): Add ability to cancel call Fix #4016.	9 years ago
Diadlo	29bb319025	refactor(friend): Small refactoring Method renamed to be same with `Group` i.e. `getGroupId`, changed Friend eventFlag type on bool	9 years ago
Zetok Zalbavar	d4ac13dbf4	revert: "refactor: Added to include path and exclude it from all includes" Revert needed, since otherwise there is no way to do automatic sorting of includes. Also reverted change to the docs, as leaving it would make incorrect docs. In case of conflicts, includes were sorted according to the coding standards from #3839. This reverts commit `b4a9f04f92`. This reverts commit `5921122960`.	9 years ago
Diadlo	4f9cb0b008	refactor: rename args to conform to C++11 § 17.6.4.3.2 Fixed typo and small style improvements.	9 years ago
Diadlo	3c304c50bc	refactor(core): Added error handling	9 years ago
Diadlo	e9a2fc6b57	refactor(core, widget): Update toxcore group API (new: conference)	9 years ago

1 2 3

127 Commits (723a8e5dc75d5aaf0c0fb40ce041771c7bdc1abd)