Browse Source

fix(settings): block signals during initialization

Prevents unexpected writes to settings during object creation, which can potentially mess up various settings values.
pull/3507/head
Nils Fenner 9 years ago
parent
commit
de438f1c23
No known key found for this signature in database
GPG Key ID: 9591A163FF9BE04C
  1. 5
      src/widget/form/settingswidget.cpp

5
src/widget/form/settingswidget.cpp

@ -34,6 +34,9 @@ @@ -34,6 +34,9 @@
SettingsWidget::SettingsWidget(QWidget* parent)
: QWidget(parent, Qt::Window)
{
// block all signals during initialization, including child widgets
blockSignals(true);
body = new QWidget();
QVBoxLayout* bodyLayout = new QVBoxLayout();
body->setLayout(bodyLayout);
@ -70,6 +73,8 @@ SettingsWidget::SettingsWidget(QWidget* parent) @@ -70,6 +73,8 @@ SettingsWidget::SettingsWidget(QWidget* parent)
connect(settingsWidgets, &QTabWidget::currentChanged, this, &SettingsWidget::onTabChanged);
Translator::registerHandler(std::bind(&SettingsWidget::retranslateUi, this), this);
blockSignals(false);
}
SettingsWidget::~SettingsWidget()

Loading…
Cancel
Save