From 9da1e3bbdf01c8aba2dc5029f70a99fd0d85fd87 Mon Sep 17 00:00:00 2001 From: Anthony Bilinski Date: Wed, 27 May 2020 02:34:37 -0700 Subject: [PATCH] fix(preview): Don't log a warning on missing exif orientation metadata libexif returns 0 for the orientation when orientation metadata isn't present. Treat this the same as 1, i.e. no orientation change. --- src/model/exiftransform.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/model/exiftransform.cpp b/src/model/exiftransform.cpp index 8ea3acf60..4ed526ed4 100644 --- a/src/model/exiftransform.cpp +++ b/src/model/exiftransform.cpp @@ -45,6 +45,11 @@ namespace ExifTransform exif_data_free(exifData); switch (orientation){ + case 0: + // Exif spec defines 1-8 only, but when the orientation field isn't explcitly defined, we read 0 from + // libexif. It seems like exif_data_get_entry should return null in that case rather than saying the entry + // is present but with a value of zero. + return Orientation::TopLeft; case 1: return Orientation::TopLeft; case 2: