refactor: removed meaningless 'isValid' method

src/persistence/settings.cpp

@@ -232,8 +232,9 @@ void Settings::loadGlobal()
 
         const QString DEFAULT_SMILEYS = ":/smileys/emojione/emoticons.xml";
         smileyPack = s.value("smileyPack", DEFAULT_SMILEYS).toString();
-        if (!SmileyPack::isValid(smileyPack))
+        if (!QFile::exists(smileyPack)) {
             smileyPack = DEFAULT_SMILEYS;
+        }
 
         emojiFontPointSize = s.value("emojiFontPointSize", 24).toInt();
         firstColumnHandlePos = s.value("firstColumnHandlePos", 50).toInt();

src/persistence/smileypack.cpp

@@ -159,11 +159,6 @@ QVector<QPair<QString, QString>> SmileyPack::listSmileyPacks(const QStringList&
     return smileyPacks;
 }
 
-bool SmileyPack::isValid(const QString& filename)
-{
-    return QFile(filename).exists();
-}
-
 /**
  * @brief Load smile pack
  * @note The caller must lock loadingMutex and should run it in a thread

src/persistence/smileypack.h

@@ -32,7 +32,6 @@ public:
     static SmileyPack& getInstance();
     static QVector<QPair<QString, QString>> listSmileyPacks(const QStringList& paths);
     static QVector<QPair<QString, QString>> listSmileyPacks();
-    static bool isValid(const QString& filename);
 
     QString smileyfied(const QString& msg);
     QList<QStringList> getEmoticons() const;