Merge pull request #4651

anthony.bilinski (1):
      fix(init): register AV connects and call after AV is ready

src/core/core.cpp

@@ -248,6 +248,10 @@ void Core::makeAv()
         qCritical() << "Toxav core failed to start";
         emit failedToStart();
     }
+    for (const auto& callback : toCallWhenAvReady) {
+        callback(av);
+    }
+    toCallWhenAvReady.clear();
 }
 
 /**
@@ -1371,6 +1375,10 @@ bool Core::isReady() const
     return av && av->getToxAv() && tox && ready;
 }
 
+void Core::callWhenAvReady(std::function<void(CoreAV* av)>&& toCall)
+{
+    toCallWhenAvReady.emplace_back(std::move(toCall));
+}
 
 /**
  * @brief Sets the NoSpam value to prevent friend request spam

src/core/core.h

@@ -73,6 +73,7 @@ public:
     QPair<QByteArray, QByteArray> getKeypair() const;
 
     bool isReady() const;
+    void callWhenAvReady(std::function<void(CoreAV* av)>&& toCall);
 
     void sendFile(uint32_t friendId, QString filename, QString filePath, long long filesize);
 
@@ -226,6 +227,7 @@ private:
     QMutex messageSendMutex;
     bool ready;
     const ICoreSettings* const s;
+    std::vector<std::function<void(CoreAV* av)>> toCallWhenAvReady;
 
     static QThread* coreThread;
 

src/widget/widget.cpp

@@ -242,9 +242,8 @@ void Widget::init()
     connect(profile, &Profile::selfAvatarChanged, profileForm, &ProfileForm::onSelfAvatarLoaded);
 
     const Settings& s = Settings::getInstance();
-    CoreAV* av = core->getAv();
-    connect(av, &CoreAV::avEnd, this, &Widget::onCallEnd);
 
+    core->callWhenAvReady([this](CoreAV* av){connect(av, &CoreAV::avEnd, this, &Widget::onCallEnd);});
     connect(core, &Core::fileDownloadFinished, filesForm, &FilesForm::onFileDownloadComplete);
     connect(core, &Core::fileUploadFinished, filesForm, &FilesForm::onFileUploadComplete);
     connect(ui->addButton, &QPushButton::clicked, this, &Widget::onAddClicked);