refactor(settings): declare createPersonal const

src/persistence/profile.cpp

@@ -53,7 +53,7 @@
 
 QStringList Profile::profiles;
 
-void Profile::initCore(const QByteArray& toxsave, ICoreSettings& s, bool isNewProfile)
+void Profile::initCore(const QByteArray& toxsave, const ICoreSettings& s, bool isNewProfile)
 {
     if (toxsave.isEmpty() && !isNewProfile) {
         qCritical() << "Existing toxsave is empty";

src/persistence/profile.h

@@ -103,7 +103,7 @@ private:
     static QStringList getFilesByExt(QString extension);
     QString avatarPath(const ToxPk& owner, bool forceUnencrypted = false);
     bool saveToxSave(QByteArray data);
-    void initCore(const QByteArray& toxsave, ICoreSettings& s, bool isNewProfile);
+    void initCore(const QByteArray& toxsave, const ICoreSettings& s, bool isNewProfile);
 
 private:
     std::unique_ptr<Core> core = nullptr;

src/persistence/settings.cpp

@@ -2368,7 +2368,7 @@ bool Settings::getEnableGroupChatsColor() const
  *
  * @note If basename is "profile", settings will be saved in profile.ini
  */
-void Settings::createPersonal(QString basename)
+void Settings::createPersonal(const QString& basename) const
 {
     QMutexLocker locker{&bigLock};
 

src/persistence/settings.h

@@ -149,7 +149,7 @@ public:
     QString getAppCacheDirPath() const;
 
     void createSettingsDir();
-    void createPersonal(QString basename);
+    void createPersonal(const QString& basename) const;
 
     void savePersonal();