From e2b0faa0dd5d996d6ce694272234099e2d15aa90 Mon Sep 17 00:00:00 2001
From: Jannik <jannik@outlook.com>
Date: Wed, 3 Nov 2021 22:09:47 +0100
Subject: [PATCH] Add a recommendation in the admin to add a second, lower
 quality if only one is set (#356)

* :sparkles: add recommendation box if only one, high-quality video variant is set (#1491)

Related to: https://github.com/owncast/owncast/issues/1491

* Prettified Code!

* Tweak the alert text slightly

Co-authored-by: jeyemwey <jeyemwey@users.noreply.github.com>
Co-authored-by: Gabe Kangas <gabek@real-ity.com>
---
 .../config/video-variants-table.tsx           | 22 ++++++++++++++++++-
 web/utils/config-constants.tsx                |  7 ++++++
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/web/components/config/video-variants-table.tsx b/web/components/config/video-variants-table.tsx
index 524cb22d8..a43835959 100644
--- a/web/components/config/video-variants-table.tsx
+++ b/web/components/config/video-variants-table.tsx
@@ -1,7 +1,7 @@
 // Updating a variant will post ALL the variants in an array as an update to the API.
 
 import React, { useContext, useState } from 'react';
-import { Typography, Table, Modal, Button } from 'antd';
+import { Typography, Table, Modal, Button, Alert } from 'antd';
 import { ColumnsType } from 'antd/lib/table';
 import { DeleteOutlined } from '@ant-design/icons';
 import { ServerStatusContext } from '../../utils/server-status-context';
@@ -15,6 +15,7 @@ import {
   RESET_TIMEOUT,
   postConfigUpdateToAPI,
   ENCODER_PRESET_TOOLTIPS,
+  ENCODER_RECOMMENDATION_THRESHOLD,
 } from '../../utils/config-constants';
 import {
   createInputStatus,
@@ -183,12 +184,31 @@ export default function CurrentVariantsTable() {
     ...variant,
   }));
 
+  const showSecondVariantRecommendation = (): boolean => {
+    if (videoQualityVariants.length !== 1) {
+      return false;
+    }
+
+    const [variant] = videoQualityVariants;
+
+    return (
+      ENCODER_RECOMMENDATION_THRESHOLD.VIDEO_HEIGHT <= variant.scaledHeight ||
+      ENCODER_RECOMMENDATION_THRESHOLD.VIDEO_BITRATE <= variant.videoBitrate
+    );
+  };
+
   return (
     <>
       <Title level={3} className="section-title">
         Stream output
       </Title>
 
+      {showSecondVariantRecommendation() && (
+        <>
+          <Alert message={ENCODER_RECOMMENDATION_THRESHOLD.HELP_TEXT} type="info" closable />
+        </>
+      )}
+
       <FormStatusIndicator status={submitStatus} />
 
       <Table
diff --git a/web/utils/config-constants.tsx b/web/utils/config-constants.tsx
index 3d3487459..48d3565ef 100644
--- a/web/utils/config-constants.tsx
+++ b/web/utils/config-constants.tsx
@@ -290,6 +290,13 @@ export const ENCODER_PRESET_TOOLTIPS = {
   5: 'Highest hardware usage - higher quality video',
 };
 
+export const ENCODER_RECOMMENDATION_THRESHOLD = {
+  VIDEO_HEIGHT: 1080,
+  VIDEO_BITRATE: 3000,
+  HELP_TEXT:
+    'You have only set one video quality variant. If your server has the computing resources, consider adding another, lower-quality variant, so more people can view your content!',
+};
+
 export const DEFAULT_SOCIAL_HANDLE: SocialHandle = {
   url: '',
   platform: '',