Browse Source

Fix linter suggestions

pull/1886/head
Gabe Kangas 5 years ago
parent
commit
8bd7c77a11
  1. 2
      web/components/config/edit-social-links.tsx
  2. 2
      web/components/config/edit-storage.tsx
  3. 2
      web/pages/webhooks.tsx
  4. 6
      web/utils/urls.ts

2
web/components/config/edit-social-links.tsx

@ -13,7 +13,7 @@ import { @@ -13,7 +13,7 @@ import {
OTHER_SOCIAL_HANDLE_OPTION,
} from '../../utils/config-constants';
import { SocialHandle, UpdateArgs } from '../../types/config-section';
import { isValidUrl } from '../../utils/urls';
import isValidUrl from '../../utils/urls';
import TextField from './form-textfield';
import { createInputStatus, STATUS_ERROR, STATUS_SUCCESS } from '../../utils/input-statuses';
import FormStatusIndicator from './form-status-indicator';

2
web/components/config/edit-storage.tsx

@ -20,7 +20,7 @@ import { @@ -20,7 +20,7 @@ import {
} from '../../utils/input-statuses';
import TextField from './form-textfield';
import FormStatusIndicator from './form-status-indicator';
import { isValidUrl } from '../../utils/urls';
import isValidUrl from '../../utils/urls';
import ToggleSwitch from './form-toggleswitch';
const { Panel } = Collapse;

2
web/pages/webhooks.tsx

@ -1,7 +1,7 @@ @@ -1,7 +1,7 @@
import React, { useState, useEffect } from 'react';
import { Table, Tag, Space, Button, Modal, Checkbox, Input, Typography, Tooltip } from 'antd';
import { DeleteOutlined } from '@ant-design/icons';
import { isValidUrl } from '../utils/urls';
import isValidUrl from '../utils/urls';
import { fetchData, DELETE_WEBHOOK, CREATE_WEBHOOK, WEBHOOKS } from '../utils/apis';

6
web/utils/urls.ts

@ -1,14 +1,14 @@ @@ -1,14 +1,14 @@
export function isValidUrl(url: string): boolean {
export default function isValidUrl(url: string): boolean {
const validProtocols = ['http:', 'https:'];
try {
const validationObject = new URL(url);
if (validationObject.protocol === '' || validationObject.hostname === '' || !validProtocols.includes(validationObject.protocol)) {
return false
return false;
}
} catch(e) {
return false;
}
return true
return true;
}

Loading…
Cancel
Save