Browse Source

fix: use window.open instead of react-router on href within Button

pull/941/head
qtchaos 1 year ago
parent
commit
e8d8c16d41
No known key found for this signature in database
GPG Key ID: 7DA98B2B9EF06A90
  1. 9
      src/components/buttons/Button.tsx

9
src/components/buttons/Button.tsx

@ -21,7 +21,6 @@ interface Props {
} }
export function Button(props: Props) { export function Button(props: Props) {
const navigate = useNavigate();
const { onClick, href, loading } = props; const { onClick, href, loading } = props;
const cb = useCallback( const cb = useCallback(
( (
@ -31,10 +30,12 @@ export function Button(props: Props) {
>, >,
) => { ) => {
if (loading) return; if (loading) return;
if (href && !onClick) navigate(href); if (href && !onClick) {
else onClick?.(event); event.preventDefault();
window.open(href, "_blank", "noreferrer");
} else onClick?.(event);
}, },
[onClick, href, navigate, loading], [onClick, href, loading],
); );
let colorClasses = "bg-white hover:bg-gray-200 text-black"; let colorClasses = "bg-white hover:bg-gray-200 text-black";

Loading…
Cancel
Save