Browse Source

Add todos and fix some highlights

pull/760/head
mrjvs 2 years ago
parent
commit
e4ad8789b9
  1. 2
      src/pages/onboarding/OnboardingExtension.tsx
  2. 1
      src/pages/onboarding/OnboardingProxy.tsx
  3. 14
      src/pages/parts/settings/SetupPart.tsx

2
src/pages/onboarding/OnboardingExtension.tsx

@ -47,6 +47,7 @@ export function ExtensionStatus(props: { @@ -47,6 +47,7 @@ export function ExtensionStatus(props: {
<p>{t("onboarding.extension.status.loading")}</p>
</>
);
// TODO make proper actions for all of these states below
if (props.status === "disallowed")
content = <p>{t("onboarding.extension.status.disallowed")}</p>;
else if (props.status === "failed")
@ -81,6 +82,7 @@ export function OnboardingExtensionPage() { @@ -81,6 +82,7 @@ export function OnboardingExtensionPage() {
);
useInterval(exec, 1000);
// TODO proper link to install extension
return (
<MinimalPageLayout>
<PageTitle subpage k="global.pages.onboarding" />

1
src/pages/onboarding/OnboardingProxy.tsx

@ -40,6 +40,7 @@ export function OnboardingProxyPage() { @@ -40,6 +40,7 @@ export function OnboardingProxyPage() {
}
}, [url, completeAndRedirect, setProxySet]);
// TODO proper link to proxy deployment docs
return (
<MinimalPageLayout>
<PageTitle subpage k="global.pages.onboarding" />

14
src/pages/parts/settings/SetupPart.tsx

@ -76,6 +76,7 @@ function useIsSetup() { @@ -76,6 +76,7 @@ function useIsSetup() {
function SetupCheckList(props: {
status: Status;
grey?: boolean;
highlight?: boolean;
children?: ReactNode;
}) {
const { t } = useTranslation();
@ -98,9 +99,10 @@ function SetupCheckList(props: { @@ -98,9 +99,10 @@ function SetupCheckList(props: {
<div>
<p
className={classNames({
"text-type-dimmed opacity-75": props.grey,
"!text-white": props.grey && props.highlight,
"!text-type-dimmed opacity-75": props.grey && !props.highlight,
"text-type-danger": props.status === "error",
"text-white !opacity-100": props.status === "success",
"text-white": props.status === "success",
})}
>
{props.children}
@ -119,7 +121,7 @@ export function SetupPart() { @@ -119,7 +121,7 @@ export function SetupPart() {
const { t } = useTranslation();
const navigate = useNavigate();
const { loading, setupStates, globalState } = useIsSetup();
if (loading || !setupStates) return <p>Loading states...</p>;
if (loading || !setupStates) return <p>Loading states...</p>; // TODO proper loading screen
const textLookupMap: Record<
Status,
@ -174,7 +176,11 @@ export function SetupPart() { @@ -174,7 +176,11 @@ export function SetupPart() {
<SetupCheckList status={setupStates.proxy}>
{t("settings.connections.setup.items.proxy")}
</SetupCheckList>
<SetupCheckList grey status={setupStates.defaultProxy}>
<SetupCheckList
grey
highlight={globalState === "unset"}
status={setupStates.defaultProxy}
>
{t("settings.connections.setup.items.default")}
</SetupCheckList>
</div>

Loading…
Cancel
Save