Browse Source

cleanup todos

Co-authored-by: Jip Frijlink <JipFr@users.noreply.github.com>
Co-authored-by: James Hawkins <jhawki2005@gmail.com>
Co-authored-by: William Oldham <wegg7250@gmail.com>
pull/143/head
mrjvs 3 years ago
parent
commit
a2e647297a
  1. 16
      src/index.tsx
  2. 1
      src/state/watched/migrations/v2.ts
  3. 4
      src/video/state/providers/castingStateProvider.ts

16
src/index.tsx

@ -19,22 +19,6 @@ if (key) { @@ -19,22 +19,6 @@ if (key) {
}
initializeChromecast();
// TODO video todos:
// - chrome cast support
// - bug: safari fullscreen will make video overlap player controls
// TODO stuff to test:
// - browser: firefox, chrome, edge, safari desktop
// - phones: android firefox, android chrome, iphone safari
// - devices: ipadOS
// - HLS
// - HLS error handling
// - video player error handling
// TODO backend system:
// - implement jons providers/embedscrapers
// - AFTER all that: rank providers/embedscrapers
const LazyLoadedApp = React.lazy(async () => {
await initializeStores();
return {

1
src/state/watched/migrations/v2.ts

@ -70,7 +70,6 @@ async function getMetas( @@ -70,7 +70,6 @@ async function getMetas(
let keys: (string | null)[][] = [["0", "0"]];
if (item.data.type === "series") {
// TODO sort episodes by season & episode so it shows the "highest" episode as last
const meta = await getMetaFromId(item.data.type, item.data.id);
if (!meta || !meta?.meta.seasons) return;
const seasonNumbers = [

4
src/video/state/providers/castingStateProvider.ts

@ -17,8 +17,7 @@ import { updateMediaPlaying } from "../logic/mediaplaying"; @@ -17,8 +17,7 @@ import { updateMediaPlaying } from "../logic/mediaplaying";
import { VideoPlayerStateProvider } from "./providerTypes";
import { updateProgress } from "../logic/progress";
// TODO startAt when switching state providers
// TODO test HLS
// TODO HLS for casting?
export function createCastingStateProvider(
descriptor: string
): VideoPlayerStateProvider {
@ -184,7 +183,6 @@ export function createCastingStateProvider( @@ -184,7 +183,6 @@ export function createCastingStateProvider(
break;
case "isMuted":
state.mediaPlaying.volume = e.value ? 1 : 0;
// TODO better mute handling
updateMediaPlaying(descriptor, state);
break;
case "displayStatus":

Loading…
Cancel
Save