Browse Source

move around some todos

pull/121/head
Jelle van Snik 3 years ago
parent
commit
714b378f68
  1. 5
      src/backend/index.ts
  2. 1
      src/components/video/hooks/controlVideo.ts
  3. 1
      src/components/video/hooks/useVideoPlayer.ts
  4. 12
      src/index.tsx

5
src/backend/index.ts

@ -1,10 +1,5 @@ @@ -1,10 +1,5 @@
import { initializeScraperStore } from "./helpers/register";
// TODO backend system:
// - caption support
// - move over old providers to new system
// - implement jons providers/embedscrapers
// providers
import "./providers/gdriveplayer";

1
src/components/video/hooks/controlVideo.ts

@ -108,7 +108,6 @@ export function populateControls( @@ -108,7 +108,6 @@ export function populateControls(
initPlayer(sourceUrl: string, sourceType: MWStreamType) {
this.setVolume(getStoredVolume());
// TODO test HLS errors
if (sourceType === MWStreamType.HLS) {
if (player.canPlayType("application/vnd.apple.mpegurl")) {
player.src = sourceUrl;

1
src/components/video/hooks/useVideoPlayer.ts

@ -139,7 +139,6 @@ function registerListeners(player: HTMLVideoElement, update: SetPlayer) { @@ -139,7 +139,6 @@ function registerListeners(player: HTMLVideoElement, update: SetPlayer) {
};
const error = () => {
console.error("Native video player threw error", player.error);
// TODO check if these errors are actually fatal
update((s) => ({
...s,
error: player.error

12
src/index.tsx

@ -30,12 +30,20 @@ if (key) { @@ -30,12 +30,20 @@ if (key) {
// - browser: firefox, chrome, edge, safari desktop
// - phones: android firefox, android chrome, iphone safari
// - devices: ipadOS
// - features: HLS, error handling, preload interactions
// - HLS
// - HLS error handling
// - video player error handling
// TODO backend system:
// - caption support
// - move over old providers to new system
// - implement jons providers/embedscrapers
// - AFTER all that: rank providers/embedscrapers
// TODO general todos:
// - localize everything
// - add titles to pages
// - find place for bookmarks
// - find place for bookmark button
// - find place for progress bar for "continue watching" section
ReactDOM.render(

Loading…
Cancel
Save