rtsp server: improve performance when reading with TCP

go.mod

@@ -4,7 +4,7 @@ go 1.17
 
 require (
 	code.cloudfoundry.org/bytefmt v0.0.0-20211005130812-5bb3c17173e5
-	github.com/aler9/gortsplib v0.0.0-20220510153211-6fe7a316bad5
+	github.com/aler9/gortsplib v0.0.0-20220511132644-c1b10a80bec0
 	github.com/asticode/go-astits v1.10.1-0.20220319093903-4abe66a9b757
 	github.com/fsnotify/fsnotify v1.4.9
 	github.com/gin-gonic/gin v1.7.2

go.sum

@@ -4,8 +4,8 @@ github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751 h1:JYp7IbQjafo
 github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
 github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d h1:UQZhZ2O0vMHr2cI+DC1Mbh0TJxzA3RcLoMsFw+aXw7E=
 github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d/go.mod h1:rBZYJk541a8SKzHPHnH3zbiI+7dagKZ0cgpgrD7Fyho=
-github.com/aler9/gortsplib v0.0.0-20220510153211-6fe7a316bad5 h1:lnrr0N9zSptUx7syI7p+WxPxV+CBctYMBV3jyUTsyQM=
-github.com/aler9/gortsplib v0.0.0-20220510153211-6fe7a316bad5/go.mod h1:Mezkz7Jb5zrIWP6MxJ2uBgt5xwywZkcdmuQZ2QrFYsM=
+github.com/aler9/gortsplib v0.0.0-20220511132644-c1b10a80bec0 h1:Q/9sq+pRCofQaR4UUMeVqjHOsyrhQshmq38+6EbK3Ho=
+github.com/aler9/gortsplib v0.0.0-20220511132644-c1b10a80bec0/go.mod h1:Mezkz7Jb5zrIWP6MxJ2uBgt5xwywZkcdmuQZ2QrFYsM=
 github.com/aler9/rtmp v0.0.0-20210403095203-3be4a5535927 h1:95mXJ5fUCYpBRdSOnLAQAdJHHKxxxJrVCiaqDi965YQ=
 github.com/aler9/rtmp v0.0.0-20210403095203-3be4a5535927/go.mod h1:vzuE21rowz+lT1NGsWbreIvYulgBpCGnQyeTyFblUHc=
 github.com/asticode/go-astikit v0.20.0 h1:+7N+J4E4lWx2QOkRdOf6DafWJMv6O4RRfgClwQokrH8=

internal/core/core_test.go

@@ -2,7 +2,6 @@ package core
 
 import (
 	"bufio"
-	"bytes"
 	"fmt"
 	"io/ioutil"
 	"net"
@@ -172,15 +171,14 @@ func TestCorePathAutoDeletion(t *testing.T) {
 					u, err := base.ParseURL("rtsp://localhost:8554/mypath")
 					require.NoError(t, err)
 
-					var bb bytes.Buffer
-					base.Request{
+					byts, _ := base.Request{
 						Method: base.Describe,
 						URL:    u,
 						Header: base.Header{
 							"CSeq": base.HeaderValue{"1"},
 						},
-					}.Write(&bb)
-					_, err = conn.Write(bb.Bytes())
+					}.Write()
+					_, err = conn.Write(byts)
 					require.NoError(t, err)
 
 					var res base.Response
@@ -191,8 +189,7 @@ func TestCorePathAutoDeletion(t *testing.T) {
 					u, err := base.ParseURL("rtsp://localhost:8554/mypath/trackID=0")
 					require.NoError(t, err)
 
-					var bb bytes.Buffer
-					base.Request{
+					byts, _ := base.Request{
 						Method: base.Setup,
 						URL:    u,
 						Header: base.Header{
@@ -210,8 +207,8 @@ func TestCorePathAutoDeletion(t *testing.T) {
 								ClientPorts: &[2]int{35466, 35467},
 							}.Write(),
 						},
-					}.Write(&bb)
-					_, err = conn.Write(bb.Bytes())
+					}.Write()
+					_, err = conn.Write(byts)
 					require.NoError(t, err)
 
 					var res base.Response
@@ -310,15 +307,14 @@ func main() {
 					u, err := base.ParseURL("rtsp://localhost:8554/ondemand")
 					require.NoError(t, err)
 
-					var bb bytes.Buffer
-					base.Request{
+					byts, _ := base.Request{
 						Method: base.Describe,
 						URL:    u,
 						Header: base.Header{
 							"CSeq": base.HeaderValue{"1"},
 						},
-					}.Write(&bb)
-					_, err = conn.Write(bb.Bytes())
+					}.Write()
+					_, err = conn.Write(byts)
 					require.NoError(t, err)
 
 					var res base.Response
@@ -331,8 +327,7 @@ func main() {
 					u, err := base.ParseURL("rtsp://localhost:8554/ondemand/trackID=0")
 					require.NoError(t, err)
 
-					var bb bytes.Buffer
-					base.Request{
+					byts, _ := base.Request{
 						Method: base.Setup,
 						URL:    u,
 						Header: base.Header{
@@ -346,8 +341,8 @@ func main() {
 								InterleavedIDs: &[2]int{0, 1},
 							}.Write(),
 						},
-					}.Write(&bb)
-					_, err = conn.Write(bb.Bytes())
+					}.Write()
+					_, err = conn.Write(byts)
 					require.NoError(t, err)
 
 					var res base.Response