Browse Source

add TODO comments

pull/764/head
aler9 4 years ago
parent
commit
b48e2f1f1b
  1. 6
      internal/conf/path.go
  2. 6
      internal/core/api.go

6
internal/conf/path.go

@ -67,10 +67,12 @@ type PathConf struct { @@ -67,10 +67,12 @@ type PathConf struct {
RunOnDemandCloseAfter StringDuration `json:"runOnDemandCloseAfter"`
RunOnReady string `json:"runOnReady"`
RunOnReadyRestart bool `json:"runOnReadyRestart"`
RunOnPublish string `json:"runOnPublish"` // deprecated, replaced by runOnReady
RunOnPublishRestart bool `json:"runOnPublishRestart"` // deprecated, replaced by runOnReadyRestart
RunOnRead string `json:"runOnRead"`
RunOnReadRestart bool `json:"runOnReadRestart"`
// deprecated, replaced by runOnReady. TODO: remove in next version
RunOnPublish string `json:"runOnPublish"`
RunOnPublishRestart bool `json:"runOnPublishRestart"`
}
func (pconf *PathConf) checkAndFillMissing(conf *Conf, name string) error {

6
internal/core/api.go

@ -127,10 +127,12 @@ func loadConfPathData(ctx *gin.Context) (interface{}, error) { @@ -127,10 +127,12 @@ func loadConfPathData(ctx *gin.Context) (interface{}, error) {
RunOnDemandCloseAfter *conf.StringDuration `json:"runOnDemandCloseAfter"`
RunOnReady *string `json:"runOnReady"`
RunOnReadyRestart *bool `json:"runOnReadyRestart"`
RunOnPublish *string `json:"runOnPublish"` // deprecated, replaced by runOnReady
RunOnPublishRestart *bool `json:"runOnPublishRestart"` // deprecated, replaced by runOnReadyRestart
RunOnRead *string `json:"runOnRead"`
RunOnReadRestart *bool `json:"runOnReadRestart"`
// deprecated, replaced by runOnReady. TODO: remove in next version
RunOnPublish *string `json:"runOnPublish"`
RunOnPublishRestart *bool `json:"runOnPublishRestart"`
}
err := json.NewDecoder(ctx.Request.Body).Decode(&in)
if err != nil {

Loading…
Cancel
Save