Browse Source

webrtc: fix crash during client disconnection (#1482) (#1501)

OnConnectionStateChange of pion/webrtc is not thread safe. Add a mutex
to make it thread safe.
pull/1502/head
Alessandro Ros 3 years ago committed by GitHub
parent
commit
64b8fd3554
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      internal/core/webrtc_conn.go

4
internal/core/webrtc_conn.go

@ -345,8 +345,12 @@ func (c *webRTCConn) runInner(ctx context.Context) error {
pcConnected := make(chan struct{}) pcConnected := make(chan struct{})
pcDisconnected := make(chan struct{}) pcDisconnected := make(chan struct{})
pcClosed := make(chan struct{}) pcClosed := make(chan struct{})
var stateChangeMutex sync.Mutex
pc.OnConnectionStateChange(func(state webrtc.PeerConnectionState) { pc.OnConnectionStateChange(func(state webrtc.PeerConnectionState) {
stateChangeMutex.Lock()
defer stateChangeMutex.Unlock()
select { select {
case <-pcClosed: case <-pcClosed:
return return

Loading…
Cancel
Save