print warning in case no key frames are being received (#1763)

internal/conf/conf.go

@@ -308,7 +308,7 @@ func (conf *Conf) CheckAndFillMissing() error {
 		conf.LogLevel = LogLevel(logger.Info)
 	}
 	if len(conf.LogDestinations) == 0 {
-		conf.LogDestinations = LogDestinations{logger.DestinationStdout: {}}
+		conf.LogDestinations = LogDestinations{logger.DestinationStdout}
 	}
 	if conf.LogFile == "" {
 		conf.LogFile = "mediamtx.log"

internal/conf/logdestination.go

@@ -3,21 +3,20 @@ package conf
 import (
 	"encoding/json"
 	"fmt"
-	"sort"
 	"strings"
 
 	"github.com/aler9/mediamtx/internal/logger"
 )
 
 // LogDestinations is the logDestionations parameter.
-type LogDestinations map[logger.Destination]struct{}
+type LogDestinations []logger.Destination
 
 // MarshalJSON implements json.Marshaler.
 func (d LogDestinations) MarshalJSON() ([]byte, error) {
 	out := make([]string, len(d))
 	i := 0
 
-	for p := range d {
+	for _, p := range d {
 		var v string
 
 		switch p {
@@ -38,11 +37,18 @@ func (d LogDestinations) MarshalJSON() ([]byte, error) {
 		i++
 	}
 
-	sort.Strings(out)
-
 	return json.Marshal(out)
 }
 
+func (d *LogDestinations) contains(v logger.Destination) bool {
+	for _, item := range *d {
+		if item == v {
+			return true
+		}
+	}
+	return false
+}
+
 // UnmarshalJSON implements json.Unmarshaler.
 func (d *LogDestinations) UnmarshalJSON(b []byte) error {
 	var in []string
@@ -50,22 +56,27 @@ func (d *LogDestinations) UnmarshalJSON(b []byte) error {
 		return err
 	}
 
-	*d = make(LogDestinations)
-
-	for _, proto := range in {
-		switch proto {
+	for _, dest := range in {
+		var v logger.Destination
+		switch dest {
 		case "stdout":
-			(*d)[logger.DestinationStdout] = struct{}{}
+			v = logger.DestinationStdout
 
 		case "file":
-			(*d)[logger.DestinationFile] = struct{}{}
+			v = logger.DestinationFile
 
 		case "syslog":
-			(*d)[logger.DestinationSyslog] = struct{}{}
+			v = logger.DestinationSyslog
 
 		default:
-			return fmt.Errorf("invalid log destination: %s", proto)
+			return fmt.Errorf("invalid log destination: %s", dest)
+		}
+
+		if d.contains(v) {
+			return fmt.Errorf("log destination set twice")
 		}
+
+		*d = append(*d, v)
 	}
 
 	return nil

internal/core/api.go

@@ -98,7 +98,7 @@ type apiRTMPServer interface {
 }
 
 type apiParent interface {
-	Log(logger.Level, string, ...interface{})
+	logger.Writer
 	apiConfigSet(conf *conf.Conf)
 }
 
@@ -208,18 +208,18 @@ func newAPI(
 
 	go a.httpServer.Serve(ln)
 
-	a.log(logger.Info, "listener opened on "+address)
+	a.Log(logger.Info, "listener opened on "+address)
 
 	return a, nil
 }
 
 func (a *api) close() {
-	a.log(logger.Info, "listener is closing")
+	a.Log(logger.Info, "listener is closing")
 	a.httpServer.Shutdown(context.Background())
 	a.ln.Close() // in case Shutdown() is called before Serve()
 }
 
-func (a *api) log(level logger.Level, format string, args ...interface{}) {
+func (a *api) Log(level logger.Level, format string, args ...interface{}) {
 	a.parent.Log(level, "[API] "+format, args...)
 }
 

internal/core/hls_muxer.go

@@ -60,7 +60,7 @@ type hlsMuxerPathManager interface {
 }
 
 type hlsMuxerParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 	muxerClose(*hlsMuxer)
 }
 
@@ -141,7 +141,7 @@ func newHLSMuxer(
 		chAPIHLSMuxersList: make(chan hlsServerAPIMuxersListSubReq),
 	}
 
-	m.log(logger.Info, "created %s", func() string {
+	m.Log(logger.Info, "created %s", func() string {
 		if remoteAddr == "" {
 			return "automatically"
 		}
@@ -158,8 +158,8 @@ func (m *hlsMuxer) close() {
 	m.ctxCancel()
 }
 
-func (m *hlsMuxer) log(level logger.Level, format string, args ...interface{}) {
-	m.parent.log(level, "[muxer %s] "+format, append([]interface{}{m.pathName}, args...)...)
+func (m *hlsMuxer) Log(level logger.Level, format string, args ...interface{}) {
+	m.parent.Log(level, "[muxer %s] "+format, append([]interface{}{m.pathName}, args...)...)
 }
 
 // PathName returns the path name.
@@ -231,7 +231,7 @@ func (m *hlsMuxer) run() {
 				innerCtxCancel()
 
 				if m.alwaysRemux {
-					m.log(logger.Info, "ERR: %v", err)
+					m.Log(logger.Info, "ERR: %v", err)
 					m.clearQueuedRequests()
 					isReady = false
 					isRecreating = true
@@ -253,7 +253,7 @@ func (m *hlsMuxer) run() {
 
 	m.parent.muxerClose(m)
 
-	m.log(logger.Info, "destroyed (%v)", err)
+	m.Log(logger.Info, "destroyed (%v)", err)
 }
 
 func (m *hlsMuxer) clearQueuedRequests() {
@@ -325,7 +325,7 @@ func (m *hlsMuxer) runInner(innerCtx context.Context, innerReady chan struct{})
 
 	innerReady <- struct{}{}
 
-	m.log(logger.Info, "is converting into HLS, %s",
+	m.Log(logger.Info, "is converting into HLS, %s",
 		sourceMediaInfo(medias))
 
 	writerDone := make(chan error)
@@ -557,7 +557,7 @@ func (m *hlsMuxer) handleRequest(ctx *gin.Context) {
 	err := m.authenticate(ctx)
 	if err != nil {
 		if terr, ok := err.(pathErrAuthCritical); ok {
-			m.log(logger.Info, "authentication error: %s", terr.message)
+			m.Log(logger.Info, "authentication error: %s", terr.message)
 		}
 
 		ctx.Header("WWW-Authenticate", `Basic realm="mediamtx"`)

internal/core/hls_server.go

@@ -50,7 +50,7 @@ type hlsServerAPIMuxersListSubReq struct {
 }
 
 type hlsServerParent interface {
-	Log(logger.Level, string, ...interface{})
+	logger.Writer
 }
 
 type hlsServer struct {
@@ -162,7 +162,7 @@ func newHLSServer(
 		ErrorLog:          log.New(&nilWriter{}, "", 0),
 	}
 
-	s.log(logger.Info, "listener opened on "+address)
+	s.Log(logger.Info, "listener opened on "+address)
 
 	s.pathManager.hlsServerSet(s)
 
@@ -177,12 +177,12 @@ func newHLSServer(
 }
 
 // Log is the main logging function.
-func (s *hlsServer) log(level logger.Level, format string, args ...interface{}) {
+func (s *hlsServer) Log(level logger.Level, format string, args ...interface{}) {
 	s.parent.Log(level, "[HLS] "+format, append([]interface{}{}, args...)...)
 }
 
 func (s *hlsServer) close() {
-	s.log(logger.Info, "listener is closing")
+	s.Log(logger.Info, "listener is closing")
 	s.ctxCancel()
 	s.wg.Wait()
 }

internal/core/hls_source.go

@@ -21,7 +21,7 @@ import (
 )
 
 type hlsSourceParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 	sourceStaticImplSetReady(req pathSourceStaticSetReadyReq) pathSourceStaticSetReadyRes
 	sourceStaticImplSetNotReady(req pathSourceStaticSetNotReadyReq)
 }
@@ -39,7 +39,7 @@ func newHLSSource(
 }
 
 func (s *hlsSource) Log(level logger.Level, format string, args ...interface{}) {
-	s.parent.log(level, "[hls source] "+format, args...)
+	s.parent.Log(level, "[hls source] "+format, args...)
 }
 
 // run implements sourceStaticImpl.
@@ -103,14 +103,11 @@ func (s *hlsSource) run(ctx context.Context, cnf *conf.PathConf, reloadConf chan
 				}
 
 				c.OnData(track, func(pts time.Duration, unit interface{}) {
-					err := stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitH264{
+					stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitH264{
 						PTS: pts,
 						AU:  unit.([][]byte),
 						NTP: time.Now(),
 					})
-					if err != nil {
-						s.Log(logger.Warn, "%v", err)
-					}
 				})
 
 			case *codecs.H265:
@@ -125,14 +122,11 @@ func (s *hlsSource) run(ctx context.Context, cnf *conf.PathConf, reloadConf chan
 				}
 
 				c.OnData(track, func(pts time.Duration, unit interface{}) {
-					err := stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitH265{
+					stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitH265{
 						PTS: pts,
 						AU:  unit.([][]byte),
 						NTP: time.Now(),
 					})
-					if err != nil {
-						s.Log(logger.Warn, "%v", err)
-					}
 				})
 
 			case *codecs.MPEG4Audio:
@@ -148,14 +142,11 @@ func (s *hlsSource) run(ctx context.Context, cnf *conf.PathConf, reloadConf chan
 				}
 
 				c.OnData(track, func(pts time.Duration, unit interface{}) {
-					err := stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitMPEG4Audio{
+					stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitMPEG4Audio{
 						PTS: pts,
 						AUs: [][]byte{unit.([]byte)},
 						NTP: time.Now(),
 					})
-					if err != nil {
-						s.Log(logger.Warn, "%v", err)
-					}
 				})
 
 			case *codecs.Opus:
@@ -168,14 +159,11 @@ func (s *hlsSource) run(ctx context.Context, cnf *conf.PathConf, reloadConf chan
 				}
 
 				c.OnData(track, func(pts time.Duration, unit interface{}) {
-					err := stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitOpus{
+					stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitOpus{
 						PTS:   pts,
 						Frame: unit.([]byte),
 						NTP:   time.Now(),
 					})
-					if err != nil {
-						s.Log(logger.Warn, "%v", err)
-					}
 				})
 			}
 

internal/core/http_logger.go

@@ -38,21 +38,21 @@ func (w *httpLoggerWriter) dump() string {
 }
 
 type httpLoggerParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 }
 
 func httpLoggerMiddleware(p httpLoggerParent) func(*gin.Context) {
 	return func(ctx *gin.Context) {
-		p.log(logger.Debug, "[conn %v] %s %s", ctx.Request.RemoteAddr, ctx.Request.Method, ctx.Request.URL.Path)
+		p.Log(logger.Debug, "[conn %v] %s %s", ctx.Request.RemoteAddr, ctx.Request.Method, ctx.Request.URL.Path)
 
 		byts, _ := httputil.DumpRequest(ctx.Request, true)
-		p.log(logger.Debug, "[conn %v] [c->s] %s", ctx.Request.RemoteAddr, string(byts))
+		p.Log(logger.Debug, "[conn %v] [c->s] %s", ctx.Request.RemoteAddr, string(byts))
 
 		logw := &httpLoggerWriter{ResponseWriter: ctx.Writer}
 		ctx.Writer = logw
 
 		ctx.Next()
 
-		p.log(logger.Debug, "[conn %v] [s->c] %s", ctx.Request.RemoteAddr, logw.dump())
+		p.Log(logger.Debug, "[conn %v] [s->c] %s", ctx.Request.RemoteAddr, logw.dump())
 	}
 }

internal/core/metrics.go

@@ -21,7 +21,7 @@ func metric(key string, tags string, value int64) string {
 }
 
 type metricsParent interface {
-	Log(logger.Level, string, ...interface{})
+	logger.Writer
 }
 
 type metrics struct {
@@ -66,7 +66,7 @@ func newMetrics(
 		ErrorLog:          log.New(&nilWriter{}, "", 0),
 	}
 
-	m.log(logger.Info, "listener opened on "+address)
+	m.Log(logger.Info, "listener opened on "+address)
 
 	go m.httpServer.Serve(m.ln)
 
@@ -74,12 +74,12 @@ func newMetrics(
 }
 
 func (m *metrics) close() {
-	m.log(logger.Info, "listener is closing")
+	m.Log(logger.Info, "listener is closing")
 	m.httpServer.Shutdown(context.Background())
 	m.ln.Close() // in case Shutdown() is called before Serve()
 }
 
-func (m *metrics) log(level logger.Level, format string, args ...interface{}) {
+func (m *metrics) Log(level logger.Level, format string, args ...interface{}) {
 	m.parent.Log(level, "[metrics] "+format, args...)
 }
 

internal/core/path.go

@@ -61,7 +61,7 @@ func (pathErrAuthCritical) Error() string {
 }
 
 type pathParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 	pathSourceReady(*path)
 	pathSourceNotReady(*path)
 	onPathClose(*path)
@@ -287,7 +287,7 @@ func newPath(
 		done:                           make(chan struct{}),
 	}
 
-	pa.log(logger.Debug, "created")
+	pa.Log(logger.Debug, "created")
 
 	pa.wg.Add(1)
 	go pa.run()
@@ -304,8 +304,8 @@ func (pa *path) wait() {
 }
 
 // Log is the main logging function.
-func (pa *path) log(level logger.Level, format string, args ...interface{}) {
-	pa.parent.log(level, "[path "+pa.name+"] "+format, args...)
+func (pa *path) Log(level logger.Level, format string, args ...interface{}) {
+	pa.parent.Log(level, "[path "+pa.name+"] "+format, args...)
 }
 
 func (pa *path) safeConf() *conf.PathConf {
@@ -335,14 +335,14 @@ func (pa *path) run() {
 
 	var onInitCmd *externalcmd.Cmd
 	if pa.conf.RunOnInit != "" {
-		pa.log(logger.Info, "runOnInit command started")
+		pa.Log(logger.Info, "runOnInit command started")
 		onInitCmd = externalcmd.NewCmd(
 			pa.externalCmdPool,
 			pa.conf.RunOnInit,
 			pa.conf.RunOnInitRestart,
 			pa.externalCmdEnv(),
 			func(co int) {
-				pa.log(logger.Info, "runOnInit command exited with code %d", co)
+				pa.Log(logger.Info, "runOnInit command exited with code %d", co)
 			})
 	}
 
@@ -507,7 +507,7 @@ func (pa *path) run() {
 
 	if onInitCmd != nil {
 		onInitCmd.Close()
-		pa.log(logger.Info, "runOnInit command stopped")
+		pa.Log(logger.Info, "runOnInit command stopped")
 	}
 
 	for _, req := range pa.describeRequestsOnHold {
@@ -532,10 +532,10 @@ func (pa *path) run() {
 
 	if pa.onDemandCmd != nil {
 		pa.onDemandCmd.Close()
-		pa.log(logger.Info, "runOnDemand command stopped")
+		pa.Log(logger.Info, "runOnDemand command stopped")
 	}
 
-	pa.log(logger.Debug, "destroyed (%v)", err)
+	pa.Log(logger.Debug, "destroyed (%v)", err)
 }
 
 func (pa *path) shouldClose() bool {
@@ -590,14 +590,14 @@ func (pa *path) onDemandStaticSourceStop() {
 }
 
 func (pa *path) onDemandPublisherStart() {
-	pa.log(logger.Info, "runOnDemand command started")
+	pa.Log(logger.Info, "runOnDemand command started")
 	pa.onDemandCmd = externalcmd.NewCmd(
 		pa.externalCmdPool,
 		pa.conf.RunOnDemand,
 		pa.conf.RunOnDemandRestart,
 		pa.externalCmdEnv(),
 		func(co int) {
-			pa.log(logger.Info, "runOnDemand command exited with code %d", co)
+			pa.Log(logger.Info, "runOnDemand command exited with code %d", co)
 		})
 
 	pa.onDemandPublisherReadyTimer.Stop()
@@ -630,7 +630,7 @@ func (pa *path) onDemandPublisherStop() {
 	if pa.onDemandCmd != nil {
 		pa.onDemandCmd.Close()
 		pa.onDemandCmd = nil
-		pa.log(logger.Info, "runOnDemand command stopped")
+		pa.Log(logger.Info, "runOnDemand command stopped")
 	}
 }
 
@@ -640,6 +640,7 @@ func (pa *path) sourceSetReady(medias media.Medias, allocateEncoder bool) error
 		medias,
 		allocateEncoder,
 		pa.bytesReceived,
+		pa.source,
 	)
 	if err != nil {
 		return err
@@ -648,14 +649,14 @@ func (pa *path) sourceSetReady(medias media.Medias, allocateEncoder bool) error
 	pa.stream = stream
 
 	if pa.conf.RunOnReady != "" {
-		pa.log(logger.Info, "runOnReady command started")
+		pa.Log(logger.Info, "runOnReady command started")
 		pa.onReadyCmd = externalcmd.NewCmd(
 			pa.externalCmdPool,
 			pa.conf.RunOnReady,
 			pa.conf.RunOnReadyRestart,
 			pa.externalCmdEnv(),
 			func(co int) {
-				pa.log(logger.Info, "runOnReady command exited with code %d", co)
+				pa.Log(logger.Info, "runOnReady command exited with code %d", co)
 			})
 	}
 
@@ -675,7 +676,7 @@ func (pa *path) sourceSetNotReady() {
 	if pa.onReadyCmd != nil {
 		pa.onReadyCmd.Close()
 		pa.onReadyCmd = nil
-		pa.log(logger.Info, "runOnReady command stopped")
+		pa.Log(logger.Info, "runOnReady command stopped")
 	}
 
 	if pa.stream != nil {
@@ -772,7 +773,7 @@ func (pa *path) handlePublisherAdd(req pathPublisherAddReq) {
 			return
 		}
 
-		pa.log(logger.Info, "closing existing publisher")
+		pa.Log(logger.Info, "closing existing publisher")
 		pa.source.(publisher).close()
 		pa.doPublisherRemove()
 	}

internal/core/path_manager.go

@@ -35,7 +35,7 @@ type pathManagerHLSServer interface {
 }
 
 type pathManagerParent interface {
-	Log(logger.Level, string, ...interface{})
+	logger.Writer
 }
 
 type pathManager struct {
@@ -117,7 +117,7 @@ func newPathManager(
 		pm.metrics.pathManagerSet(pm)
 	}
 
-	pm.log(logger.Debug, "path manager created")
+	pm.Log(logger.Debug, "path manager created")
 
 	pm.wg.Add(1)
 	go pm.run()
@@ -126,13 +126,13 @@ func newPathManager(
 }
 
 func (pm *pathManager) close() {
-	pm.log(logger.Debug, "path manager is shutting down")
+	pm.Log(logger.Debug, "path manager is shutting down")
 	pm.ctxCancel()
 	pm.wg.Wait()
 }
 
 // Log is the main logging function.
-func (pm *pathManager) log(level logger.Level, format string, args ...interface{}) {
+func (pm *pathManager) Log(level logger.Level, format string, args ...interface{}) {
 	pm.parent.Log(level, format, args...)
 }
 

internal/core/pprof.go

@@ -15,7 +15,7 @@ import (
 )
 
 type pprofParent interface {
-	Log(logger.Level, string, ...interface{})
+	logger.Writer
 }
 
 type pprof struct {
@@ -46,7 +46,7 @@ func newPPROF(
 		ErrorLog:          log.New(&nilWriter{}, "", 0),
 	}
 
-	pp.log(logger.Info, "listener opened on "+address)
+	pp.Log(logger.Info, "listener opened on "+address)
 
 	go pp.httpServer.Serve(pp.ln)
 
@@ -54,11 +54,11 @@ func newPPROF(
 }
 
 func (pp *pprof) close() {
-	pp.log(logger.Info, "listener is closing")
+	pp.Log(logger.Info, "listener is closing")
 	pp.httpServer.Shutdown(context.Background())
 	pp.ln.Close() // in case Shutdown() is called before Serve()
 }
 
-func (pp *pprof) log(level logger.Level, format string, args ...interface{}) {
+func (pp *pprof) Log(level logger.Level, format string, args ...interface{}) {
 	pp.parent.Log(level, "[pprof] "+format, args...)
 }

internal/core/rpicamera_source.go

@@ -50,7 +50,7 @@ func paramsFromConf(cnf *conf.PathConf) rpicamera.Params {
 }
 
 type rpiCameraSourceParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 	sourceStaticImplSetReady(req pathSourceStaticSetReadyReq) pathSourceStaticSetReadyRes
 	sourceStaticImplSetNotReady(req pathSourceStaticSetNotReadyReq)
 }
@@ -68,7 +68,7 @@ func newRPICameraSource(
 }
 
 func (s *rpiCameraSource) Log(level logger.Level, format string, args ...interface{}) {
-	s.parent.log(level, "[rpicamera source] "+format, args...)
+	s.parent.Log(level, "[rpicamera source] "+format, args...)
 }
 
 // run implements sourceStaticImpl.
@@ -97,14 +97,11 @@ func (s *rpiCameraSource) run(ctx context.Context, cnf *conf.PathConf, reloadCon
 			stream = res.stream
 		}
 
-		err := stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitH264{
+		stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitH264{
 			PTS: dts,
 			AU:  au,
 			NTP: time.Now(),
 		})
-		if err != nil {
-			s.Log(logger.Warn, "%v", err)
-		}
 	}
 
 	cam, err := rpicamera.New(paramsFromConf(cnf), onData)

internal/core/rtmp_conn.go

@@ -61,7 +61,7 @@ func getRTMPWriteFunc(medi *media.Media, format formats.Format, stream *stream)
 					conf.PPS,
 				}
 
-				return stream.writeUnit(medi, format, &formatprocessor.UnitH264{
+				stream.writeUnit(medi, format, &formatprocessor.UnitH264{
 					PTS: tmsg.DTS + tmsg.PTSDelta,
 					AU:  au,
 					NTP: time.Now(),
@@ -73,7 +73,7 @@ func getRTMPWriteFunc(medi *media.Media, format formats.Format, stream *stream)
 					return fmt.Errorf("unable to decode AVCC: %v", err)
 				}
 
-				return stream.writeUnit(medi, format, &formatprocessor.UnitH264{
+				stream.writeUnit(medi, format, &formatprocessor.UnitH264{
 					PTS: tmsg.DTS + tmsg.PTSDelta,
 					AU:  au,
 					NTP: time.Now(),
@@ -92,22 +92,26 @@ func getRTMPWriteFunc(medi *media.Media, format formats.Format, stream *stream)
 				return fmt.Errorf("unable to decode AVCC: %v", err)
 			}
 
-			return stream.writeUnit(medi, format, &formatprocessor.UnitH265{
+			stream.writeUnit(medi, format, &formatprocessor.UnitH265{
 				PTS: tmsg.DTS + tmsg.PTSDelta,
 				AU:  au,
 				NTP: time.Now(),
 			})
+
+			return nil
 		}
 
 	case *formats.MPEG2Audio:
 		return func(msg interface{}) error {
 			tmsg := msg.(*message.MsgAudio)
 
-			return stream.writeUnit(medi, format, &formatprocessor.UnitMPEG2Audio{
+			stream.writeUnit(medi, format, &formatprocessor.UnitMPEG2Audio{
 				PTS:    tmsg.DTS,
 				Frames: [][]byte{tmsg.Payload},
 				NTP:    time.Now(),
 			})
+
+			return nil
 		}
 
 	case *formats.MPEG4Audio:
@@ -115,7 +119,7 @@ func getRTMPWriteFunc(medi *media.Media, format formats.Format, stream *stream)
 			tmsg := msg.(*message.MsgAudio)
 
 			if tmsg.AACType == message.MsgAudioAACTypeAU {
-				return stream.writeUnit(medi, format, &formatprocessor.UnitMPEG4Audio{
+				stream.writeUnit(medi, format, &formatprocessor.UnitMPEG4Audio{
 					PTS: tmsg.DTS,
 					AUs: [][]byte{tmsg.Payload},
 					NTP: time.Now(),
@@ -124,10 +128,9 @@ func getRTMPWriteFunc(medi *media.Media, format formats.Format, stream *stream)
 
 			return nil
 		}
-
-	default:
-		return nil
 	}
+
+	return nil
 }
 
 type rtmpConnState int
@@ -144,7 +147,7 @@ type rtmpConnPathManager interface {
 }
 
 type rtmpConnParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 	connClose(*rtmpConn)
 }
 
@@ -211,7 +214,7 @@ func newRTMPConn(
 		created:                   time.Now(),
 	}
 
-	c.log(logger.Info, "opened")
+	c.Log(logger.Info, "opened")
 
 	c.wg.Add(1)
 	go c.run()
@@ -227,8 +230,8 @@ func (c *rtmpConn) remoteAddr() net.Addr {
 	return c.nconn.RemoteAddr()
 }
 
-func (c *rtmpConn) log(level logger.Level, format string, args ...interface{}) {
-	c.parent.log(level, "[conn %v] "+format, append([]interface{}{c.nconn.RemoteAddr()}, args...)...)
+func (c *rtmpConn) Log(level logger.Level, format string, args ...interface{}) {
+	c.parent.Log(level, "[conn %v] "+format, append([]interface{}{c.nconn.RemoteAddr()}, args...)...)
 }
 
 func (c *rtmpConn) ip() net.IP {
@@ -245,7 +248,7 @@ func (c *rtmpConn) run() {
 	defer c.wg.Done()
 
 	if c.runOnConnect != "" {
-		c.log(logger.Info, "runOnConnect command started")
+		c.Log(logger.Info, "runOnConnect command started")
 		_, port, _ := net.SplitHostPort(c.rtspAddress)
 		onConnectCmd := externalcmd.NewCmd(
 			c.externalCmdPool,
@@ -256,12 +259,12 @@ func (c *rtmpConn) run() {
 				"RTSP_PORT": port,
 			},
 			func(co int) {
-				c.log(logger.Info, "runOnConnect command exited with code %d", co)
+				c.Log(logger.Info, "runOnConnect command exited with code %d", co)
 			})
 
 		defer func() {
 			onConnectCmd.Close()
-			c.log(logger.Info, "runOnConnect command stopped")
+			c.Log(logger.Info, "runOnConnect command stopped")
 		}()
 	}
 
@@ -286,7 +289,7 @@ func (c *rtmpConn) run() {
 
 	c.parent.connClose(c)
 
-	c.log(logger.Info, "closed (%v)", err)
+	c.Log(logger.Info, "closed (%v)", err)
 }
 
 func (c *rtmpConn) runInner(ctx context.Context) error {
@@ -371,24 +374,24 @@ func (c *rtmpConn) runRead(ctx context.Context, u *url.URL) error {
 
 	defer res.stream.readerRemove(c)
 
-	c.log(logger.Info, "is reading from path '%s', %s",
+	c.Log(logger.Info, "is reading from path '%s', %s",
 		path.name, sourceMediaInfo(medias))
 
 	pathConf := path.safeConf()
 
 	if pathConf.RunOnRead != "" {
-		c.log(logger.Info, "runOnRead command started")
+		c.Log(logger.Info, "runOnRead command started")
 		onReadCmd := externalcmd.NewCmd(
 			c.externalCmdPool,
 			pathConf.RunOnRead,
 			pathConf.RunOnReadRestart,
 			path.externalCmdEnv(),
 			func(co int) {
-				c.log(logger.Info, "runOnRead command exited with code %d", co)
+				c.Log(logger.Info, "runOnRead command exited with code %d", co)
 			})
 		defer func() {
 			onReadCmd.Close()
-			c.log(logger.Info, "runOnRead command stopped")
+			c.Log(logger.Info, "runOnRead command stopped")
 		}()
 	}
 
@@ -731,7 +734,7 @@ func (c *rtmpConn) runPublish(ctx context.Context, u *url.URL) error {
 		return rres.err
 	}
 
-	c.log(logger.Info, "is publishing to path '%s', %s",
+	c.Log(logger.Info, "is publishing to path '%s', %s",
 		path.name,
 		sourceMediaInfo(medias))
 
@@ -756,7 +759,7 @@ func (c *rtmpConn) runPublish(ctx context.Context, u *url.URL) error {
 
 			err := videoWriteFunc(tmsg)
 			if err != nil {
-				c.log(logger.Warn, "%v", err)
+				c.Log(logger.Warn, "%v", err)
 			}
 
 		case *message.MsgAudio:
@@ -766,7 +769,7 @@ func (c *rtmpConn) runPublish(ctx context.Context, u *url.URL) error {
 
 			err := audioWriteFunc(tmsg)
 			if err != nil {
-				c.log(logger.Warn, "%v", err)
+				c.Log(logger.Warn, "%v", err)
 			}
 		}
 	}

internal/core/rtmp_server.go

@@ -44,7 +44,7 @@ type rtmpServerAPIConnsKickReq struct {
 }
 
 type rtmpServerParent interface {
-	Log(logger.Level, string, ...interface{})
+	logger.Writer
 }
 
 type rtmpServer struct {
@@ -132,7 +132,7 @@ func newRTMPServer(
 		chAPIConnsKick:            make(chan rtmpServerAPIConnsKickReq),
 	}
 
-	s.log(logger.Info, "listener opened on %s", address)
+	s.Log(logger.Info, "listener opened on %s", address)
 
 	if s.metrics != nil {
 		s.metrics.rtmpServerSet(s)
@@ -144,7 +144,7 @@ func newRTMPServer(
 	return s, nil
 }
 
-func (s *rtmpServer) log(level logger.Level, format string, args ...interface{}) {
+func (s *rtmpServer) Log(level logger.Level, format string, args ...interface{}) {
 	label := func() string {
 		if s.isTLS {
 			return "RTMPS"
@@ -155,7 +155,7 @@ func (s *rtmpServer) log(level logger.Level, format string, args ...interface{})
 }
 
 func (s *rtmpServer) close() {
-	s.log(logger.Info, "listener is closing")
+	s.Log(logger.Info, "listener is closing")
 	s.ctxCancel()
 	s.wg.Wait()
 }
@@ -193,7 +193,7 @@ outer:
 	for {
 		select {
 		case err := <-acceptErr:
-			s.log(logger.Error, "%s", err)
+			s.Log(logger.Error, "%s", err)
 			break outer
 
 		case nconn := <-connNew:

internal/core/rtmp_source.go

@@ -21,7 +21,7 @@ import (
 )
 
 type rtmpSourceParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 	sourceStaticImplSetReady(req pathSourceStaticSetReadyReq) pathSourceStaticSetReadyRes
 	sourceStaticImplSetNotReady(req pathSourceStaticSetNotReadyReq)
 }
@@ -45,7 +45,7 @@ func newRTMPSource(
 }
 
 func (s *rtmpSource) Log(level logger.Level, format string, args ...interface{}) {
-	s.parent.log(level, "[rtmp source] "+format, args...)
+	s.parent.Log(level, "[rtmp source] "+format, args...)
 }
 
 // run implements sourceStaticImpl.

internal/core/rtsp_conn.go

@@ -23,7 +23,7 @@ const (
 )
 
 type rtspConnParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 }
 
 type rtspConn struct {
@@ -74,10 +74,10 @@ func newRTSPConn(
 		created:                   time.Now(),
 	}
 
-	c.log(logger.Info, "opened")
+	c.Log(logger.Info, "opened")
 
 	if c.runOnConnect != "" {
-		c.log(logger.Info, "runOnConnect command started")
+		c.Log(logger.Info, "runOnConnect command started")
 		_, port, _ := net.SplitHostPort(c.rtspAddress)
 		c.onConnectCmd = externalcmd.NewCmd(
 			c.externalCmdPool,
@@ -88,15 +88,15 @@ func newRTSPConn(
 				"RTSP_PORT": port,
 			},
 			func(co int) {
-				c.log(logger.Info, "runOnInit command exited with code %d", co)
+				c.Log(logger.Info, "runOnInit command exited with code %d", co)
 			})
 	}
 
 	return c
 }
 
-func (c *rtspConn) log(level logger.Level, format string, args ...interface{}) {
-	c.parent.log(level, "[conn %v] "+format, append([]interface{}{c.conn.NetConn().RemoteAddr()}, args...)...)
+func (c *rtspConn) Log(level logger.Level, format string, args ...interface{}) {
+	c.parent.Log(level, "[conn %v] "+format, append([]interface{}{c.conn.NetConn().RemoteAddr()}, args...)...)
 }
 
 // Conn returns the RTSP connection.
@@ -235,22 +235,22 @@ func (c *rtspConn) authenticate(
 
 // onClose is called by rtspServer.
 func (c *rtspConn) onClose(err error) {
-	c.log(logger.Info, "closed (%v)", err)
+	c.Log(logger.Info, "closed (%v)", err)
 
 	if c.onConnectCmd != nil {
 		c.onConnectCmd.Close()
-		c.log(logger.Info, "runOnConnect command stopped")
+		c.Log(logger.Info, "runOnConnect command stopped")
 	}
 }
 
 // onRequest is called by rtspServer.
 func (c *rtspConn) onRequest(req *base.Request) {
-	c.log(logger.Debug, "[c->s] %v", req)
+	c.Log(logger.Debug, "[c->s] %v", req)
 }
 
 // OnResponse is called by rtspServer.
 func (c *rtspConn) OnResponse(res *base.Response) {
-	c.log(logger.Debug, "[s->c] %v", res)
+	c.Log(logger.Debug, "[s->c] %v", res)
 }
 
 // onDescribe is called by rtspServer.
@@ -278,7 +278,7 @@ func (c *rtspConn) onDescribe(ctx *gortsplib.ServerHandlerOnDescribeCtx,
 	if res.err != nil {
 		switch terr := res.err.(type) {
 		case pathErrAuthNotCritical:
-			c.log(logger.Debug, "non-critical authentication error: %s", terr.message)
+			c.Log(logger.Debug, "non-critical authentication error: %s", terr.message)
 			return terr.response, nil, nil
 
 		case pathErrAuthCritical:

internal/core/rtsp_server.go

@@ -56,7 +56,7 @@ type rtspServerAPISessionsKickRes struct {
 }
 
 type rtspServerParent interface {
-	Log(logger.Level, string, ...interface{})
+	logger.Writer
 }
 
 func printAddresses(srv *gortsplib.Server) string {
@@ -180,7 +180,7 @@ func newRTSPServer(
 		return nil, err
 	}
 
-	s.log(logger.Info, "listener opened on %s", printAddresses(s.srv))
+	s.Log(logger.Info, "listener opened on %s", printAddresses(s.srv))
 
 	if metrics != nil {
 		if !isTLS {
@@ -196,7 +196,7 @@ func newRTSPServer(
 	return s, nil
 }
 
-func (s *rtspServer) log(level logger.Level, format string, args ...interface{}) {
+func (s *rtspServer) Log(level logger.Level, format string, args ...interface{}) {
 	label := func() string {
 		if s.isTLS {
 			return "RTSPS"
@@ -207,7 +207,7 @@ func (s *rtspServer) log(level logger.Level, format string, args ...interface{})
 }
 
 func (s *rtspServer) close() {
-	s.log(logger.Info, "listener is closing")
+	s.Log(logger.Info, "listener is closing")
 	s.ctxCancel()
 	s.wg.Wait()
 }
@@ -223,7 +223,7 @@ func (s *rtspServer) run() {
 outer:
 	select {
 	case err := <-serverErr:
-		s.log(logger.Error, "%s", err)
+		s.Log(logger.Error, "%s", err)
 		break outer
 
 	case <-s.ctx.Done():

internal/core/rtsp_session.go

@@ -26,69 +26,69 @@ const (
 	pauseAfterAuthError = 2 * time.Second
 )
 
-type rtspWriteFunc func(*rtp.Packet) error
+type rtspWriteFunc func(*rtp.Packet)
 
 func getRTSPWriteFunc(medi *media.Media, forma formats.Format, stream *stream) rtspWriteFunc {
 	switch forma.(type) {
 	case *formats.H264:
-		return func(pkt *rtp.Packet) error {
-			return stream.writeUnit(medi, forma, &formatprocessor.UnitH264{
+		return func(pkt *rtp.Packet) {
+			stream.writeUnit(medi, forma, &formatprocessor.UnitH264{
 				RTPPackets: []*rtp.Packet{pkt},
 				NTP:        time.Now(),
 			})
 		}
 
 	case *formats.H265:
-		return func(pkt *rtp.Packet) error {
-			return stream.writeUnit(medi, forma, &formatprocessor.UnitH265{
+		return func(pkt *rtp.Packet) {
+			stream.writeUnit(medi, forma, &formatprocessor.UnitH265{
 				RTPPackets: []*rtp.Packet{pkt},
 				NTP:        time.Now(),
 			})
 		}
 
 	case *formats.VP8:
-		return func(pkt *rtp.Packet) error {
-			return stream.writeUnit(medi, forma, &formatprocessor.UnitVP8{
+		return func(pkt *rtp.Packet) {
+			stream.writeUnit(medi, forma, &formatprocessor.UnitVP8{
 				RTPPackets: []*rtp.Packet{pkt},
 				NTP:        time.Now(),
 			})
 		}
 
 	case *formats.VP9:
-		return func(pkt *rtp.Packet) error {
-			return stream.writeUnit(medi, forma, &formatprocessor.UnitVP9{
+		return func(pkt *rtp.Packet) {
+			stream.writeUnit(medi, forma, &formatprocessor.UnitVP9{
 				RTPPackets: []*rtp.Packet{pkt},
 				NTP:        time.Now(),
 			})
 		}
 
 	case *formats.MPEG2Audio:
-		return func(pkt *rtp.Packet) error {
-			return stream.writeUnit(medi, forma, &formatprocessor.UnitMPEG2Audio{
+		return func(pkt *rtp.Packet) {
+			stream.writeUnit(medi, forma, &formatprocessor.UnitMPEG2Audio{
 				RTPPackets: []*rtp.Packet{pkt},
 				NTP:        time.Now(),
 			})
 		}
 
 	case *formats.MPEG4Audio:
-		return func(pkt *rtp.Packet) error {
-			return stream.writeUnit(medi, forma, &formatprocessor.UnitMPEG4Audio{
+		return func(pkt *rtp.Packet) {
+			stream.writeUnit(medi, forma, &formatprocessor.UnitMPEG4Audio{
 				RTPPackets: []*rtp.Packet{pkt},
 				NTP:        time.Now(),
 			})
 		}
 
 	case *formats.Opus:
-		return func(pkt *rtp.Packet) error {
-			return stream.writeUnit(medi, forma, &formatprocessor.UnitOpus{
+		return func(pkt *rtp.Packet) {
+			stream.writeUnit(medi, forma, &formatprocessor.UnitOpus{
 				RTPPackets: []*rtp.Packet{pkt},
 				NTP:        time.Now(),
 			})
 		}
 
 	default:
-		return func(pkt *rtp.Packet) error {
-			return stream.writeUnit(medi, forma, &formatprocessor.UnitGeneric{
+		return func(pkt *rtp.Packet) {
+			stream.writeUnit(medi, forma, &formatprocessor.UnitGeneric{
 				RTPPackets: []*rtp.Packet{pkt},
 				NTP:        time.Now(),
 			})
@@ -102,7 +102,7 @@ type rtspSessionPathManager interface {
 }
 
 type rtspSessionParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 }
 
 type rtspSession struct {
@@ -144,7 +144,7 @@ func newRTSPSession(
 		created:         time.Now(),
 	}
 
-	s.log(logger.Info, "created by %v", s.author.NetConn().RemoteAddr())
+	s.Log(logger.Info, "created by %v", s.author.NetConn().RemoteAddr())
 
 	return s
 }
@@ -164,9 +164,9 @@ func (s *rtspSession) remoteAddr() net.Addr {
 	return s.author.NetConn().RemoteAddr()
 }
 
-func (s *rtspSession) log(level logger.Level, format string, args ...interface{}) {
+func (s *rtspSession) Log(level logger.Level, format string, args ...interface{}) {
 	id := hex.EncodeToString(s.uuid[:4])
-	s.parent.log(level, "[session %s] "+format, append([]interface{}{id}, args...)...)
+	s.parent.Log(level, "[session %s] "+format, append([]interface{}{id}, args...)...)
 }
 
 // onClose is called by rtspServer.
@@ -175,7 +175,7 @@ func (s *rtspSession) onClose(err error) {
 		if s.onReadCmd != nil {
 			s.onReadCmd.Close()
 			s.onReadCmd = nil
-			s.log(logger.Info, "runOnRead command stopped")
+			s.Log(logger.Info, "runOnRead command stopped")
 		}
 	}
 
@@ -190,7 +190,7 @@ func (s *rtspSession) onClose(err error) {
 	s.path = nil
 	s.stream = nil
 
-	s.log(logger.Info, "destroyed (%v)", err)
+	s.Log(logger.Info, "destroyed (%v)", err)
 }
 
 // onAnnounce is called by rtspServer.
@@ -217,7 +217,7 @@ func (s *rtspSession) onAnnounce(c *rtspConn, ctx *gortsplib.ServerHandlerOnAnno
 	if res.err != nil {
 		switch terr := res.err.(type) {
 		case pathErrAuthNotCritical:
-			s.log(logger.Debug, "non-critical authentication error: %s", terr.message)
+			s.Log(logger.Debug, "non-critical authentication error: %s", terr.message)
 			return terr.response, nil
 
 		case pathErrAuthCritical:
@@ -296,7 +296,7 @@ func (s *rtspSession) onSetup(c *rtspConn, ctx *gortsplib.ServerHandlerOnSetupCt
 		if res.err != nil {
 			switch terr := res.err.(type) {
 			case pathErrAuthNotCritical:
-				s.log(logger.Debug, "non-critical authentication error: %s", terr.message)
+				s.Log(logger.Debug, "non-critical authentication error: %s", terr.message)
 				return terr.response, nil, nil
 
 			case pathErrAuthCritical:
@@ -340,7 +340,7 @@ func (s *rtspSession) onPlay(ctx *gortsplib.ServerHandlerOnPlayCtx) (*base.Respo
 	h := make(base.Header)
 
 	if s.session.State() == gortsplib.ServerSessionStatePrePlay {
-		s.log(logger.Info, "is reading from path '%s', with %s, %s",
+		s.Log(logger.Info, "is reading from path '%s', with %s, %s",
 			s.path.name,
 			s.session.SetuppedTransport(),
 			sourceMediaInfo(s.session.SetuppedMedias()))
@@ -348,14 +348,14 @@ func (s *rtspSession) onPlay(ctx *gortsplib.ServerHandlerOnPlayCtx) (*base.Respo
 		pathConf := s.path.safeConf()
 
 		if pathConf.RunOnRead != "" {
-			s.log(logger.Info, "runOnRead command started")
+			s.Log(logger.Info, "runOnRead command started")
 			s.onReadCmd = externalcmd.NewCmd(
 				s.externalCmdPool,
 				pathConf.RunOnRead,
 				pathConf.RunOnReadRestart,
 				s.path.externalCmdEnv(),
 				func(co int) {
-					s.log(logger.Info, "runOnRead command exited with code %d", co)
+					s.Log(logger.Info, "runOnRead command exited with code %d", co)
 				})
 		}
 
@@ -383,7 +383,7 @@ func (s *rtspSession) onRecord(ctx *gortsplib.ServerHandlerOnRecordCtx) (*base.R
 		}, res.err
 	}
 
-	s.log(logger.Info, "is publishing to path '%s', with %s, %s",
+	s.Log(logger.Info, "is publishing to path '%s', with %s, %s",
 		s.path.name,
 		s.session.SetuppedTransport(),
 		sourceMediaInfo(s.session.AnnouncedMedias()))
@@ -395,10 +395,7 @@ func (s *rtspSession) onRecord(ctx *gortsplib.ServerHandlerOnRecordCtx) (*base.R
 			writeFunc := getRTSPWriteFunc(medi, forma, s.stream)
 
 			ctx.Session.OnPacketRTP(medi, forma, func(pkt *rtp.Packet) {
-				err := writeFunc(pkt)
-				if err != nil {
-					s.log(logger.Warn, "%v", err)
-				}
+				writeFunc(pkt)
 			})
 		}
 	}
@@ -417,7 +414,7 @@ func (s *rtspSession) onPause(ctx *gortsplib.ServerHandlerOnPauseCtx) (*base.Res
 	switch s.session.State() {
 	case gortsplib.ServerSessionStatePlay:
 		if s.onReadCmd != nil {
-			s.log(logger.Info, "runOnRead command stopped")
+			s.Log(logger.Info, "runOnRead command stopped")
 			s.onReadCmd.Close()
 		}
 
@@ -470,10 +467,10 @@ func (s *rtspSession) apiSourceDescribe() interface{} {
 
 // onPacketLost is called by rtspServer.
 func (s *rtspSession) onPacketLost(ctx *gortsplib.ServerHandlerOnPacketLostCtx) {
-	s.log(logger.Warn, ctx.Error.Error())
+	s.Log(logger.Warn, ctx.Error.Error())
 }
 
 // onDecodeError is called by rtspServer.
 func (s *rtspSession) onDecodeError(ctx *gortsplib.ServerHandlerOnDecodeErrorCtx) {
-	s.log(logger.Warn, ctx.Error.Error())
+	s.Log(logger.Warn, ctx.Error.Error())
 }

internal/core/rtsp_source.go

@@ -19,7 +19,7 @@ import (
 )
 
 type rtspSourceParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 	sourceStaticImplSetReady(req pathSourceStaticSetReadyReq) pathSourceStaticSetReadyRes
 	sourceStaticImplSetNotReady(req pathSourceStaticSetNotReadyReq)
 }
@@ -46,7 +46,7 @@ func newRTSPSource(
 }
 
 func (s *rtspSource) Log(level logger.Level, format string, args ...interface{}) {
-	s.parent.log(level, "[rtsp source] "+format, args...)
+	s.parent.Log(level, "[rtsp source] "+format, args...)
 }
 
 // run implements sourceStaticImpl.
@@ -140,10 +140,7 @@ func (s *rtspSource) run(ctx context.Context, cnf *conf.PathConf, reloadConf cha
 					writeFunc := getRTSPWriteFunc(medi, forma, res.stream)
 
 					c.OnPacketRTP(medi, forma, func(pkt *rtp.Packet) {
-						err := writeFunc(pkt)
-						if err != nil {
-							s.Log(logger.Warn, "%v", err)
-						}
+						writeFunc(pkt)
 					})
 				}
 			}

internal/core/source.go

@@ -5,6 +5,8 @@ import (
 	"strings"
 
 	"github.com/bluenviron/gortsplib/v3/pkg/media"
+
+	"github.com/aler9/mediamtx/internal/logger"
 )
 
 // source is an entity that can provide a stream.
@@ -13,6 +15,7 @@ import (
 // - sourceStatic
 // - sourceRedirect
 type source interface {
+	logger.Writer
 	apiSourceDescribe() interface{}
 }
 

internal/core/source_redirect.go

@@ -1,8 +1,15 @@
 package core
 
+import (
+	"github.com/aler9/mediamtx/internal/logger"
+)
+
 // sourceRedirect is a source that redirects to another one.
 type sourceRedirect struct{}
 
+func (*sourceRedirect) Log(logger.Level, string, ...interface{}) {
+}
+
 // apiSourceDescribe implements source.
 func (*sourceRedirect) apiSourceDescribe() interface{} {
 	return struct {

internal/core/source_static.go

@@ -15,13 +15,13 @@ const (
 )
 
 type sourceStaticImpl interface {
-	Log(logger.Level, string, ...interface{})
+	logger.Writer
 	run(context.Context, *conf.PathConf, chan *conf.PathConf) error
 	apiSourceDescribe() interface{}
 }
 
 type sourceStaticParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 	sourceStaticSetReady(context.Context, pathSourceStaticSetReadyReq)
 	sourceStaticSetNotReady(context.Context, pathSourceStaticSetNotReadyReq)
 }
@@ -128,8 +128,8 @@ func (s *sourceStatic) stop() {
 	<-s.done
 }
 
-func (s *sourceStatic) log(level logger.Level, format string, args ...interface{}) {
-	s.parent.log(level, format, args...)
+func (s *sourceStatic) Log(level logger.Level, format string, args ...interface{}) {
+	s.parent.Log(level, format, args...)
 }
 
 func (s *sourceStatic) run() {

internal/core/stream.go

@@ -10,8 +10,9 @@ import (
 
 type stream struct {
 	bytesReceived *uint64
-	rtspStream    *gortsplib.ServerStream
-	smedias       map[*media.Media]*streamMedia
+
+	rtspStream *gortsplib.ServerStream
+	smedias    map[*media.Media]*streamMedia
 }
 
 func newStream(
@@ -19,6 +20,7 @@ func newStream(
 	medias media.Medias,
 	generateRTPPackets bool,
 	bytesReceived *uint64,
+	source source,
 ) (*stream, error) {
 	s := &stream{
 		bytesReceived: bytesReceived,
@@ -29,7 +31,7 @@ func newStream(
 
 	for _, media := range s.rtspStream.Medias() {
 		var err error
-		s.smedias[media], err = newStreamMedia(udpMaxPayloadSize, media, generateRTPPackets)
+		s.smedias[media], err = newStreamMedia(udpMaxPayloadSize, media, generateRTPPackets, source)
 		if err != nil {
 			return nil, err
 		}
@@ -60,8 +62,8 @@ func (s *stream) readerRemove(r reader) {
 	}
 }
 
-func (s *stream) writeUnit(medi *media.Media, forma formats.Format, data formatprocessor.Unit) error {
+func (s *stream) writeUnit(medi *media.Media, forma formats.Format, data formatprocessor.Unit) {
 	sm := s.smedias[medi]
 	sf := sm.formats[forma]
-	return sf.writeUnit(s, medi, data)
+	sf.writeUnit(s, medi, data)
 }

internal/core/stream_format.go

@@ -8,9 +8,11 @@ import (
 	"github.com/bluenviron/gortsplib/v3/pkg/media"
 
 	"github.com/aler9/mediamtx/internal/formatprocessor"
+	"github.com/aler9/mediamtx/internal/logger"
 )
 
 type streamFormat struct {
+	source         source
 	proc           formatprocessor.Processor
 	mutex          sync.RWMutex
 	nonRTSPReaders map[reader]func(formatprocessor.Unit)
@@ -20,13 +22,15 @@ func newStreamFormat(
 	udpMaxPayloadSize int,
 	forma formats.Format,
 	generateRTPPackets bool,
+	source source,
 ) (*streamFormat, error) {
-	proc, err := formatprocessor.New(udpMaxPayloadSize, forma, generateRTPPackets)
+	proc, err := formatprocessor.New(udpMaxPayloadSize, forma, generateRTPPackets, source)
 	if err != nil {
 		return nil, err
 	}
 
 	sf := &streamFormat{
+		source:         source,
 		proc:           proc,
 		nonRTSPReaders: make(map[reader]func(formatprocessor.Unit)),
 	}
@@ -46,7 +50,7 @@ func (sf *streamFormat) readerRemove(r reader) {
 	delete(sf.nonRTSPReaders, r)
 }
 
-func (sf *streamFormat) writeUnit(s *stream, medi *media.Media, data formatprocessor.Unit) error {
+func (sf *streamFormat) writeUnit(s *stream, medi *media.Media, data formatprocessor.Unit) {
 	sf.mutex.RLock()
 	defer sf.mutex.RUnlock()
 
@@ -54,7 +58,8 @@ func (sf *streamFormat) writeUnit(s *stream, medi *media.Media, data formatproce
 
 	err := sf.proc.Process(data, hasNonRTSPReaders)
 	if err != nil {
-		return err
+		sf.source.Log(logger.Warn, err.Error())
+		return
 	}
 
 	// forward RTP packets to RTSP readers
@@ -67,6 +72,4 @@ func (sf *streamFormat) writeUnit(s *stream, medi *media.Media, data formatproce
 	for _, cb := range sf.nonRTSPReaders {
 		cb(data)
 	}
-
-	return nil
 }

internal/core/stream_media.go

@@ -12,6 +12,7 @@ type streamMedia struct {
 func newStreamMedia(udpMaxPayloadSize int,
 	medi *media.Media,
 	generateRTPPackets bool,
+	source source,
 ) (*streamMedia, error) {
 	sm := &streamMedia{
 		formats: make(map[formats.Format]*streamFormat),
@@ -19,7 +20,7 @@ func newStreamMedia(udpMaxPayloadSize int,
 
 	for _, forma := range medi.Formats {
 		var err error
-		sm.formats[forma], err = newStreamFormat(udpMaxPayloadSize, forma, generateRTPPackets)
+		sm.formats[forma], err = newStreamFormat(udpMaxPayloadSize, forma, generateRTPPackets, source)
 		if err != nil {
 			return nil, err
 		}

internal/core/udp_source.go

@@ -97,7 +97,7 @@ func (r *packetConnReader) Read(p []byte) (int, error) {
 }
 
 type udpSourceParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 	sourceStaticImplSetReady(req pathSourceStaticSetReadyReq) pathSourceStaticSetReadyRes
 	sourceStaticImplSetNotReady(req pathSourceStaticSetNotReadyReq)
 }
@@ -118,7 +118,7 @@ func newUDPSource(
 }
 
 func (s *udpSource) Log(level logger.Level, format string, args ...interface{}) {
-	s.parent.log(level, "[udp source] "+format, args...)
+	s.parent.Log(level, "[udp source] "+format, args...)
 }
 
 // run implements sourceStaticImpl.
@@ -196,14 +196,11 @@ func (s *udpSource) run(ctx context.Context, cnf *conf.PathConf, reloadConf chan
 							return
 						}
 
-						err = stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitH264{
+						stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitH264{
 							PTS: pts,
 							AU:  au,
 							NTP: time.Now(),
 						})
-						if err != nil {
-							s.Log(logger.Warn, "%v", err)
-						}
 					}
 
 				case *mpegts.CodecH265:
@@ -221,14 +218,11 @@ func (s *udpSource) run(ctx context.Context, cnf *conf.PathConf, reloadConf chan
 							return
 						}
 
-						err = stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitH265{
+						stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitH265{
 							PTS: pts,
 							AU:  au,
 							NTP: time.Now(),
 						})
-						if err != nil {
-							s.Log(logger.Warn, "%v", err)
-						}
 					}
 
 				case *mpegts.CodecMPEG4Audio:
@@ -256,14 +250,11 @@ func (s *udpSource) run(ctx context.Context, cnf *conf.PathConf, reloadConf chan
 							aus[i] = pkt.AU
 						}
 
-						err = stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitMPEG4Audio{
+						stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitMPEG4Audio{
 							PTS: pts,
 							AUs: aus,
 							NTP: time.Now(),
 						})
-						if err != nil {
-							s.Log(logger.Warn, "%v", err)
-						}
 					}
 
 				case *mpegts.CodecOpus:
@@ -287,14 +278,11 @@ func (s *udpSource) run(ctx context.Context, cnf *conf.PathConf, reloadConf chan
 							}
 							pos += n
 
-							err = stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitOpus{
+							stream.writeUnit(medi, medi.Formats[0], &formatprocessor.UnitOpus{
 								PTS:   pts,
 								Frame: au.Frame,
 								NTP:   time.Now(),
 							})
-							if err != nil {
-								s.Log(logger.Warn, "%v", err)
-							}
 
 							if len(data[pos:]) == 0 {
 								break

internal/core/webrtc_conn.go

@@ -84,7 +84,7 @@ type webRTCConnPathManager interface {
 }
 
 type webRTCConnParent interface {
-	log(logger.Level, string, ...interface{})
+	logger.Writer
 	connClose(*webRTCConn)
 }
 
@@ -143,7 +143,7 @@ func newWebRTCConn(
 		closed:            make(chan struct{}),
 	}
 
-	c.log(logger.Info, "opened")
+	c.Log(logger.Info, "opened")
 
 	wg.Add(1)
 	go c.run()
@@ -252,8 +252,8 @@ func (c *webRTCConn) bytesSent() uint64 {
 	return 0
 }
 
-func (c *webRTCConn) log(level logger.Level, format string, args ...interface{}) {
-	c.parent.log(level, "[conn %v] "+format, append([]interface{}{c.wsconn.RemoteAddr()}, args...)...)
+func (c *webRTCConn) Log(level logger.Level, format string, args ...interface{}) {
+	c.parent.Log(level, "[conn %v] "+format, append([]interface{}{c.wsconn.RemoteAddr()}, args...)...)
 }
 
 func (c *webRTCConn) run() {
@@ -281,7 +281,7 @@ func (c *webRTCConn) run() {
 
 	c.parent.connClose(c)
 
-	c.log(logger.Info, "closed (%v)", err)
+	c.Log(logger.Info, "closed (%v)", err)
 }
 
 func (c *webRTCConn) runInner(ctx context.Context) error {
@@ -377,7 +377,7 @@ func (c *webRTCConn) runInner(ctx context.Context) error {
 		default:
 		}
 
-		c.log(logger.Debug, "peer connection state: "+state.String())
+		c.Log(logger.Debug, "peer connection state: "+state.String())
 
 		switch state {
 		case webrtc.PeerConnectionStateConnected:
@@ -475,14 +475,14 @@ outer:
 	for {
 		select {
 		case candidate := <-localCandidate:
-			c.log(logger.Debug, "local candidate: %+v", candidate.Candidate)
+			c.Log(logger.Debug, "local candidate: %+v", candidate.Candidate)
 			err := c.wsconn.WriteJSON(candidate)
 			if err != nil {
 				return err
 			}
 
 		case candidate := <-remoteCandidate:
-			c.log(logger.Debug, "remote candidate: %+v", candidate.Candidate)
+			c.Log(logger.Debug, "remote candidate: %+v", candidate.Candidate)
 			err := pc.AddICECandidate(*candidate)
 			if err != nil {
 				return err
@@ -512,7 +512,7 @@ outer:
 	c.curPC = pc
 	c.mutex.Unlock()
 
-	c.log(logger.Info, "peer connection established, local candidate: %v, remote candidate: %v",
+	c.Log(logger.Info, "peer connection established, local candidate: %v, remote candidate: %v",
 		c.localCandidate(), c.remoteCandidate())
 
 	ringBuffer, _ := ringbuffer.New(uint64(c.readBufferCount))
@@ -530,7 +530,7 @@ outer:
 	}
 	defer res.stream.readerRemove(c)
 
-	c.log(logger.Info, "is reading from path '%s', %s",
+	c.Log(logger.Info, "is reading from path '%s', %s",
 		path.name, sourceMediaInfo(gatherMedias(tracks)))
 
 	go func() {

internal/core/webrtc_server.go

@@ -64,7 +64,7 @@ type webRTCConnNewReq struct {
 }
 
 type webRTCServerParent interface {
-	Log(logger.Level, string, ...interface{})
+	logger.Writer
 }
 
 type webRTCServer struct {
@@ -204,7 +204,7 @@ func newWebRTCServer(
 	if tcpMuxLn != nil {
 		str += ", " + iceTCPMuxAddress + " (ICE/TCP)"
 	}
-	s.log(logger.Info, str)
+	s.Log(logger.Info, str)
 
 	if s.metrics != nil {
 		s.metrics.webRTCServerSet(s)
@@ -216,12 +216,12 @@ func newWebRTCServer(
 }
 
 // Log is the main logging function.
-func (s *webRTCServer) log(level logger.Level, format string, args ...interface{}) {
+func (s *webRTCServer) Log(level logger.Level, format string, args ...interface{}) {
 	s.parent.Log(level, "[WebRTC] "+format, append([]interface{}{}, args...)...)
 }
 
 func (s *webRTCServer) close() {
-	s.log(logger.Info, "listener is closing")
+	s.Log(logger.Info, "listener is closing")
 	s.ctxCancel()
 	<-s.done
 }
@@ -369,7 +369,7 @@ func (s *webRTCServer) onRequest(ctx *gin.Context) {
 	err := s.authenticate(res.path, ctx)
 	if err != nil {
 		if terr, ok := err.(pathErrAuthCritical); ok {
-			s.log(logger.Info, "authentication error: %s", terr.message)
+			s.Log(logger.Info, "authentication error: %s", terr.message)
 			ctx.Writer.Header().Set("WWW-Authenticate", `Basic realm="mediamtx"`)
 			ctx.Writer.WriteHeader(http.StatusUnauthorized)
 			return

internal/formatprocessor/generic.go

@@ -6,6 +6,8 @@ import (
 
 	"github.com/bluenviron/gortsplib/v3/pkg/formats"
 	"github.com/pion/rtp"
+
+	"github.com/aler9/mediamtx/internal/logger"
 )
 
 // UnitGeneric is a generic data unit.
@@ -32,6 +34,7 @@ func newGeneric(
 	udpMaxPayloadSize int,
 	forma formats.Format,
 	generateRTPPackets bool,
+	log logger.Writer,
 ) (*formatProcessorGeneric, error) {
 	if generateRTPPackets {
 		return nil, fmt.Errorf("we don't know how to generate RTP packets of format %+v", forma)

internal/formatprocessor/generic_test.go

@@ -15,7 +15,7 @@ func TestGenericRemovePadding(t *testing.T) {
 	}
 	forma.Init()
 
-	p, err := New(1472, forma, false)
+	p, err := New(1472, forma, false, nil)
 	require.NoError(t, err)
 
 	pkt := &rtp.Packet{

internal/formatprocessor/h264.go

@@ -8,6 +8,8 @@ import (
 	"github.com/bluenviron/gortsplib/v3/pkg/formats/rtph264"
 	"github.com/bluenviron/mediacommon/pkg/codecs/h264"
 	"github.com/pion/rtp"
+
+	"github.com/aler9/mediamtx/internal/logger"
 )
 
 // extract SPS and PPS without decoding RTP packets
@@ -88,28 +90,33 @@ func (d *UnitH264) GetNTP() time.Time {
 type formatProcessorH264 struct {
 	udpMaxPayloadSize int
 	format            *formats.H264
+	log               logger.Writer
 
-	encoder *rtph264.Encoder
-	decoder *rtph264.Decoder
+	encoder              *rtph264.Encoder
+	decoder              *rtph264.Decoder
+	lastKeyFrameReceived time.Time
 }
 
 func newH264(
 	udpMaxPayloadSize int,
 	forma *formats.H264,
-	allocateEncoder bool,
+	generateRTPPackets bool,
+	log logger.Writer,
 ) (*formatProcessorH264, error) {
 	t := &formatProcessorH264{
 		udpMaxPayloadSize: udpMaxPayloadSize,
 		format:            forma,
+		log:               log,
 	}
 
-	if allocateEncoder {
+	if generateRTPPackets {
 		t.encoder = &rtph264.Encoder{
 			PayloadMaxSize:    udpMaxPayloadSize - 12,
 			PayloadType:       forma.PayloadTyp,
 			PacketizationMode: forma.PacketizationMode,
 		}
 		t.encoder.Init()
+		t.lastKeyFrameReceived = time.Now()
 	}
 
 	return t, nil
@@ -166,24 +173,37 @@ func (t *formatProcessorH264) updateTrackParametersFromNALUs(nalus [][]byte) {
 	}
 }
 
+func (t *formatProcessorH264) checkKeyFrameInterval(isKeyFrame bool) {
+	if isKeyFrame {
+		t.lastKeyFrameReceived = time.Now()
+	} else {
+		now := time.Now()
+		if now.Sub(t.lastKeyFrameReceived) >= maxKeyFrameInterval {
+			t.lastKeyFrameReceived = now
+			t.log.Log(logger.Warn, "no key frames received in %v, stream can't be decoded")
+		}
+	}
+}
+
 func (t *formatProcessorH264) remuxAccessUnit(nalus [][]byte) [][]byte {
-	addParameters := false
+	isKeyFrame := false
 	n := 0
 
 	for _, nalu := range nalus {
 		typ := h264.NALUType(nalu[0] & 0x1F)
 
 		switch typ {
-		case h264.NALUTypeSPS, h264.NALUTypePPS: // remove parameters
+		case h264.NALUTypeSPS, h264.NALUTypePPS: // parameters: remove
 			continue
 
-		case h264.NALUTypeAccessUnitDelimiter: // remove AUDs
+		case h264.NALUTypeAccessUnitDelimiter: // AUD: remove
 			continue
 
-		case h264.NALUTypeIDR: // prepend parameters if there's at least an IDR
-			if !addParameters {
-				addParameters = true
+		case h264.NALUTypeIDR: // key frame
+			if !isKeyFrame {
+				isKeyFrame = true
 
+				// prepend parameters
 				if t.format.SPS != nil && t.format.PPS != nil {
 					n += 2
 				}
@@ -192,6 +212,8 @@ func (t *formatProcessorH264) remuxAccessUnit(nalus [][]byte) [][]byte {
 		n++
 	}
 
+	t.checkKeyFrameInterval(isKeyFrame)
+
 	if n == 0 {
 		return nil
 	}
@@ -199,7 +221,7 @@ func (t *formatProcessorH264) remuxAccessUnit(nalus [][]byte) [][]byte {
 	filteredNALUs := make([][]byte, n)
 	i := 0
 
-	if addParameters && t.format.SPS != nil && t.format.PPS != nil {
+	if isKeyFrame && t.format.SPS != nil && t.format.PPS != nil {
 		filteredNALUs[0] = t.format.SPS
 		filteredNALUs[1] = t.format.PPS
 		i = 2
@@ -256,6 +278,7 @@ func (t *formatProcessorH264) Process(unit Unit, hasNonRTSPReaders bool) error {
 		if hasNonRTSPReaders || t.encoder != nil {
 			if t.decoder == nil {
 				t.decoder = t.format.CreateDecoder()
+				t.lastKeyFrameReceived = time.Now()
 			}
 
 			if t.encoder != nil {
@@ -271,9 +294,8 @@ func (t *formatProcessorH264) Process(unit Unit, hasNonRTSPReaders bool) error {
 				return err
 			}
 
-			tunit.AU = au
+			tunit.AU = t.remuxAccessUnit(au)
 			tunit.PTS = pts
-			tunit.AU = t.remuxAccessUnit(tunit.AU)
 		}
 
 		// route packet as is

internal/formatprocessor/h264_test.go

@@ -16,7 +16,7 @@ func TestH264DynamicParams(t *testing.T) {
 		PacketizationMode: 1,
 	}
 
-	p, err := New(1472, forma, false)
+	p, err := New(1472, forma, false, nil)
 	require.NoError(t, err)
 
 	enc := forma.CreateEncoder()
@@ -61,7 +61,7 @@ func TestH264OversizedPackets(t *testing.T) {
 		PacketizationMode: 1,
 	}
 
-	p, err := New(1472, forma, false)
+	p, err := New(1472, forma, false, nil)
 	require.NoError(t, err)
 
 	var out []*rtp.Packet
@@ -158,7 +158,7 @@ func TestH264EmptyPacket(t *testing.T) {
 		PacketizationMode: 1,
 	}
 
-	p, err := New(1472, forma, true)
+	p, err := New(1472, forma, true, nil)
 	require.NoError(t, err)
 
 	unit := &UnitH264{

internal/formatprocessor/h265.go

@@ -8,6 +8,8 @@ import (
 	"github.com/bluenviron/gortsplib/v3/pkg/formats/rtph265"
 	"github.com/bluenviron/mediacommon/pkg/codecs/h265"
 	"github.com/pion/rtp"
+
+	"github.com/aler9/mediamtx/internal/logger"
 )
 
 // extract VPS, SPS and PPS without decoding RTP packets
@@ -95,27 +97,32 @@ func (d *UnitH265) GetNTP() time.Time {
 type formatProcessorH265 struct {
 	udpMaxPayloadSize int
 	format            *formats.H265
+	log               logger.Writer
 
-	encoder *rtph265.Encoder
-	decoder *rtph265.Decoder
+	encoder              *rtph265.Encoder
+	decoder              *rtph265.Decoder
+	lastKeyFrameReceived time.Time
 }
 
 func newH265(
 	udpMaxPayloadSize int,
 	forma *formats.H265,
-	allocateEncoder bool,
+	generateRTPPackets bool,
+	log logger.Writer,
 ) (*formatProcessorH265, error) {
 	t := &formatProcessorH265{
 		udpMaxPayloadSize: udpMaxPayloadSize,
 		format:            forma,
+		log:               log,
 	}
 
-	if allocateEncoder {
+	if generateRTPPackets {
 		t.encoder = &rtph265.Encoder{
 			PayloadMaxSize: t.udpMaxPayloadSize - 12,
 			PayloadType:    forma.PayloadTyp,
 		}
 		t.encoder.Init()
+		t.lastKeyFrameReceived = time.Now()
 	}
 
 	return t, nil
@@ -186,25 +193,37 @@ func (t *formatProcessorH265) updateTrackParametersFromNALUs(nalus [][]byte) {
 	}
 }
 
+func (t *formatProcessorH265) checkKeyFrameInterval(isKeyFrame bool) {
+	if isKeyFrame {
+		t.lastKeyFrameReceived = time.Now()
+	} else {
+		now := time.Now()
+		if now.Sub(t.lastKeyFrameReceived) >= maxKeyFrameInterval {
+			t.lastKeyFrameReceived = now
+			t.log.Log(logger.Warn, "no key frames received in %v, stream can't be decoded")
+		}
+	}
+}
+
 func (t *formatProcessorH265) remuxAccessUnit(nalus [][]byte) [][]byte {
-	addParameters := false
+	isKeyFrame := false
 	n := 0
 
 	for _, nalu := range nalus {
 		typ := h265.NALUType((nalu[0] >> 1) & 0b111111)
 
 		switch typ {
-		case h265.NALUType_VPS_NUT, h265.NALUType_SPS_NUT, h265.NALUType_PPS_NUT: // remove parameters
+		case h265.NALUType_VPS_NUT, h265.NALUType_SPS_NUT, h265.NALUType_PPS_NUT: // parameters: remove
 			continue
 
-		case h265.NALUType_AUD_NUT: // remove AUDs
+		case h265.NALUType_AUD_NUT: // AUD: remove
 			continue
 
-		// prepend parameters if there's at least a random access unit
-		case h265.NALUType_IDR_W_RADL, h265.NALUType_IDR_N_LP, h265.NALUType_CRA_NUT:
-			if !addParameters {
-				addParameters = true
+		case h265.NALUType_IDR_W_RADL, h265.NALUType_IDR_N_LP, h265.NALUType_CRA_NUT: // key frame
+			if !isKeyFrame {
+				isKeyFrame = true
 
+				// prepend parameters
 				if t.format.VPS != nil && t.format.SPS != nil && t.format.PPS != nil {
 					n += 3
 				}
@@ -213,6 +232,8 @@ func (t *formatProcessorH265) remuxAccessUnit(nalus [][]byte) [][]byte {
 		n++
 	}
 
+	t.checkKeyFrameInterval(isKeyFrame)
+
 	if n == 0 {
 		return nil
 	}
@@ -220,7 +241,7 @@ func (t *formatProcessorH265) remuxAccessUnit(nalus [][]byte) [][]byte {
 	filteredNALUs := make([][]byte, n)
 	i := 0
 
-	if addParameters && t.format.VPS != nil && t.format.SPS != nil && t.format.PPS != nil {
+	if isKeyFrame && t.format.VPS != nil && t.format.SPS != nil && t.format.PPS != nil {
 		filteredNALUs[0] = t.format.VPS
 		filteredNALUs[1] = t.format.SPS
 		filteredNALUs[2] = t.format.PPS
@@ -278,6 +299,7 @@ func (t *formatProcessorH265) Process(unit Unit, hasNonRTSPReaders bool) error {
 		if hasNonRTSPReaders || t.encoder != nil {
 			if t.decoder == nil {
 				t.decoder = t.format.CreateDecoder()
+				t.lastKeyFrameReceived = time.Now()
 			}
 
 			if t.encoder != nil {
@@ -293,9 +315,8 @@ func (t *formatProcessorH265) Process(unit Unit, hasNonRTSPReaders bool) error {
 				return err
 			}
 
-			tunit.AU = au
+			tunit.AU = t.remuxAccessUnit(au)
 			tunit.PTS = pts
-			tunit.AU = t.remuxAccessUnit(tunit.AU)
 		}
 
 		// route packet as is

internal/formatprocessor/h265_test.go

@@ -15,7 +15,7 @@ func TestH265DynamicParams(t *testing.T) {
 		PayloadTyp: 96,
 	}
 
-	p, err := New(1472, forma, false)
+	p, err := New(1472, forma, false, nil)
 	require.NoError(t, err)
 
 	enc := forma.CreateEncoder()
@@ -66,7 +66,7 @@ func TestH265OversizedPackets(t *testing.T) {
 		PPS:        []byte{byte(h265.NALUType_PPS_NUT) << 1, 16, 17, 18},
 	}
 
-	p, err := New(1472, forma, false)
+	p, err := New(1472, forma, false, nil)
 	require.NoError(t, err)
 
 	var out []*rtp.Packet
@@ -150,7 +150,7 @@ func TestH265EmptyPacket(t *testing.T) {
 		PayloadTyp: 96,
 	}
 
-	p, err := New(1472, forma, true)
+	p, err := New(1472, forma, true, nil)
 	require.NoError(t, err)
 
 	unit := &UnitH265{

internal/formatprocessor/mpeg2audio.go

@@ -7,6 +7,8 @@ import (
 	"github.com/bluenviron/gortsplib/v3/pkg/formats"
 	"github.com/bluenviron/gortsplib/v3/pkg/formats/rtpmpeg2audio"
 	"github.com/pion/rtp"
+
+	"github.com/aler9/mediamtx/internal/logger"
 )
 
 // UnitMPEG2Audio is a MPEG-2 Audio data unit.
@@ -37,14 +39,15 @@ type formatProcessorMPEG2Audio struct {
 func newMPEG2Audio(
 	udpMaxPayloadSize int,
 	forma *formats.MPEG2Audio,
-	allocateEncoder bool,
+	generateRTPPackets bool,
+	log logger.Writer,
 ) (*formatProcessorMPEG2Audio, error) {
 	t := &formatProcessorMPEG2Audio{
 		udpMaxPayloadSize: udpMaxPayloadSize,
 		format:            forma,
 	}
 
-	if allocateEncoder {
+	if generateRTPPackets {
 		t.encoder = &rtpmpeg2audio.Encoder{
 			PayloadMaxSize: t.udpMaxPayloadSize - 12,
 		}

internal/formatprocessor/mpeg4audio.go

@@ -7,6 +7,8 @@ import (
 	"github.com/bluenviron/gortsplib/v3/pkg/formats"
 	"github.com/bluenviron/gortsplib/v3/pkg/formats/rtpmpeg4audio"
 	"github.com/pion/rtp"
+
+	"github.com/aler9/mediamtx/internal/logger"
 )
 
 // UnitMPEG4Audio is a MPEG-4 Audio data unit.
@@ -37,14 +39,15 @@ type formatProcessorMPEG4Audio struct {
 func newMPEG4Audio(
 	udpMaxPayloadSize int,
 	forma *formats.MPEG4Audio,
-	allocateEncoder bool,
+	generateRTPPackets bool,
+	log logger.Writer,
 ) (*formatProcessorMPEG4Audio, error) {
 	t := &formatProcessorMPEG4Audio{
 		udpMaxPayloadSize: udpMaxPayloadSize,
 		format:            forma,
 	}
 
-	if allocateEncoder {
+	if generateRTPPackets {
 		t.encoder = &rtpmpeg4audio.Encoder{
 			PayloadMaxSize:   t.udpMaxPayloadSize - 12,
 			PayloadType:      forma.PayloadTyp,

internal/formatprocessor/opus.go

@@ -7,6 +7,8 @@ import (
 	"github.com/bluenviron/gortsplib/v3/pkg/formats"
 	"github.com/bluenviron/gortsplib/v3/pkg/formats/rtpsimpleaudio"
 	"github.com/pion/rtp"
+
+	"github.com/aler9/mediamtx/internal/logger"
 )
 
 // UnitOpus is a Opus data unit.
@@ -37,14 +39,15 @@ type formatProcessorOpus struct {
 func newOpus(
 	udpMaxPayloadSize int,
 	forma *formats.Opus,
-	allocateEncoder bool,
+	generateRTPPackets bool,
+	log logger.Writer,
 ) (*formatProcessorOpus, error) {
 	t := &formatProcessorOpus{
 		udpMaxPayloadSize: udpMaxPayloadSize,
 		format:            forma,
 	}
 
-	if allocateEncoder {
+	if generateRTPPackets {
 		t.encoder = &rtpsimpleaudio.Encoder{
 			PayloadMaxSize: t.udpMaxPayloadSize - 12,
 			PayloadType:    forma.PayloadTyp,

internal/formatprocessor/processor.go

@@ -2,12 +2,20 @@
 package formatprocessor
 
 import (
+	"time"
+
 	"github.com/bluenviron/gortsplib/v3/pkg/formats"
+
+	"github.com/aler9/mediamtx/internal/logger"
+)
+
+const (
+	maxKeyFrameInterval = 10 * time.Second
 )
 
-// Processor allows to cleanup and normalize streams.
+// Processor cleans and normalizes streams.
 type Processor interface {
-	// clears and normalizes a data unit.
+	// cleans and normalizes a data unit.
 	Process(Unit, bool) error
 }
 
@@ -16,30 +24,31 @@ func New(
 	udpMaxPayloadSize int,
 	forma formats.Format,
 	generateRTPPackets bool,
+	log logger.Writer,
 ) (Processor, error) {
 	switch forma := forma.(type) {
 	case *formats.H264:
-		return newH264(udpMaxPayloadSize, forma, generateRTPPackets)
+		return newH264(udpMaxPayloadSize, forma, generateRTPPackets, log)
 
 	case *formats.H265:
-		return newH265(udpMaxPayloadSize, forma, generateRTPPackets)
+		return newH265(udpMaxPayloadSize, forma, generateRTPPackets, log)
 
 	case *formats.VP8:
-		return newVP8(udpMaxPayloadSize, forma, generateRTPPackets)
+		return newVP8(udpMaxPayloadSize, forma, generateRTPPackets, log)
 
 	case *formats.VP9:
-		return newVP9(udpMaxPayloadSize, forma, generateRTPPackets)
+		return newVP9(udpMaxPayloadSize, forma, generateRTPPackets, log)
 
 	case *formats.MPEG2Audio:
-		return newMPEG2Audio(udpMaxPayloadSize, forma, generateRTPPackets)
+		return newMPEG2Audio(udpMaxPayloadSize, forma, generateRTPPackets, log)
 
 	case *formats.MPEG4Audio:
-		return newMPEG4Audio(udpMaxPayloadSize, forma, generateRTPPackets)
+		return newMPEG4Audio(udpMaxPayloadSize, forma, generateRTPPackets, log)
 
 	case *formats.Opus:
-		return newOpus(udpMaxPayloadSize, forma, generateRTPPackets)
+		return newOpus(udpMaxPayloadSize, forma, generateRTPPackets, log)
 
 	default:
-		return newGeneric(udpMaxPayloadSize, forma, generateRTPPackets)
+		return newGeneric(udpMaxPayloadSize, forma, generateRTPPackets, log)
 	}
 }

internal/formatprocessor/vp8.go

@@ -7,6 +7,8 @@ import (
 	"github.com/bluenviron/gortsplib/v3/pkg/formats"
 	"github.com/bluenviron/gortsplib/v3/pkg/formats/rtpvp8"
 	"github.com/pion/rtp"
+
+	"github.com/aler9/mediamtx/internal/logger"
 )
 
 // UnitVP8 is a VP8 data unit.
@@ -37,14 +39,15 @@ type formatProcessorVP8 struct {
 func newVP8(
 	udpMaxPayloadSize int,
 	forma *formats.VP8,
-	allocateEncoder bool,
+	generateRTPPackets bool,
+	log logger.Writer,
 ) (*formatProcessorVP8, error) {
 	t := &formatProcessorVP8{
 		udpMaxPayloadSize: udpMaxPayloadSize,
 		format:            forma,
 	}
 
-	if allocateEncoder {
+	if generateRTPPackets {
 		t.encoder = &rtpvp8.Encoder{
 			PayloadMaxSize: t.udpMaxPayloadSize - 12,
 			PayloadType:    forma.PayloadTyp,

internal/formatprocessor/vp9.go

@@ -7,6 +7,8 @@ import (
 	"github.com/bluenviron/gortsplib/v3/pkg/formats"
 	"github.com/bluenviron/gortsplib/v3/pkg/formats/rtpvp9"
 	"github.com/pion/rtp"
+
+	"github.com/aler9/mediamtx/internal/logger"
 )
 
 // UnitVP9 is a VP9 data unit.
@@ -37,14 +39,15 @@ type formatProcessorVP9 struct {
 func newVP9(
 	udpMaxPayloadSize int,
 	forma *formats.VP9,
-	allocateEncoder bool,
+	generateRTPPackets bool,
+	log logger.Writer,
 ) (*formatProcessorVP9, error) {
 	t := &formatProcessorVP9{
 		udpMaxPayloadSize: udpMaxPayloadSize,
 		format:            forma,
 	}
 
-	if allocateEncoder {
+	if generateRTPPackets {
 		t.encoder = &rtpvp9.Encoder{
 			PayloadMaxSize: t.udpMaxPayloadSize - 12,
 			PayloadType:    forma.PayloadTyp,

internal/logger/destination.go

@@ -0,0 +1,20 @@
+package logger
+
+// Destination is a log destination.
+type Destination int
+
+const (
+	// DestinationStdout writes logs to the standard output.
+	DestinationStdout Destination = iota
+
+	// DestinationFile writes logs to a file.
+	DestinationFile
+
+	// DestinationSyslog writes logs to the system logger.
+	DestinationSyslog
+)
+
+type destination interface {
+	log(Level, string, ...interface{})
+	close()
+}

internal/logger/destination_file.go

@@ -0,0 +1,34 @@
+package logger
+
+import (
+	"bytes"
+	"os"
+)
+
+type destinationFile struct {
+	file *os.File
+	buf  bytes.Buffer
+}
+
+func newDestinationFile(filePath string) (destination, error) {
+	f, err := os.OpenFile(filePath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0o644)
+	if err != nil {
+		return nil, err
+	}
+
+	return &destinationFile{
+		file: f,
+	}, nil
+}
+
+func (d *destinationFile) log(level Level, format string, args ...interface{}) {
+	d.buf.Reset()
+	writeTime(&d.buf, false)
+	writeLevel(&d.buf, level, false)
+	writeContent(&d.buf, format, args)
+	d.file.Write(d.buf.Bytes())
+}
+
+func (d *destinationFile) close() {
+	d.file.Close()
+}

internal/logger/destination_stdout.go

@@ -0,0 +1,25 @@
+package logger
+
+import (
+	"bytes"
+	"os"
+)
+
+type destinationStdout struct {
+	buf bytes.Buffer
+}
+
+func newDestionationStdout() destination {
+	return &destinationStdout{}
+}
+
+func (d *destinationStdout) log(level Level, format string, args ...interface{}) {
+	d.buf.Reset()
+	writeTime(&d.buf, true)
+	writeLevel(&d.buf, level, true)
+	writeContent(&d.buf, format, args)
+	os.Stdout.Write(d.buf.Bytes())
+}
+
+func (d *destinationStdout) close() {
+}

internal/logger/destination_syslog.go

@@ -0,0 +1,34 @@
+package logger
+
+import (
+	"bytes"
+	"io"
+)
+
+type destinationSysLog struct {
+	syslog io.WriteCloser
+	buf    bytes.Buffer
+}
+
+func newDestinationSyslog() (destination, error) {
+	syslog, err := newSysLog("mediamtx")
+	if err != nil {
+		return nil, err
+	}
+
+	return &destinationSysLog{
+		syslog: syslog,
+	}, nil
+}
+
+func (d *destinationSysLog) log(level Level, format string, args ...interface{}) {
+	d.buf.Reset()
+	writeTime(&d.buf, false)
+	writeLevel(&d.buf, level, false)
+	writeContent(&d.buf, format, args)
+	d.syslog.Write(d.buf.Bytes())
+}
+
+func (d *destinationSysLog) close() {
+	d.syslog.Close()
+}

internal/logger/level.go

@@ -0,0 +1,12 @@
+package logger
+
+// Level is a log level.
+type Level int
+
+// Log levels.
+const (
+	Debug Level = iota + 1
+	Info
+	Warn
+	Error
+)

internal/logger/logger.go

@@ -4,74 +4,46 @@ package logger
 import (
 	"bytes"
 	"fmt"
-	"io"
-	"os"
 	"sync"
 	"time"
 
 	"github.com/gookit/color"
 )
 
-// Level is a log level.
-type Level int
-
-// Log levels.
-const (
-	Debug Level = iota + 1
-	Info
-	Warn
-	Error
-)
-
-// Destination is a log destination.
-type Destination int
-
-const (
-	// DestinationStdout writes logs to the standard output.
-	DestinationStdout Destination = iota
-
-	// DestinationFile writes logs to a file.
-	DestinationFile
-
-	// DestinationSyslog writes logs to the system logger.
-	DestinationSyslog
-)
-
 // Logger is a log handler.
 type Logger struct {
-	level        Level
-	destinations map[Destination]struct{}
+	level Level
 
+	destinations []destination
 	mutex        sync.Mutex
-	file         *os.File
-	syslog       io.WriteCloser
-	stdoutBuffer bytes.Buffer
-	fileBuffer   bytes.Buffer
-	syslogBuffer bytes.Buffer
 }
 
 // New allocates a log handler.
-func New(level Level, destinations map[Destination]struct{}, filePath string) (*Logger, error) {
+func New(level Level, destinations []Destination, filePath string) (*Logger, error) {
 	lh := &Logger{
-		level:        level,
-		destinations: destinations,
+		level: level,
 	}
 
-	if _, ok := destinations[DestinationFile]; ok {
-		var err error
-		lh.file, err = os.OpenFile(filePath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0o644)
-		if err != nil {
-			lh.Close()
-			return nil, err
-		}
-	}
-
-	if _, ok := destinations[DestinationSyslog]; ok {
-		var err error
-		lh.syslog, err = newSyslog("mediamtx")
-		if err != nil {
-			lh.Close()
-			return nil, err
+	for _, destType := range destinations {
+		switch destType {
+		case DestinationStdout:
+			lh.destinations = append(lh.destinations, newDestionationStdout())
+
+		case DestinationFile:
+			dest, err := newDestinationFile(filePath)
+			if err != nil {
+				lh.Close()
+				return nil, err
+			}
+			lh.destinations = append(lh.destinations, dest)
+
+		case DestinationSyslog:
+			dest, err := newDestinationSyslog()
+			if err != nil {
+				lh.Close()
+				return nil, err
+			}
+			lh.destinations = append(lh.destinations, dest)
 		}
 	}
 
@@ -80,12 +52,8 @@ func New(level Level, destinations map[Destination]struct{}, filePath string) (*
 
 // Close closes a log handler.
 func (lh *Logger) Close() {
-	if lh.file != nil {
-		lh.file.Close()
-	}
-
-	if lh.syslog != nil {
-		lh.syslog.Close()
+	for _, dest := range lh.destinations {
+		dest.close()
 	}
 }
 
@@ -182,27 +150,7 @@ func (lh *Logger) Log(level Level, format string, args ...interface{}) {
 	lh.mutex.Lock()
 	defer lh.mutex.Unlock()
 
-	if _, ok := lh.destinations[DestinationStdout]; ok {
-		lh.stdoutBuffer.Reset()
-		writeTime(&lh.stdoutBuffer, true)
-		writeLevel(&lh.stdoutBuffer, level, true)
-		writeContent(&lh.stdoutBuffer, format, args)
-		os.Stdout.Write(lh.stdoutBuffer.Bytes())
-	}
-
-	if _, ok := lh.destinations[DestinationFile]; ok {
-		lh.fileBuffer.Reset()
-		writeTime(&lh.fileBuffer, false)
-		writeLevel(&lh.fileBuffer, level, false)
-		writeContent(&lh.fileBuffer, format, args)
-		lh.file.Write(lh.fileBuffer.Bytes())
-	}
-
-	if _, ok := lh.destinations[DestinationSyslog]; ok {
-		lh.syslogBuffer.Reset()
-		writeTime(&lh.syslogBuffer, false)
-		writeLevel(&lh.syslogBuffer, level, false)
-		writeContent(&lh.syslogBuffer, format, args)
-		lh.syslog.Write(lh.syslogBuffer.Bytes())
+	for _, dest := range lh.destinations {
+		dest.log(level, format, args...)
 	}
 }

internal/logger/syslog_unix.go

@@ -12,7 +12,7 @@ type syslog struct {
 	inner *native.Writer
 }
 
-func newSyslog(prefix string) (io.WriteCloser, error) {
+func newSysLog(prefix string) (io.WriteCloser, error) {
 	inner, err := native.New(native.LOG_INFO|native.LOG_DAEMON, prefix)
 	if err != nil {
 		return nil, err

internal/logger/syslog_win.go

@@ -8,6 +8,6 @@ import (
 	"io"
 )
 
-func newSyslog(prefix string) (io.WriteCloser, error) {
+func newSysLog(prefix string) (io.WriteCloser, error) {
 	return nil, fmt.Errorf("not implemented on windows")
 }

internal/logger/writer.go

@@ -0,0 +1,6 @@
+package logger
+
+// Writer is an object that provides a log method.
+type Writer interface {
+	Log(Level, string, ...interface{})
+}