From 0495c1ed4b6ca44997f55db2ad75a2ecf359935f Mon Sep 17 00:00:00 2001 From: aler9 <46489434+aler9@users.noreply.github.com> Date: Sat, 31 Oct 2020 16:45:19 +0100 Subject: [PATCH] remove useless close() --- client/client.go | 10 ---------- sourcertmp/source.go | 2 -- sourcertsp/source.go | 3 --- 3 files changed, 15 deletions(-) diff --git a/client/client.go b/client/client.go index 99e91f9d..632e5147 100644 --- a/client/client.go +++ b/client/client.go @@ -832,8 +832,6 @@ func (c *Client) handleRequest(req *base.Request) error { func (c *Client) runInitial() bool { readDone := make(chan error) go func() { - defer close(readDone) - for { req, err := c.conn.ReadRequest() if err != nil { @@ -958,8 +956,6 @@ func (c *Client) runPlay() bool { func (c *Client) runPlayUDP() { readDone := make(chan error) go func() { - defer close(readDone) - for { req, err := c.conn.ReadRequest() if err != nil { @@ -999,8 +995,6 @@ func (c *Client) runPlayTCP() { readDone := make(chan error) go func() { - defer close(readDone) - for { recv, err := c.conn.ReadFrameTCPOrRequest(false) if err != nil { @@ -1144,8 +1138,6 @@ func (c *Client) runRecord() bool { func (c *Client) runRecordUDP() { readDone := make(chan error) go func() { - defer close(readDone) - for { req, err := c.conn.ReadRequest() if err != nil { @@ -1220,8 +1212,6 @@ func (c *Client) runRecordTCP() { readDone := make(chan error) go func() { - defer close(readDone) - for { recv, err := c.conn.ReadFrameTCPOrRequest(true) if err != nil { diff --git a/sourcertmp/source.go b/sourcertmp/source.go index b95490ef..f169739d 100644 --- a/sourcertmp/source.go +++ b/sourcertmp/source.go @@ -270,8 +270,6 @@ func (s *Source) runInnerInner() bool { readDone := make(chan error) go func() { - defer close(readDone) - for { pkt, err := conn.ReadPacket() if err != nil { diff --git a/sourcertsp/source.go b/sourcertsp/source.go index 709de9c6..d29f0ecf 100644 --- a/sourcertsp/source.go +++ b/sourcertsp/source.go @@ -253,7 +253,6 @@ func (s *Source) runUDP(u *url.URL, conn *gortsplib.ConnClient, tracks gortsplib tcpConnDone := make(chan error) go func() { - defer close(tcpConnDone) tcpConnDone <- conn.LoopUDP() }() @@ -305,8 +304,6 @@ func (s *Source) runTCP(u *url.URL, conn *gortsplib.ConnClient, tracks gortsplib tcpConnDone := make(chan error) go func() { - defer close(tcpConnDone) - for { trackId, streamType, content, err := conn.ReadFrameTCP() if err != nil {