You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
106 lines
4.1 KiB
106 lines
4.1 KiB
// |
|
// Issue.cs |
|
// |
|
// Author: |
|
// Ciprian Khlud <ciprian.mustiata@yahoo.com> |
|
// |
|
// Copyright (c) 2013 Ciprian Khlud |
|
// |
|
// Permission is hereby granted, free of charge, to any person obtaining a copy |
|
// of this software and associated documentation files (the "Software"), to deal |
|
// in the Software without restriction, including without limitation the rights |
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell |
|
// copies of the Software, and to permit persons to whom the Software is |
|
// furnished to do so, subject to the following conditions: |
|
// |
|
// The above copyright notice and this permission notice shall be included in |
|
// all copies or substantial portions of the Software. |
|
// |
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE |
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, |
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN |
|
// THE SOFTWARE. |
|
|
|
using System.Collections.Generic; |
|
using ICSharpCode.NRefactory.Refactoring; |
|
|
|
namespace ICSharpCode.NRefactory.CSharp.Refactoring |
|
{ |
|
|
|
[IssueDescription ("';' should be avoided", |
|
Description = "';' should be avoided. Use '{}' instead", |
|
Category = IssueCategories.CodeQualityIssues, |
|
Severity = Severity.Warning, |
|
IssueMarker = IssueMarker.Underline)] |
|
public class UseBlockInsteadColonIssue : ICodeIssueProvider |
|
{ |
|
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context) |
|
{ |
|
return new GatherVisitor (context).GetIssues (); |
|
} |
|
|
|
class GatherVisitor : GatherVisitorBase<IdenticalConditionalBranchIssue> |
|
{ |
|
private readonly string _commandTitle; |
|
|
|
public GatherVisitor (BaseRefactoringContext ctx) |
|
: base (ctx) |
|
{ |
|
_commandTitle = ctx.TranslateString("';' should be avoided. Use '{}' instead"); |
|
} |
|
|
|
public override void VisitWhileStatement(WhileStatement whileStatement) |
|
{ |
|
base.VisitWhileStatement(whileStatement); |
|
var statement = whileStatement.EmbeddedStatement as EmptyStatement; |
|
if (statement == null) |
|
return; |
|
|
|
AddIssue(whileStatement.EmbeddedStatement, |
|
_commandTitle, |
|
script => script.Replace(whileStatement.EmbeddedStatement, new BlockStatement())); |
|
|
|
} |
|
|
|
public override void VisitForeachStatement(ForeachStatement foreachStatement) |
|
{ |
|
base.VisitForeachStatement(foreachStatement); |
|
var statement = foreachStatement.EmbeddedStatement as EmptyStatement; |
|
if (statement == null) |
|
return; |
|
|
|
AddIssue(foreachStatement.EmbeddedStatement, |
|
_commandTitle, |
|
script => script.Replace(foreachStatement.EmbeddedStatement, new BlockStatement())); |
|
} |
|
|
|
public override void VisitIfElseStatement(IfElseStatement ifElseStatement) |
|
{ |
|
base.VisitIfElseStatement(ifElseStatement); |
|
var statement = ifElseStatement.TrueStatement as EmptyStatement; |
|
if(statement==null) |
|
return; |
|
AddIssue(ifElseStatement.TrueStatement, |
|
_commandTitle, |
|
script => script.Replace(ifElseStatement.TrueStatement, new BlockStatement())); |
|
} |
|
|
|
public override void VisitForStatement(ForStatement forStatement) |
|
{ |
|
base.VisitForStatement(forStatement); |
|
|
|
var statement = forStatement.EmbeddedStatement as EmptyStatement; |
|
if (statement == null) |
|
return; |
|
|
|
AddIssue(forStatement.EmbeddedStatement, |
|
_commandTitle, |
|
script => script.Replace(forStatement.EmbeddedStatement, new BlockStatement())); |
|
} |
|
} |
|
} |
|
|
|
}
|
|
|