#develop (short for SharpDevelop) is a free IDE for .NET programming languages.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 

156 lines
6.1 KiB

//
// ParameterCanBeIEnumerableIssue.cs
//
// Author:
// Ciprian Khlud <ciprian.mustiata@yahoo.com>
//
// Copyright (c) 2013 Ciprian Khlud
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using System.Collections.Generic;
using ICSharpCode.NRefactory.TypeSystem;
using ICSharpCode.NRefactory.Semantics;
using System.Linq;
namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
[IssueDescription("A parameter can IEnumerable/ICollection/IList<T>",
Description = "Finds parameters that can be demoted to a generic list.",
Category = IssueCategories.Opportunities,
Severity = Severity.Suggestion
)]
public class ParameterCanBeIEnumerableIssue : ICodeIssueProvider
{
readonly bool tryResolve;
public ParameterCanBeIEnumerableIssue() : this (true)
{
}
public ParameterCanBeIEnumerableIssue(bool tryResolve)
{
this.tryResolve = tryResolve;
}
#region ICodeIssueProvider implementation
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var gatherer = new GatherVisitor(context, tryResolve);
var issues = gatherer.GetIssues();
return issues;
}
#endregion
class GatherVisitor : GatherVisitorBase<ParameterCanBeDemotedIssue>
{
bool tryResolve;
public GatherVisitor(BaseRefactoringContext context, bool tryResolve) : base (context)
{
this.tryResolve = tryResolve;
}
public override void VisitMethodDeclaration(MethodDeclaration methodDeclaration)
{
methodDeclaration.Attributes.AcceptVisitor(this);
if (HasEntryPointSignature(methodDeclaration))
return;
var eligibleParameters = methodDeclaration.Parameters
.Where(p => p.ParameterModifier != ParameterModifier.Out && p.ParameterModifier != ParameterModifier.Ref)
.ToList();
if (eligibleParameters.Count == 0)
return;
var declarationResolveResult = ctx.Resolve(methodDeclaration) as MemberResolveResult;
if (declarationResolveResult == null)
return;
var member = declarationResolveResult.Member;
if (member.IsOverride || member.IsOverridable || member.ImplementedInterfaceMembers.Any())
return;
var collector = new TypeCriteriaCollector(ctx);
methodDeclaration.AcceptVisitor(collector);
foreach (var parameter in eligibleParameters) {
ProcessParameter(parameter, methodDeclaration.Body, collector);
}
}
bool HasEntryPointSignature(MethodDeclaration methodDeclaration)
{
if (!methodDeclaration.Modifiers.HasFlag(Modifiers.Static))
return false;
var returnType = ctx.Resolve(methodDeclaration.ReturnType).Type;
if (!returnType.IsKnownType(KnownTypeCode.Int32) && !returnType.IsKnownType(KnownTypeCode.Void))
return false;
var parameterCount = methodDeclaration.Parameters.Count;
if (parameterCount == 0)
return true;
if (parameterCount != 1)
return false;
var parameterType = ctx.Resolve(methodDeclaration.Parameters.First()).Type as ArrayType;
return parameterType != null && parameterType.ElementType.IsKnownType(KnownTypeCode.String);
}
void ProcessParameter(ParameterDeclaration parameter, AstNode rootResolutionNode, TypeCriteriaCollector collector)
{
var localResolveResult = ctx.Resolve(parameter) as LocalResolveResult;
if (localResolveResult == null)
return;
var variable = localResolveResult.Variable;
var typeKind = variable.Type.Kind;
if (!(typeKind == TypeKind.Class ||
typeKind == TypeKind.Struct ||
typeKind == TypeKind.Interface ||
typeKind == TypeKind.Array) ||
!collector.UsedVariables.Contains(variable))
{
return;
}
var candidateTypes = localResolveResult.Type.GetAllBaseTypes()
.Where(t => t.IsParameterized)
.ToList();
var validTypes =
(from type in candidateTypes
where !tryResolve || ParameterCanBeDemotedIssue.TypeChangeResolvesCorrectly(ctx, parameter, rootResolutionNode, type)
select type).ToList();
if (!validTypes.Any()) return;
var foundType = validTypes.FirstOrDefault();
if (foundType == null)
return;
AddIssue(parameter.NameToken, string.Format(ctx.TranslateString("Parameter can be {0}"),
foundType.Name),
script => script.Replace(parameter.Type, CreateShortType(ctx, foundType, parameter)));
}
public static AstType CreateShortType(BaseRefactoringContext refactoringContext, IType expressionType, AstNode node)
{
var csResolver = refactoringContext.Resolver.GetResolverStateBefore(node);
var builder = new TypeSystemAstBuilder(csResolver);
return builder.ConvertType(expressionType);
}
}
}
}