You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
143 lines
3.7 KiB
143 lines
3.7 KiB
// |
|
// RedundantNullCheckTests.cs |
|
// |
|
// Author: |
|
// Ji Kun <jikun.nus@gmail.com> |
|
// |
|
// Copyright (c) 2013 Ji Kun |
|
// |
|
// Permission is hereby granted, free of charge, to any person obtaining a copy |
|
// of this software and associated documentation files (the "Software"), to deal |
|
// in the Software without restriction, including without limitation the rights |
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell |
|
// copies of the Software, and to permit persons to whom the Software is |
|
// furnished to do so, subject to the following conditions: |
|
// |
|
// The above copyright notice and this permission notice shall be included in |
|
// all copies or substantial portions of the Software. |
|
// |
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE |
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, |
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN |
|
// THE SOFTWARE. |
|
using System; |
|
using NUnit.Framework; |
|
using ICSharpCode.NRefactory.CSharp.Refactoring; |
|
using ICSharpCode.NRefactory.CSharp.CodeActions; |
|
|
|
namespace ICSharpCode.NRefactory.CSharp.CodeIssues |
|
{ |
|
[TestFixture] |
|
public class RedundantNullCheckTests : InspectionActionTestBase |
|
{ |
|
[Test] |
|
public void TestInspectorCase1() |
|
{ |
|
var input = @"using System;class Test {public void test(){int a = 0;if(a is int && a != null){a = 1;}}}"; |
|
|
|
TestRefactoringContext context; |
|
var issues = GetIssues(new RedundantNullCheckIssue(), input, out context); |
|
Assert.AreEqual(1, issues.Count); |
|
|
|
|
|
CheckFix(context, issues, @"using System;class Test {public void test(){int a = 0; |
|
if (a is int) { |
|
a = 1; |
|
}}}"); |
|
} |
|
|
|
[Test] |
|
public void TestResharperDisable() |
|
{ |
|
var input = @"using System; |
|
class Test { |
|
public void test(){ |
|
int a = 0; |
|
//Resharper disable RedundantNullCheck |
|
if(a is int && a != null) |
|
{a = 1;} |
|
//Resharper restore RedundantNullCheck |
|
} |
|
}"; |
|
|
|
TestRefactoringContext context; |
|
var issues = GetIssues(new RedundantNullCheckIssue(), input, out context); |
|
Assert.AreEqual(0, issues.Count); |
|
} |
|
|
|
[Test] |
|
public void TestInspectorCase2() |
|
{ |
|
var input = @"using System;class Test {public void test(){int a = 0;while(a != null && a is int){a = 1;}}}"; |
|
|
|
TestRefactoringContext context; |
|
var issues = GetIssues(new RedundantNullCheckIssue(), input, out context); |
|
Assert.AreEqual(1, issues.Count); |
|
CheckFix(context, issues, @"using System;class Test {public void test(){int a = 0; |
|
while (a is int) { |
|
a = 1; |
|
}}}"); |
|
} |
|
|
|
[Ignore("Missing")] |
|
[Test] |
|
public void TestCaseWithFullParens() |
|
{ |
|
var input = |
|
@"using System; |
|
class TestClass |
|
{ |
|
public void Test(object o) |
|
{ |
|
if (!((o is int) && (o != null))) { |
|
} |
|
} |
|
}"; |
|
|
|
TestRefactoringContext context; |
|
var issues = GetIssues(new RedundantNullCheckIssue(), input, out context); |
|
Assert.AreEqual(1, issues.Count); |
|
CheckFix(context, issues, @"using System; |
|
class TestClass |
|
{ |
|
public void Test(object o) |
|
{ |
|
if (!(o is int)) { |
|
} |
|
} |
|
}"); |
|
} |
|
|
|
[Ignore("Extended version")] |
|
[Test] |
|
public void TestNegatedCase() |
|
{ |
|
var input = |
|
@"using System; |
|
class TestClass |
|
{ |
|
public void Test(object o) |
|
{ |
|
if (null == o || !(o is int)) { |
|
} |
|
} |
|
}"; |
|
|
|
TestRefactoringContext context; |
|
var issues = GetIssues(new RedundantNullCheckIssue(), input, out context); |
|
Assert.AreEqual(1, issues.Count); |
|
CheckFix(context, issues, @"using System; |
|
class TestClass |
|
{ |
|
public void Test(object o) |
|
{ |
|
if (!(o is int)) { |
|
} |
|
} |
|
}"); |
|
} |
|
} |
|
} |