// // SimplifyAnonymousMethodToDelegateIssue.cs // // Author: // Mike Krüger // // Copyright (c) 2013 Xamarin Inc. (http://xamarin.com) // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell // copies of the Software, and to permit persons to whom the Software is // furnished to do so, subject to the following conditions: // // The above copyright notice and this permission notice shall be included in // all copies or substantial portions of the Software. // // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. using System; using System.Collections.Generic; using System.Linq; using ICSharpCode.NRefactory.PatternMatching; namespace ICSharpCode.NRefactory.CSharp.Refactoring { [IssueDescription("Simplify anonymous method to delegate", Description = "Shows anonymous methods that can be simplified.", Category = IssueCategories.CodeQualityIssues, Severity = Severity.Warning)] public class SimplifyAnonymousMethodToDelegateIssue : ICodeIssueProvider { public IEnumerable GetIssues(BaseRefactoringContext context) { return new GatherVisitor(context).GetIssues(); } class GatherVisitor : GatherVisitorBase { public GatherVisitor (BaseRefactoringContext ctx) : base (ctx) { } static Pattern pattern = new Choice { new BlockStatement { new ReturnStatement (new AnyNode ("invoke")) }, new AnyNode ("invoke") }; static InvocationExpression AnalyzeBody(AstNode body) { var m = pattern.Match(body); if (m.Success) return m.Get("invoke").Single () as InvocationExpression; return null; } static bool IsSimpleTarget(Expression target) { if (target is IdentifierExpression) return true; var mref = target as MemberReferenceExpression; if (mref != null) return IsSimpleTarget (mref.Target); var pref = target as PointerReferenceExpression; if (pref != null) return IsSimpleTarget (pref.Target); return false; } void AnalyzeExpression(AstNode expression, AstNode body, AstNodeCollection parameters) { var invocation = AnalyzeBody(body); if (invocation == null) return; if (!IsSimpleTarget (invocation.Target)) return; var lambdaParameters = parameters.ToList(); if (lambdaParameters.Count != invocation.Arguments.Count) return; int i = 0; foreach (var param in invocation.Arguments) { var id = param as IdentifierExpression; if (id == null) return; if (lambdaParameters[i].Name != id.Identifier) return; i++; } AddIssue(expression, ctx.TranslateString("Expression can be reduced to delegate"), script => { script.Replace(expression, invocation.Target.Clone()); }); } public override void VisitLambdaExpression(LambdaExpression lambdaExpression) { base.VisitLambdaExpression(lambdaExpression); AnalyzeExpression(lambdaExpression, lambdaExpression.Body, lambdaExpression.Parameters); } public override void VisitAnonymousMethodExpression(AnonymousMethodExpression anonymousMethodExpression) { base.VisitAnonymousMethodExpression(anonymousMethodExpression); AnalyzeExpression(anonymousMethodExpression, anonymousMethodExpression.Body, anonymousMethodExpression.Parameters); } } } }