From fd03921b134c220b8b7d0802069e6aae60a51034 Mon Sep 17 00:00:00 2001 From: Daniel Grunwald Date: Thu, 26 Mar 2009 18:47:30 +0000 Subject: [PATCH] Fixed exception when hovering mouse outside of document. Fixed exception when menu has no subitems. Fixed opening options dialog. git-svn-id: svn://svn.sharpdevelop.net/sharpdevelop/trunk@3923 1ccf3a8d-04fe-1044-b7c0-cef0b8235c61 --- .../Frontend/AddIn/ICSharpCode.Profiler.AddIn.addin | 6 +++--- .../Project/Src/ToolTips/ResourceToolTipProvider.cs | 3 +++ .../Base/Project/Src/Services/Debugger/DebuggerService.cs | 2 ++ src/Main/ICSharpCode.Core.Presentation/Menu/MenuService.cs | 6 ++++-- 4 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/AddIns/Misc/Profiler/Frontend/AddIn/ICSharpCode.Profiler.AddIn.addin b/src/AddIns/Misc/Profiler/Frontend/AddIn/ICSharpCode.Profiler.AddIn.addin index ca58a9a24f..fd51f12734 100644 --- a/src/AddIns/Misc/Profiler/Frontend/AddIn/ICSharpCode.Profiler.AddIn.addin +++ b/src/AddIns/Misc/Profiler/Frontend/AddIn/ICSharpCode.Profiler.AddIn.addin @@ -70,12 +70,12 @@ - - - + diff --git a/src/AddIns/Misc/ResourceToolkit/Project/Src/ToolTips/ResourceToolTipProvider.cs b/src/AddIns/Misc/ResourceToolkit/Project/Src/ToolTips/ResourceToolTipProvider.cs index e611f632dc..6d3bcbf3b0 100644 --- a/src/AddIns/Misc/ResourceToolkit/Project/Src/ToolTips/ResourceToolTipProvider.cs +++ b/src/AddIns/Misc/ResourceToolkit/Project/Src/ToolTips/ResourceToolTipProvider.cs @@ -23,6 +23,9 @@ namespace Hornung.ResourceToolkit.ToolTips { public void HandleToolTipRequest(ToolTipRequestEventArgs e) { + if (!e.InDocument) + return; + Location logicPos = e.LogicalPosition; IDocument doc = e.Editor.Document; if (logicPos.X > doc.GetLine(logicPos.Y).Length) { diff --git a/src/Main/Base/Project/Src/Services/Debugger/DebuggerService.cs b/src/Main/Base/Project/Src/Services/Debugger/DebuggerService.cs index 07a6e14cd5..fa0851b491 100644 --- a/src/Main/Base/Project/Src/Services/Debugger/DebuggerService.cs +++ b/src/Main/Base/Project/Src/Services/Debugger/DebuggerService.cs @@ -295,6 +295,8 @@ namespace ICSharpCode.SharpDevelop.Debugging /// internal static void HandleToolTipRequest(ToolTipRequestEventArgs e) { + if (!e.InDocument) + return; Location logicPos = e.LogicalPosition; var doc = e.Editor.Document; IExpressionFinder expressionFinder = ParserService.GetExpressionFinder(e.Editor.FileName); diff --git a/src/Main/ICSharpCode.Core.Presentation/Menu/MenuService.cs b/src/Main/ICSharpCode.Core.Presentation/Menu/MenuService.cs index 7247dbf972..2a9253c8d6 100644 --- a/src/Main/ICSharpCode.Core.Presentation/Menu/MenuService.cs +++ b/src/Main/ICSharpCode.Core.Presentation/Menu/MenuService.cs @@ -78,8 +78,10 @@ namespace ICSharpCode.Core.Presentation internal static IList CreateMenuItems(UIElement inputBindingOwner, IEnumerable descriptors) { ArrayList result = new ArrayList(); - foreach (MenuItemDescriptor descriptor in descriptors) { - result.Add(CreateMenuItemFromDescriptor(inputBindingOwner, descriptor)); + if (descriptors != null) { + foreach (MenuItemDescriptor descriptor in descriptors) { + result.Add(CreateMenuItemFromDescriptor(inputBindingOwner, descriptor)); + } } return result; }