From f96f8dfd55ffa17e4cddd6f52db33d8b74678978 Mon Sep 17 00:00:00 2001 From: Siegfried Pammer Date: Sun, 18 Aug 2013 12:15:16 +0200 Subject: [PATCH] fix FileName comparison warning and make DefinitionViewPad less intrusive during solution load --- src/Main/Base/Project/ICSharpCode.SharpDevelop.csproj | 4 +++- .../Base/Project/Src/Gui/Pads/DefinitionViewPad.cs | 10 ++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/Main/Base/Project/ICSharpCode.SharpDevelop.csproj b/src/Main/Base/Project/ICSharpCode.SharpDevelop.csproj index 4718b2b505..91f99b9894 100644 --- a/src/Main/Base/Project/ICSharpCode.SharpDevelop.csproj +++ b/src/Main/Base/Project/ICSharpCode.SharpDevelop.csproj @@ -243,7 +243,9 @@ - + + StringListEditorDialog.xaml + StringListEditorXaml.xaml Code diff --git a/src/Main/Base/Project/Src/Gui/Pads/DefinitionViewPad.cs b/src/Main/Base/Project/Src/Gui/Pads/DefinitionViewPad.cs index fe5ded64f1..7033137237 100755 --- a/src/Main/Base/Project/Src/Gui/Pads/DefinitionViewPad.cs +++ b/src/Main/Base/Project/Src/Gui/Pads/DefinitionViewPad.cs @@ -85,8 +85,9 @@ namespace ICSharpCode.SharpDevelop.Gui async void UpdateTick(ParseInformationEventArgs e) { - timer.IsEnabled = ctl.IsVisible; - if (!ctl.IsVisible) return; + bool isActive = ctl.IsVisible && !SD.ParserService.LoadSolutionProjectsThread.IsRunning; + timer.IsEnabled = isActive; + if (!isActive) return; LoggingService.Debug("DefinitionViewPad.Update"); ResolveResult res = await ResolveAtCaretAsync(e); @@ -123,8 +124,9 @@ namespace ICSharpCode.SharpDevelop.Gui { if (pos.Equals(oldPosition)) return; oldPosition = pos; - if (pos.FileName != currentFileName) - LoadFile(new FileName(pos.FileName)); + var fileName = new FileName(pos.FileName); + if (fileName != currentFileName) + LoadFile(fileName); ctl.TextArea.Caret.Location = pos.Begin; Rect r = ctl.TextArea.Caret.CalculateCaretRectangle(); if (!r.IsEmpty) {