Browse Source

Made it easier to get the issues out of the gather visitor.

newNRvisualizers
Mike Krüger 14 years ago
parent
commit
f94402f920
  1. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ConditionalToNullCoalescingIssue.cs
  2. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ExplicitConversionInForEachIssue.cs
  3. 8
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/GatherVisitorBase.cs
  4. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/NotImplementedExceptionIssue.cs
  5. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantInternalIssue.cs
  6. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantNamespaceUsageIssue.cs
  7. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantPrivateIssue.cs
  8. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantThisIssue.cs
  9. 2
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantUsingIssue.cs
  10. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/StringIsNullOrEmptyIssue.cs
  11. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/UseVarKeywordIssue.cs

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ConditionalToNullCoalescingIssue.cs

@ -55,11 +55,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -55,11 +55,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
),
};
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var visitor = new GatherVisitor (context, this);
context.RootNode.AcceptVisitor (visitor);
return visitor.FoundIssues;
return new GatherVisitor(context, this).GetIssues();
}
class GatherVisitor : GatherVisitorBase

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ExplicitConversionInForEachIssue.cs

@ -30,11 +30,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -30,11 +30,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
Severity = Severity.Warning)]
public class ExplicitConversionInForEachIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var visitor = new GatherVisitor (context);
context.RootNode.AcceptVisitor (visitor);
return visitor.FoundIssues;
return new GatherVisitor(context).GetIssues();
}
class GatherVisitor : GatherVisitorBase

8
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/GatherVisitorBase.cs

@ -39,7 +39,13 @@ namespace ICSharpCode.NRefactory.CSharp @@ -39,7 +39,13 @@ namespace ICSharpCode.NRefactory.CSharp
{
this.ctx = ctx;
}
public IEnumerable<CodeIssue> GetIssues()
{
ctx.RootNode.AcceptVisitor(this);
return FoundIssues;
}
protected override void VisitChildren (AstNode node)
{
if (ctx.CancellationToken.IsCancellationRequested)

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/NotImplementedExceptionIssue.cs

@ -37,11 +37,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -37,11 +37,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
[IssueDescription("Show NotImplementedExceptions", Description="Shows NotImplementedException throws in the quick task bar.", Category = IssueCategories.Notifications, Severity = Severity.Suggestion, IssueMarker = IssueMarker.None)]
public class NotImplementedExceptionIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var visitor = new GatherVisitor (context, this);
context.RootNode.AcceptVisitor (visitor);
return visitor.FoundIssues;
return new GatherVisitor(context, this).GetIssues();
}
class GatherVisitor : GatherVisitorBase

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantInternalIssue.cs

@ -41,11 +41,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -41,11 +41,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
IssueMarker = IssueMarker.GrayOut)]
public class RedundantInternalIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var visitor = new GatherVisitor (context, this);
context.RootNode.AcceptVisitor (visitor);
return visitor.FoundIssues;
return new GatherVisitor(context, this).GetIssues();
}
class GatherVisitor : GatherVisitorBase

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantNamespaceUsageIssue.cs

@ -43,11 +43,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -43,11 +43,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
IssueMarker = IssueMarker.GrayOut)]
public class RedundantNamespaceUsageIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var visitor = new GatherVisitor (context, this);
context.RootNode.AcceptVisitor (visitor);
return visitor.FoundIssues;
return new GatherVisitor(context, this).GetIssues();
}
class GatherVisitor : GatherVisitorBase

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantPrivateIssue.cs

@ -41,11 +41,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -41,11 +41,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
IssueMarker = IssueMarker.GrayOut)]
public class RedundantPrivateIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var visitor = new GatherVisitor (context, this);
context.RootNode.AcceptVisitor (visitor);
return visitor.FoundIssues;
return new GatherVisitor(context, this).GetIssues();
}
class GatherVisitor : GatherVisitorBase

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantThisIssue.cs

@ -45,11 +45,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -45,11 +45,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
IssueMarker = IssueMarker.GrayOut)]
public class RedundantThisIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var visitor = new GatherVisitor (context, this);
context.RootNode.AcceptVisitor (visitor);
return visitor.FoundIssues;
return new GatherVisitor(context, this).GetIssues();
}
class GatherVisitor : GatherVisitorBase

2
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/RedundantUsingIssue.cs

@ -54,7 +54,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -54,7 +54,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
get { return namespacesToKeep; }
}
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var visitor = new GatherVisitor (context, this);
context.RootNode.AcceptVisitor (visitor);

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/StringIsNullOrEmptyIssue.cs

@ -70,11 +70,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -70,11 +70,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
),
};
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var visitor = new GatherVisitor (context, this);
context.RootNode.AcceptVisitor (visitor);
return visitor.FoundIssues;
return new GatherVisitor(context, this).GetIssues();
}
class GatherVisitor : GatherVisitorBase

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/UseVarKeywordIssue.cs

@ -43,11 +43,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -43,11 +43,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
IssueMarker = IssueMarker.None)]
public class UseVarKeywordIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var visitor = new GatherVisitor (context, this);
context.RootNode.AcceptVisitor (visitor);
return visitor.FoundIssues;
return new GatherVisitor(context, this).GetIssues();
}
class GatherVisitor : GatherVisitorBase

Loading…
Cancel
Save