Browse Source

Show NuGet package title in Manage Packages dialog.

In the packages list views display the package title
if it exists otherwise show the package id.
pull/44/merge
Matt Ward 12 years ago
parent
commit
f0cdd01d92
  1. 10
      src/AddIns/Misc/PackageManagement/Project/Src/IPackageExtensions.cs
  2. 4
      src/AddIns/Misc/PackageManagement/Project/Src/PackageViewModel.cs
  3. 2
      src/AddIns/Misc/PackageManagement/Project/Src/PackagesView.xaml
  4. 23
      src/AddIns/Misc/PackageManagement/Test/Src/PackageViewModelTests.cs

10
src/AddIns/Misc/PackageManagement/Project/Src/IPackageExtensions.cs

@ -17,5 +17,15 @@ namespace ICSharpCode.PackageManagement
return package.Description; return package.Description;
return package.Summary; return package.Summary;
} }
/// <summary>
/// Returns package Id if it has no title.
/// </summary>
public static string GetName(this IPackage package)
{
if (String.IsNullOrEmpty(package.Title))
return package.Id;
return package.Title;
}
} }
} }

4
src/AddIns/Misc/PackageManagement/Project/Src/PackageViewModel.cs

@ -133,6 +133,10 @@ namespace ICSharpCode.PackageManagement
get { return package.Id; } get { return package.Id; }
} }
public string Name {
get { return package.GetName(); }
}
public Uri IconUrl { public Uri IconUrl {
get { return package.IconUrl; } get { return package.IconUrl; }
} }

2
src/AddIns/Misc/PackageManagement/Project/Src/PackagesView.xaml

@ -52,7 +52,7 @@
Grid.Column="1" Grid.Column="1"
Margin="4, 0"> Margin="4, 0">
<TextBlock <TextBlock
Text="{Binding Path=Id}" Text="{Binding Path=Name}"
FontWeight="Bold"/> FontWeight="Bold"/>
<TextBlock <TextBlock
Text="{Binding Path=Summary}" Text="{Binding Path=Summary}"

23
src/AddIns/Misc/PackageManagement/Test/Src/PackageViewModelTests.cs

@ -1368,5 +1368,28 @@ namespace PackageManagement.Tests
var action = fakeActionRunner.ActionPassedToRun as InstallPackageAction; var action = fakeActionRunner.ActionPassedToRun as InstallPackageAction;
Assert.IsFalse(action.AllowPrereleaseVersions); Assert.IsFalse(action.AllowPrereleaseVersions);
} }
[Test]
public void Name_PackageHasIdButNoTitle_ReturnsPackageId()
{
CreateViewModel();
fakePackage.Id = "MyPackage";
string name = viewModel.Name;
Assert.AreEqual("MyPackage", name);
}
[Test]
public void Name_PackageHasIdAndTitle_ReturnsPackageId()
{
CreateViewModel();
fakePackage.Id = "MyPackage";
fakePackage.Title = "My Package Title";
string name = viewModel.Name;
Assert.AreEqual("My Package Title", name);
}
} }
} }

Loading…
Cancel
Save