Browse Source

fixed SD-1583 - Finalize() is visible in C# override completion

pull/14/head
Siegfried Pammer 15 years ago
parent
commit
eece1ecd85
  1. 2
      src/Main/Base/Project/Src/Editor/CodeCompletion/OverrideCompletionItemProvider.cs
  2. 17
      src/Main/ICSharpCode.SharpDevelop.Dom/Project/Src/LanguageProperties.cs

2
src/Main/Base/Project/Src/Editor/CodeCompletion/OverrideCompletionItemProvider.cs

@ -48,7 +48,7 @@ namespace ICSharpCode.SharpDevelop.Editor.CodeCompletion @@ -48,7 +48,7 @@ namespace ICSharpCode.SharpDevelop.Editor.CodeCompletion
LanguageProperties language = c.ProjectContent.Language;
OverrideCompletionItemList result = new OverrideCompletionItemList();
foreach (IMember m in GetOverridableMembers(c)) {
if (language.ShowMember(m, false)) {
if (language.ShowMemberInOverrideCompletion(m)) {
result.Items.Add(new OverrideCompletionItem(m));
}
}

17
src/Main/ICSharpCode.SharpDevelop.Dom/Project/Src/LanguageProperties.cs

@ -228,6 +228,11 @@ namespace ICSharpCode.SharpDevelop.Dom @@ -228,6 +228,11 @@ namespace ICSharpCode.SharpDevelop.Dom
}
return member.IsStatic == showStatic;
}
public virtual bool ShowMemberInOverrideCompletion(IMember member)
{
return true;
}
#endregion
/// <summary>
@ -320,6 +325,18 @@ namespace ICSharpCode.SharpDevelop.Dom @@ -320,6 +325,18 @@ namespace ICSharpCode.SharpDevelop.Dom
}
return true;
}
public override bool ShowMemberInOverrideCompletion(IMember member)
{
IMethod method = member as IMethod;
if (method != null) {
if (method.Name == "Finalize" && method.Parameters.Count == 0)
return false;
}
return base.ShowMemberInOverrideCompletion(member);
}
}
#endregion

Loading…
Cancel
Save