Browse Source

[CodeIssues] Update some strings to be more inline with the rest of the issues (and more informative too).

newNRvisualizers
Simon Lindgren 13 years ago
parent
commit
eea162a9c9
  1. 6
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/CallToVirtualFunctionFromConstructorIssue.cs
  2. 22
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/IncorrectExceptionParameterOrderingIssue.cs
  3. 2
      ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/SetterDoesNotUseValueParameterIssue.cs

6
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/CallToVirtualFunctionFromConstructorIssue.cs

@ -29,8 +29,8 @@ using ICSharpCode.NRefactory.Semantics; @@ -29,8 +29,8 @@ using ICSharpCode.NRefactory.Semantics;
namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
[IssueDescription("Virtual functions should not be called from constructors",
Description = "Warns about calls to virtual member functions occuring int the constructor.",
[IssueDescription("Constructors should not call virtual members",
Description = "Warns about calls to virtual member functions occuring in the constructor.",
Category = IssueCategories.CodeQualityIssues,
Severity = Severity.Warning)]
public class CallToVirtualFunctionFromConstructorIssue : ICodeIssueProvider
@ -76,7 +76,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -76,7 +76,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
return;
if (targetMethod.IsVirtualCall)
AddIssue(invocationExpression,
context.TranslateString("Calling virtual functions in constructors is bad practice."));
context.TranslateString("Calling virtual functions in constructors is bad practice"));
}
}
}

22
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/IncorrectExceptionParameterOrderingIssue.cs

@ -77,14 +77,20 @@ namespace ICSharpCode.NRefactory.CSharp @@ -77,14 +77,20 @@ namespace ICSharpCode.NRefactory.CSharp
return;
if (!func(leftLength, rightLength))
AddIssue(objectCreateExpression,
context.TranslateString("Swap parameters"),
script => {
var newOCE = objectCreateExpression.Clone() as ObjectCreateExpression;
newOCE.Arguments.Clear();
newOCE.Arguments.Add(secondParam.Clone());
newOCE.Arguments.Add(firstParam.Clone());
script.Replace(objectCreateExpression, newOCE);
});
context.TranslateString("The parameters are in the wrong order"),
GetActions(objectCreateExpression, firstParam, secondParam));
}
IEnumerable<CodeAction> GetActions(ObjectCreateExpression objectCreateExpression,
PrimitiveExpression firstParam, PrimitiveExpression secondParam)
{
yield return new CodeAction(context.TranslateString("Swap parameters"), script => {
var newOCE = objectCreateExpression.Clone() as ObjectCreateExpression;
newOCE.Arguments.Clear();
newOCE.Arguments.Add(secondParam.Clone());
newOCE.Arguments.Add(firstParam.Clone());
script.Replace(objectCreateExpression, newOCE);
});
}
}
}

2
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/SetterDoesNotUseValueParameterIssue.cs

@ -86,7 +86,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring @@ -86,7 +86,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring
}, CancellationToken.None);
if(!referenceFound)
AddIssue(node, context.TranslateString("The setter does not use the 'value' parameter."));
AddIssue(node, context.TranslateString("The setter does not use the 'value' parameter"));
}
}
}

Loading…
Cancel
Save