From d09dc0e10ae496bf0aa9d156a89faa42a8563c6b Mon Sep 17 00:00:00 2001 From: Daniel Grunwald Date: Wed, 8 May 2013 20:32:18 +0200 Subject: [PATCH] Fix compiler warnings --- .../Main.cs | 4 +-- ICSharpCode.NRefactory.CSharp/Ast/AstNode.cs | 2 +- ICSharpCode.NRefactory.CSharp/Ast/AstType.cs | 9 +++++ .../Completion/CSharpCompletionEngine.cs | 2 +- .../Formatter/CSharpFormatter.cs | 1 - .../OutputVisitor/CSharpAmbience.cs | 4 +-- .../Refactoring/CodeAction.cs | 5 +++ .../Refactoring/CodeActions/AddUsingAction.cs | 2 +- .../ConvertAnonymousDelegateToLambdaAction.cs | 2 +- .../CreateClassDeclarationAction.cs | 2 +- .../CodeActions/ExtractFieldAction.cs | 4 +-- .../FlipOperatorArgumentsAction.cs | 2 +- .../SplitDeclarationAndAssignmentAction.cs | 2 +- .../CodeActions/UseExplicitTypeAction.cs | 6 ++-- .../CodeActions/UseVarKeywordAction.cs | 6 ++-- .../CodeIssues/ConvertToStaticMethodIssue.cs | 3 -- .../ExplicitConversionInForEachIssue.cs | 4 +-- .../CodeIssues/GatherVisitorBase.cs | 2 +- .../RedundantArrayInitializerCommaIssue.cs | 2 +- .../CodeIssues/RedundantAssignmentIssue.cs | 2 +- ...erenceToStaticMemberViaDerivedTypeIssue.cs | 2 +- .../CodeIssues/UseVarKeywordIssue.cs | 2 +- .../Resolver/CSharpAstResolver.cs | 2 +- .../Resolver/ResolveVisitor.cs | 10 ++---- ICSharpCode.NRefactory.Demo/CSDemo.cs | 2 +- ICSharpCode.NRefactory.GtkDemo/MainWindow.cs | 2 +- .../CodeCompletion/CodeCompletionBugTests.cs | 6 ++-- .../CSharp/Parser/Bugs/ParserBugTests.cs | 34 +++++++++---------- .../CSharp/Parser/ParseUtil.cs | 2 +- .../CSharp/QueryExpressionExpanderTests.cs | 2 +- 30 files changed, 64 insertions(+), 66 deletions(-) diff --git a/ICSharpCode.NRefactory.CSharp.AstVerifier/Main.cs b/ICSharpCode.NRefactory.CSharp.AstVerifier/Main.cs index 54ac57b80a..9fa2877a46 100644 --- a/ICSharpCode.NRefactory.CSharp.AstVerifier/Main.cs +++ b/ICSharpCode.NRefactory.CSharp.AstVerifier/Main.cs @@ -56,13 +56,13 @@ namespace ICSharpCode.NRefactory.CSharp.AstVerifier int failed = 0, passed = 0; Console.WriteLine ("search in " + directory); foreach (var file in Directory.GetFileSystemEntries (directory, "*", SearchOption.AllDirectories)) { - if (!file.EndsWith (".cs")) + if (!file.EndsWith (".cs", StringComparison.Ordinal)) continue; string text = File.ReadAllText (file); var unit = SyntaxTree.Parse (text, file); if (unit == null) continue; - string generated = unit.GetText (); + string generated = unit.ToString (); int i, j; if (!IsMatch (text, generated, out i, out j)) { if (i > 0 && j > 0 && verboseOutput) { diff --git a/ICSharpCode.NRefactory.CSharp/Ast/AstNode.cs b/ICSharpCode.NRefactory.CSharp/Ast/AstNode.cs index 114cb780c6..4f57eab320 100644 --- a/ICSharpCode.NRefactory.CSharp/Ast/AstNode.cs +++ b/ICSharpCode.NRefactory.CSharp/Ast/AstNode.cs @@ -958,7 +958,7 @@ namespace ICSharpCode.NRefactory.CSharp { if (IsNull) return "Null"; - string text = GetText(); + string text = ToString(); text = text.TrimEnd().Replace("\t", "").Replace(Environment.NewLine, " "); if (text.Length > 100) return text.Substring(0, 97) + "..."; diff --git a/ICSharpCode.NRefactory.CSharp/Ast/AstType.cs b/ICSharpCode.NRefactory.CSharp/Ast/AstType.cs index 3ffe410abe..e120d0cdbb 100644 --- a/ICSharpCode.NRefactory.CSharp/Ast/AstType.cs +++ b/ICSharpCode.NRefactory.CSharp/Ast/AstType.cs @@ -125,6 +125,15 @@ namespace ICSharpCode.NRefactory.CSharp return (AstType)base.Clone(); } + /// + /// Gets whether this type is a SimpleType "var". + /// + public bool IsVar() + { + SimpleType st = this as SimpleType; + return st != null && st.Identifier == "var" && st.TypeArguments.Count == 0; + } + /// /// Create an ITypeReference for this AstType. /// Uses the context (ancestors of this node) to determine the correct . diff --git a/ICSharpCode.NRefactory.CSharp/Completion/CSharpCompletionEngine.cs b/ICSharpCode.NRefactory.CSharp/Completion/CSharpCompletionEngine.cs index a791e1cd7a..c526f6d8e5 100644 --- a/ICSharpCode.NRefactory.CSharp/Completion/CSharpCompletionEngine.cs +++ b/ICSharpCode.NRefactory.CSharp/Completion/CSharpCompletionEngine.cs @@ -2210,7 +2210,7 @@ namespace ICSharpCode.NRefactory.CSharp.Completion var convertedParameter = builder.ConvertParameter(delegateMethod.Parameters [k]); if (convertedParameter.ParameterModifier == ParameterModifier.Params) convertedParameter.ParameterModifier = ParameterModifier.None; - sb.Append(convertedParameter.GetText(FormattingPolicy)); + sb.Append(convertedParameter.ToString(FormattingPolicy)); sbWithoutTypes.Append(delegateMethod.Parameters [k].Name); } diff --git a/ICSharpCode.NRefactory.CSharp/Formatter/CSharpFormatter.cs b/ICSharpCode.NRefactory.CSharp/Formatter/CSharpFormatter.cs index fe9f83fc5a..a6969fea7e 100644 --- a/ICSharpCode.NRefactory.CSharp/Formatter/CSharpFormatter.cs +++ b/ICSharpCode.NRefactory.CSharp/Formatter/CSharpFormatter.cs @@ -90,7 +90,6 @@ namespace ICSharpCode.NRefactory.CSharp /// Initializes a new instance of the class. /// /// The formatting policy to use. - /// The text document to work upon. /// The text editor options (optional). Default is: TextEditorOptions.Default public CSharpFormatter(CSharpFormattingOptions policy, TextEditorOptions options = null) { diff --git a/ICSharpCode.NRefactory.CSharp/OutputVisitor/CSharpAmbience.cs b/ICSharpCode.NRefactory.CSharp/OutputVisitor/CSharpAmbience.cs index ac7f6234e3..1cd38fc354 100644 --- a/ICSharpCode.NRefactory.CSharp/OutputVisitor/CSharpAmbience.cs +++ b/ICSharpCode.NRefactory.CSharp/OutputVisitor/CSharpAmbience.cs @@ -247,7 +247,7 @@ namespace ICSharpCode.NRefactory.CSharp { TypeSystemAstBuilder astBuilder = CreateAstBuilder(); AstNode astNode = astBuilder.ConvertVariable(v); - return astNode.GetText().TrimEnd(';', '\r', '\n'); + return astNode.ToString().TrimEnd(';', '\r', '\n'); } public string ConvertType(IType type) @@ -257,7 +257,7 @@ namespace ICSharpCode.NRefactory.CSharp TypeSystemAstBuilder astBuilder = CreateAstBuilder(); AstType astType = astBuilder.ConvertType(type); - return astType.GetText(); + return astType.ToString(); } public void ConvertType(IType type, IOutputFormatter formatter, CSharpFormattingOptions formattingPolicy) diff --git a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeAction.cs b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeAction.cs index 5a056314e9..7658a9e071 100644 --- a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeAction.cs +++ b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeAction.cs @@ -73,6 +73,9 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring /// /// The code transformation. /// + /// + /// A node that specifies the start/end positions for the code action. + /// public CodeAction (string description, Action