From 29ed436f0ee5600a3594d87fdee4052dbc4dc619 Mon Sep 17 00:00:00 2001 From: gumme Date: Wed, 24 Sep 2014 14:15:28 +0200 Subject: [PATCH 1/2] Drop handler is now giving correct feedback to drag source. --- .../Project/Services/CreateComponentTool.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/AddIns/DisplayBindings/WpfDesign/WpfDesign.Designer/Project/Services/CreateComponentTool.cs b/src/AddIns/DisplayBindings/WpfDesign/WpfDesign.Designer/Project/Services/CreateComponentTool.cs index 21df7aedcf..9ccdcd1e81 100644 --- a/src/AddIns/DisplayBindings/WpfDesign/WpfDesign.Designer/Project/Services/CreateComponentTool.cs +++ b/src/AddIns/DisplayBindings/WpfDesign/WpfDesign.Designer/Project/Services/CreateComponentTool.cs @@ -123,6 +123,10 @@ namespace ICSharpCode.WpfDesign.Designer.Services moveLogic.DesignPanel.IsAdornerLayerHitTestVisible = true; moveLogic = null; changeGroup.Commit(); + + // Return allowed effects to drag source to signal that the drop was successful. + e.Effects = e.Effects; + e.Handled = true; } } catch (Exception x) { DragDropExceptionHandler.RaiseUnhandledException(x); From fcd3a2def1c983fab4add53fc515000f06a1b75e Mon Sep 17 00:00:00 2001 From: gumme Date: Mon, 6 Oct 2014 12:17:29 +0200 Subject: [PATCH 2/2] Removed unnecessary set of Effects property to same value, setting Handled to true is enough to give correct feedback to drag source. --- .../WpfDesign.Designer/Project/Services/CreateComponentTool.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/AddIns/DisplayBindings/WpfDesign/WpfDesign.Designer/Project/Services/CreateComponentTool.cs b/src/AddIns/DisplayBindings/WpfDesign/WpfDesign.Designer/Project/Services/CreateComponentTool.cs index 9ccdcd1e81..3071f29e06 100644 --- a/src/AddIns/DisplayBindings/WpfDesign/WpfDesign.Designer/Project/Services/CreateComponentTool.cs +++ b/src/AddIns/DisplayBindings/WpfDesign/WpfDesign.Designer/Project/Services/CreateComponentTool.cs @@ -124,8 +124,6 @@ namespace ICSharpCode.WpfDesign.Designer.Services moveLogic = null; changeGroup.Commit(); - // Return allowed effects to drag source to signal that the drop was successful. - e.Effects = e.Effects; e.Handled = true; } } catch (Exception x) {