Fixed SD2-656: Show tab order menu option should indicate current state

git-svn-id: svn://svn.sharpdevelop.net/sharpdevelop/trunk@1047 1ccf3a8d-04fe-1044-b7c0-cef0b8235c61

src/AddIns/DisplayBindings/FormsDesigner/Project/FormsDesigner.addin

@@ -41,6 +41,7 @@
 		          class       = "ICSharpCode.FormsDesigner.Commands.AlignToGrid"/>
 		<MenuItem id = "AlignSeparator" type = "Separator"/>
 		<MenuItem id          = "ViewTabOrder"
+		          type        = "CheckBox"
 		          label       = "${res:XML.MainMenu.FormatMenu.ShowTabOrder}"
 		          class       = "ICSharpCode.FormsDesigner.Commands.ViewTabOrder"/>
 		<MenuItem id          = "Lock"
@@ -79,6 +80,7 @@
 		          class       = "ICSharpCode.FormsDesigner.Commands.ViewCode"/>
 		<MenuItem id = "ViewCodeSeparator" type = "Separator"/>
 		<MenuItem id          = "ViewTabOrder"
+		          type        = "CheckBox"
 		          label       = "${res:XML.MainMenu.FormatMenu.ShowTabOrder}"
 		          class       = "ICSharpCode.FormsDesigner.Commands.ViewTabOrder"/>
 		<MenuItem id          = "Lock"
@@ -274,6 +276,7 @@
 				</MenuItem>
 				<MenuItem id = "OrderSeparator" type = "Separator"/>
 				<MenuItem id          = "ViewTabOrder"
+				          type        = "CheckBox"
 				          label       = "${res:XML.MainMenu.FormatMenu.ShowTabOrder}"
 				          class       = "ICSharpCode.FormsDesigner.Commands.ViewTabOrder"/>
 				<MenuItem id          = "Lock"

src/AddIns/DisplayBindings/FormsDesigner/Project/Src/Commands/FormsCommands.cs

@@ -447,11 +447,6 @@ namespace ICSharpCode.FormsDesigner.Commands
 	{
 		public override bool IsChecked {
 			get {
-				IWorkbenchWindow window = WorkbenchSingleton.Workbench.ActiveWorkbenchWindow;
-				if (window == null) {
-					return false;
-				}
-				
 				FormsDesignerViewContent formDesigner = FormDesigner;
 				if (formDesigner != null) {
 					return formDesigner.IsTabOrderMode;
@@ -474,11 +469,6 @@ namespace ICSharpCode.FormsDesigner.Commands
 		
 		void SetTabOrder(bool show)
 		{
-			IWorkbenchWindow window = WorkbenchSingleton.Workbench.ActiveWorkbenchWindow;
-			if (window == null) {
-				return;
-			}
-			
 			FormsDesignerViewContent formDesigner = FormDesigner;
 			if (formDesigner != null) {
 				if (show) {
@@ -488,12 +478,6 @@ namespace ICSharpCode.FormsDesigner.Commands
 				}
 			}
 		}
-		
-		public override void Run()
-		{
-			 SetTabOrder(!IsChecked);
-		}
 	}
 #endregion
-
 }

src/Main/Core/Project/Src/AddInTree/AddIn/DefaultDoozers/MenuItem/Gui/Menu.cs

@@ -20,6 +20,7 @@ namespace ICSharpCode.Core
 		Codon  codon;
 		object caller;
 		ArrayList subItems;
+		bool isInitialized;
 		
 		public Menu(Codon codon, object caller, ArrayList subItems)
 		{
@@ -29,10 +30,6 @@ namespace ICSharpCode.Core
 			this.RightToLeft = RightToLeft.Inherit;
 			
 			UpdateText();
-			CreateDropDownItems(); // must be created to support shortcuts
-			if (DropDownItems.Count == 0 && subItems.Count > 0) {
-				DropDownItems.Add(new ToolStripMenuItem());
-			}
 		}
 		
 		public Menu(string text, params ToolStripItem[] subItems)
@@ -80,6 +77,13 @@ namespace ICSharpCode.Core
 			if (codon != null) {
 				ConditionFailedAction failedAction = codon.GetFailedAction(caller);
 				this.Visible = failedAction != ConditionFailedAction.Exclude;
+				if (!isInitialized && failedAction != ConditionFailedAction.Exclude) {
+					isInitialized = true;
+					CreateDropDownItems(); // must be created to support shortcuts
+					if (DropDownItems.Count == 0 && subItems.Count > 0) {
+						DropDownItems.Add(new ToolStripMenuItem());
+					}
+				}
 			}
 		}
 		

src/Main/Core/Project/Src/AddInTree/AddIn/DefaultDoozers/MenuItem/Gui/MenuCheckBox.cs

@@ -80,7 +80,9 @@ namespace ICSharpCode.Core
 			if (codon != null) {
 				ConditionFailedAction failedAction = codon.GetFailedAction(caller);
 				this.Visible = failedAction != ConditionFailedAction.Exclude;
-				Checked = MenuCommand.IsChecked;
+				if (MenuCommand != null) {
+					Checked = MenuCommand.IsChecked;
+				}
 			}
 		}